Re: [PATCH 28/40] Input: atmel_mxt_ts - Add CHG line handling in bootloader code

2013-02-22 Thread Benson Leung
On Fri, Feb 22, 2013 at 9:58 AM, Nick Dyer wrote: > The bootloader state machine toggles the CHG/Interrupt line to indicate when > it has transitioned between states. Waiting for this event improves bootloader > reliability. > > Signed-off-by: Nick Dyer > --- >

Re: [PATCH 28/40] Input: atmel_mxt_ts - Add CHG line handling in bootloader code

2013-02-22 Thread Benson Leung
This is very similar to a patch that Daniel and I sent earlier this month. http://www.spinics.net/lists/linux-input/msg24666.html The major difference is that your wait_for_chg does a polling read of chg, while the one we worked on leaves the irq enabled and waits on completion. On Fri, Feb 22,

Re: [PATCH 28/40] Input: atmel_mxt_ts - Add CHG line handling in bootloader code

2013-02-22 Thread Benson Leung
This is very similar to a patch that Daniel and I sent earlier this month. http://www.spinics.net/lists/linux-input/msg24666.html The major difference is that your wait_for_chg does a polling read of chg, while the one we worked on leaves the irq enabled and waits on completion. On Fri, Feb 22,

Re: [PATCH 28/40] Input: atmel_mxt_ts - Add CHG line handling in bootloader code

2013-02-22 Thread Benson Leung
On Fri, Feb 22, 2013 at 9:58 AM, Nick Dyer nick.d...@itdev.co.uk wrote: The bootloader state machine toggles the CHG/Interrupt line to indicate when it has transitioned between states. Waiting for this event improves bootloader reliability. Signed-off-by: Nick Dyer nick.d...@itdev.co.uk ---