Re: [PATCH 3/3] i2c: uniphier-f: fix race condition when IRQ is cleared
On Tue, Oct 16, 2018 at 12:01:49PM +0900, Masahiro Yamada wrote:
> The current IRQ handler clears all the IRQ status bits when it bails
> out. This is dangerous because it might clear away the status bits
> that have just been set while processing the current handler. If this
> happens, the IRQ event for the latest transfer is lost forever.
>
> The IRQ status bits must be cleared *before* the next transfer is
> kicked.
>
> Fixes: 6a62974b667f ("i2c: uniphier_f: add UniPhier FIFO-builtin I2C driver")
> Signed-off-by: Masahiro Yamada
Applied to for-next, thanks!
signature.asc
Description: PGP signature
Re: [PATCH 3/3] i2c: uniphier-f: fix race condition when IRQ is cleared
On Tue, Oct 16, 2018 at 12:01:49PM +0900, Masahiro Yamada wrote:
> The current IRQ handler clears all the IRQ status bits when it bails
> out. This is dangerous because it might clear away the status bits
> that have just been set while processing the current handler. If this
> happens, the IRQ event for the latest transfer is lost forever.
>
> The IRQ status bits must be cleared *before* the next transfer is
> kicked.
>
> Fixes: 6a62974b667f ("i2c: uniphier_f: add UniPhier FIFO-builtin I2C driver")
> Signed-off-by: Masahiro Yamada
Applied to for-next, thanks!
signature.asc
Description: PGP signature
