Re: [PATCH 3/3] iio: common: ssp_sensors: gyro: constify iio_info structures
On 16/09/16 11:55, Julia Lawall wrote:
> Check for iio_info structures that are only stored in the info field of a
> iio_dev structure. This field is declared const, so iio_info structures
> that have this property can be declared as const also.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct iio_info i@p = { ... };
>
> @ok@
> identifier r.i;
> struct iio_dev e;
> position p;
> @@
> e.info = @p;
>
> @bad@
> position p != {r.p,ok.p};
> identifier r.i;
> struct iio_info e;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
> struct iio_info i = { ... };
> //
>
> The result of size on this file before the change is:
>text data bss dec hexfilename
>1245344 01589 635
>drivers/iio/gyro/ssp_gyro_sensor.o
>
> and after the change it is:
>textdatabssdec hex filename
>1397 192 0 1589 635
>drivers/iio/gyro/ssp_gyro_sensor.o
>
> Signed-off-by: Julia Lawall
Applied to the togreg branch of iio.git. Initially pushed out
as testing for the autobuilders to play with them.
Thanks,
Jonathan
>
> ---
> drivers/iio/gyro/ssp_gyro_sensor.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/gyro/ssp_gyro_sensor.c
> b/drivers/iio/gyro/ssp_gyro_sensor.c
> index 0a8afdd..1f25f40 100644
> --- a/drivers/iio/gyro/ssp_gyro_sensor.c
> +++ b/drivers/iio/gyro/ssp_gyro_sensor.c
> @@ -74,7 +74,7 @@ static int ssp_gyro_write_raw(struct iio_dev *indio_dev,
> return -EINVAL;
> }
>
> -static struct iio_info ssp_gyro_iio_info = {
> +static const struct iio_info ssp_gyro_iio_info = {
> .read_raw = _gyro_read_raw,
> .write_raw = _gyro_write_raw,
> };
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Re: [PATCH 3/3] iio: common: ssp_sensors: gyro: constify iio_info structures
On 16/09/16 11:55, Julia Lawall wrote:
> Check for iio_info structures that are only stored in the info field of a
> iio_dev structure. This field is declared const, so iio_info structures
> that have this property can be declared as const also.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct iio_info i@p = { ... };
>
> @ok@
> identifier r.i;
> struct iio_dev e;
> position p;
> @@
> e.info = @p;
>
> @bad@
> position p != {r.p,ok.p};
> identifier r.i;
> struct iio_info e;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
> struct iio_info i = { ... };
> //
>
> The result of size on this file before the change is:
>text data bss dec hexfilename
>1245344 01589 635
>drivers/iio/gyro/ssp_gyro_sensor.o
>
> and after the change it is:
>textdatabssdec hex filename
>1397 192 0 1589 635
>drivers/iio/gyro/ssp_gyro_sensor.o
>
> Signed-off-by: Julia Lawall
Applied to the togreg branch of iio.git. Initially pushed out
as testing for the autobuilders to play with them.
Thanks,
Jonathan
>
> ---
> drivers/iio/gyro/ssp_gyro_sensor.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/gyro/ssp_gyro_sensor.c
> b/drivers/iio/gyro/ssp_gyro_sensor.c
> index 0a8afdd..1f25f40 100644
> --- a/drivers/iio/gyro/ssp_gyro_sensor.c
> +++ b/drivers/iio/gyro/ssp_gyro_sensor.c
> @@ -74,7 +74,7 @@ static int ssp_gyro_write_raw(struct iio_dev *indio_dev,
> return -EINVAL;
> }
>
> -static struct iio_info ssp_gyro_iio_info = {
> +static const struct iio_info ssp_gyro_iio_info = {
> .read_raw = _gyro_read_raw,
> .write_raw = _gyro_write_raw,
> };
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
