Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

2018-03-13 Thread Jiri Olsa
On Tue, Mar 13, 2018 at 10:12:44AM -0400, Steven Rostedt wrote: > On Tue, 13 Mar 2018 11:14:01 +0100 > Jiri Olsa wrote: > > > > Jiri, If you apply the below, does it fix it for you? > > > > yes, the crash is gone and I can set filter ftrace/function, > > Great! > > > but I'm still having som

Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

2018-03-13 Thread Steven Rostedt
On Tue, 13 Mar 2018 11:14:01 +0100 Jiri Olsa wrote: > > Jiri, If you apply the below, does it fix it for you? > > yes, the crash is gone and I can set filter ftrace/function, Great! > but I'm still having some issues put that filter through perf > > # perf record -e ftrace:function --filt

Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

2018-03-13 Thread Jiri Olsa
On Mon, Mar 12, 2018 at 07:52:45PM -0400, Steven Rostedt wrote: > On Mon, 12 Mar 2018 19:54:14 +0100 > Jiri Olsa wrote: > > > On Mon, Mar 12, 2018 at 02:40:01PM -0400, Steven Rostedt wrote: > > > On Mon, 12 Mar 2018 16:10:17 +0100 > > > Jiri Olsa wrote: > > > > > > > got it crashed when clear

Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

2018-03-12 Thread Steven Rostedt
On Mon, 12 Mar 2018 19:54:14 +0100 Jiri Olsa wrote: > On Mon, Mar 12, 2018 at 02:40:01PM -0400, Steven Rostedt wrote: > > On Mon, 12 Mar 2018 16:10:17 +0100 > > Jiri Olsa wrote: > > > > > got it crashed when clearing the filter via 'echo > filter' > > > > Awesome. I'll go and test this out

Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

2018-03-12 Thread Steven Rostedt
On Mon, 12 Mar 2018 19:54:14 +0100 Jiri Olsa wrote: > On Mon, Mar 12, 2018 at 02:40:01PM -0400, Steven Rostedt wrote: > > On Mon, 12 Mar 2018 16:10:17 +0100 > > Jiri Olsa wrote: > > > > > got it crashed when clearing the filter via 'echo > filter' > > > > Awesome. I'll go and test this out

Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

2018-03-12 Thread Jiri Olsa
On Mon, Mar 12, 2018 at 02:40:01PM -0400, Steven Rostedt wrote: > On Mon, 12 Mar 2018 16:10:17 +0100 > Jiri Olsa wrote: > > > got it crashed when clearing the filter via 'echo > filter' > > Awesome. I'll go and test this out. Thanks! > > Hmm, could you pull my tree and test my branch: ftrace/co

Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

2018-03-12 Thread Steven Rostedt
On Mon, 12 Mar 2018 16:10:17 +0100 Jiri Olsa wrote: > got it crashed when clearing the filter via 'echo > filter' Awesome. I'll go and test this out. Thanks! Hmm, could you pull my tree and test my branch: ftrace/core. I may have already fixed this but haven't posted the latest (which I'll do b

Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

2018-03-12 Thread Steven Rostedt
On Mon, 12 Mar 2018 13:42:46 +0100 Jiri Olsa wrote: > On Fri, Mar 09, 2018 at 09:34:45PM -0500, Steven Rostedt wrote: > > SNIP > > > > > -/* If not of not match is equal to not of not, then it is a match */ > > +/* > > + * Without going into a formal proof, this explains the method that is >

Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

2018-03-12 Thread Jiri Olsa
On Fri, Mar 09, 2018 at 09:34:45PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Al Viro reviewed the filter logic of ftrace trace events and found it to be > very troubling. It creates a binary tree based on the logic operators and > walks it during tracing. He sent myself a

Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

2018-03-12 Thread Jiri Olsa
On Fri, Mar 09, 2018 at 09:34:45PM -0500, Steven Rostedt wrote: SNIP > > -/* If not of not match is equal to not of not, then it is a match */ > +/* > + * Without going into a formal proof, this explains the method that is used > in > + * parsing the logical expressions. > + * > + * For exampl

Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

2018-03-09 Thread Steven Rostedt
On Fri, 9 Mar 2018 22:15:23 -0500 Steven Rostedt wrote: > Sorry for the spam. A little more spam ;-) I know what happened, as I'm able to recreate it. For those that use claws-mail, be careful. I clicked on the email I wanted to reply to. Then I must have hit the down arrow key, as it moved th

Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

2018-03-09 Thread Steven Rostedt
[ This time replying to the email I expected to ] On Fri, 09 Mar 2018 21:34:45 -0500 Steven Rostedt wrote: > 2 files changed, 1050 insertions(+), 1273 deletions(-) BTW, it's a bit bigger impact than 223 deletions. As I added a lot of comments to explain the logic better. Removing comments an

Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

2018-03-09 Thread Steven Rostedt
I don't know what the hell happened, but claws mail just inserted a ton of people into the Cc (I didn't add you). I noticed it just after I hit send. The added Cc looks like it came from the email right after the email I was replying to "Subject: Re: [PATCH v3] kernel.h: Skip single-eval logic on

Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

2018-03-09 Thread Steven Rostedt
On Fri, 09 Mar 2018 21:34:45 -0500 Steven Rostedt wrote: > 2 files changed, 1050 insertions(+), 1273 deletions(-) BTW, it's a bit bigger impact than 223 deletions. As I added a lot of comments to explain the logic better. Removing comments and white space from the modifications we have: 649 i