Re: [PATCH 3/4] tmp: factor out tpm1_get_random into tpm1-cmd.c
On Tue, Mar 06, 2018 at 11:34:50AM +, Winkler, Tomas wrote: > > > > > On Tue, 2018-03-06 at 11:30 +0200, Tomas Winkler wrote: > > > Factor out get random implementation from tpm-interface.c into > > > tpm1_get_random function in tpm1-cmd.c. > > > No functional changes. > > > > > > Signed-off-by: Tomas Winkler > > > > While you are doing this, please make it use tpm_buf so tha we get stuff out > > of that nasty union. Using "helper" structs is still fine, just move it > > right > > before the function implementation out of tpm.h (there are examples of this > > tpm2-cmd.c). > > Sure, but not while moving code, this is dangerous. Should be done after code > is moved. Makes sense have use two steps here. /Jarkko
RE: [PATCH 3/4] tmp: factor out tpm1_get_random into tpm1-cmd.c
> > On Tue, 2018-03-06 at 11:30 +0200, Tomas Winkler wrote: > > Factor out get random implementation from tpm-interface.c into > > tpm1_get_random function in tpm1-cmd.c. > > No functional changes. > > > > Signed-off-by: Tomas Winkler > > While you are doing this, please make it use tpm_buf so tha we get stuff out > of that nasty union. Using "helper" structs is still fine, just move it right > before the function implementation out of tpm.h (there are examples of this > tpm2-cmd.c). Sure, but not while moving code, this is dangerous. Should be done after code is moved. Thanks Tomas
Re: [PATCH 3/4] tmp: factor out tpm1_get_random into tpm1-cmd.c
On Tue, 2018-03-06 at 11:30 +0200, Tomas Winkler wrote: > Factor out get random implementation from tpm-interface.c > into tpm1_get_random function in tpm1-cmd.c. > No functional changes. > > Signed-off-by: Tomas Winkler While you are doing this, please make it use tpm_buf so tha we get stuff out of that nasty union. Using "helper" structs is still fine, just move it right before the function implementation out of tpm.h (there are examples of this tpm2-cmd.c). /Jarkko
