Re: [PATCH 3/4] tracing: Add action comparisons when testing matching hist triggers

2018-04-12 Thread Tom Zanussi
Hi Masami, Sorry for the delay in replying - was off for a few days.. On Sat, 2018-04-07 at 21:16 +0900, Masami Hiramatsu wrote: > On Fri, 06 Apr 2018 11:47:29 -0500 > Tom Zanussi wrote: > > > > > > Can you print out the error with which event we should see? e.g. > > > > > > > > > > ERROR: V

Re: [PATCH 3/4] tracing: Add action comparisons when testing matching hist triggers

2018-04-07 Thread Masami Hiramatsu
On Fri, 06 Apr 2018 11:47:29 -0500 Tom Zanussi wrote: > > > > Can you print out the error with which event we should see? e.g. > > > > > > > > ERROR: Variable already defined at sched_wakeup: ts0 > > > > > > > > > > How about printing the event name along with the last command, for any > > >

Re: [PATCH 3/4] tracing: Add action comparisons when testing matching hist triggers

2018-04-06 Thread Tom Zanussi
Hi Masami, On Fri, 2018-04-06 at 10:53 +0900, Masami Hiramatsu wrote: > Hi Tom, > > On Thu, 05 Apr 2018 18:34:13 -0500 > Tom Zanussi wrote: > > > Hi Masami, > > > > On Thu, 2018-04-05 at 12:50 +0900, Masami Hiramatsu wrote: > > > > [...] > > > > > Can you print out the error with which event

Re: [PATCH 3/4] tracing: Add action comparisons when testing matching hist triggers

2018-04-05 Thread Masami Hiramatsu
Hi Tom, On Thu, 05 Apr 2018 18:34:13 -0500 Tom Zanussi wrote: > Hi Masami, > > On Thu, 2018-04-05 at 12:50 +0900, Masami Hiramatsu wrote: > > [...] > > > Can you print out the error with which event we should see? e.g. > > > > ERROR: Variable already defined at sched_wakeup: ts0 > > > >

Re: [PATCH 3/4] tracing: Add action comparisons when testing matching hist triggers

2018-04-05 Thread Tom Zanussi
Hi Masami, On Thu, 2018-04-05 at 12:50 +0900, Masami Hiramatsu wrote: [...] > Can you print out the error with which event we should see? e.g. > > ERROR: Variable already defined at sched_wakeup: ts0 > How about printing the event name along with the last command, for any error? : ERROR:

Re: [PATCH 3/4] tracing: Add action comparisons when testing matching hist triggers

2018-04-04 Thread Masami Hiramatsu
On Wed, 04 Apr 2018 10:17:03 -0500 Tom Zanussi wrote: > Hi Masami, > > On Wed, 2018-04-04 at 21:33 +0900, Masami Hiramatsu wrote: > > Hi Tom, > > > > On Mon, 02 Apr 2018 12:09:33 -0500 > > Tom Zanussi wrote: > > > > > after: > > > > > > # echo 'wakeup_latency u64 lat; pid_t pid' >> > > >

Re: [PATCH 3/4] tracing: Add action comparisons when testing matching hist triggers

2018-04-04 Thread Tom Zanussi
Hi Masami, On Wed, 2018-04-04 at 21:33 +0900, Masami Hiramatsu wrote: > Hi Tom, > > On Mon, 02 Apr 2018 12:09:33 -0500 > Tom Zanussi wrote: > > > after: > > > > # echo 'wakeup_latency u64 lat; pid_t pid' >> > > /sys/kernel/debug/tracing/synthetic_events > > # echo 'hist:keys=pid:ts0=commo

Re: [PATCH 3/4] tracing: Add action comparisons when testing matching hist triggers

2018-04-04 Thread Steven Rostedt
On Wed, 4 Apr 2018 21:33:38 +0900 Masami Hiramatsu wrote: > Hmm, how can I undef ts0 and test it again? > If I can not clean it, the testcase must fail on the 2nd time. Tom, I already pulled in your patches and almost completed my tests (which obviously are not stress testing this code). Any f

Re: [PATCH 3/4] tracing: Add action comparisons when testing matching hist triggers

2018-04-04 Thread Masami Hiramatsu
Hi Tom, On Mon, 02 Apr 2018 12:09:33 -0500 Tom Zanussi wrote: > after: > > # echo 'wakeup_latency u64 lat; pid_t pid' >> > /sys/kernel/debug/tracing/synthetic_events > # echo 'hist:keys=pid:ts0=common_timestamp.usecs if comm=="cyclictest"' >> > /sys/kernel/debug/tracing/events/sched/sched

Re: [PATCH 3/4] tracing: Add action comparisons when testing matching hist triggers

2018-04-02 Thread Tom Zanussi
Hi Masami, On Tue, 2018-04-03 at 00:10 +0900, Masami Hiramatsu wrote: > On Wed, 28 Mar 2018 15:10:55 -0500 > Tom Zanussi wrote: > > > Actions also need to be considered when checking for matching triggers > > - triggers differing only by action should be allowed, but currently > > aren't because

Re: [PATCH 3/4] tracing: Add action comparisons when testing matching hist triggers

2018-04-02 Thread Masami Hiramatsu
On Wed, 28 Mar 2018 15:10:55 -0500 Tom Zanussi wrote: > Actions also need to be considered when checking for matching triggers > - triggers differing only by action should be allowed, but currently > aren't because the matching check ignores the action and erroneously > returns -EEXIST. Hi Tom,