Re: [PATCH 3/7] drm: Update drm_addmap and drm_mmap to use PAT WC instead of MTRRs

2013-05-07 Thread Andy Lutomirski
On Tue, May 7, 2013 at 7:08 AM, Alex Deucher wrote: > On Mon, May 6, 2013 at 7:39 PM, Andy Lutomirski wrote: >> On Mon, May 6, 2013 at 4:04 PM, Jerome Glisse wrote: >>> On Mon, May 6, 2013 at 5:22 PM, Andy Lutomirski wrote: On Fri, May 3, 2013 at 4:00 PM, Andy Lutomirski wrote:

Re: [PATCH 3/7] drm: Update drm_addmap and drm_mmap to use PAT WC instead of MTRRs

2013-05-07 Thread Alex Deucher
On Mon, May 6, 2013 at 7:39 PM, Andy Lutomirski wrote: > On Mon, May 6, 2013 at 4:04 PM, Jerome Glisse wrote: >> On Mon, May 6, 2013 at 5:22 PM, Andy Lutomirski wrote: >>> On Fri, May 3, 2013 at 4:00 PM, Andy Lutomirski wrote: Signed-off-by: Andy Lutomirski --- This needs

Re: [PATCH 3/7] drm: Update drm_addmap and drm_mmap to use PAT WC instead of MTRRs

2013-05-07 Thread Alex Deucher
On Mon, May 6, 2013 at 7:39 PM, Andy Lutomirski l...@amacapital.net wrote: On Mon, May 6, 2013 at 4:04 PM, Jerome Glisse j.gli...@gmail.com wrote: On Mon, May 6, 2013 at 5:22 PM, Andy Lutomirski l...@amacapital.net wrote: On Fri, May 3, 2013 at 4:00 PM, Andy Lutomirski l...@amacapital.net

Re: [PATCH 3/7] drm: Update drm_addmap and drm_mmap to use PAT WC instead of MTRRs

2013-05-07 Thread Andy Lutomirski
On Tue, May 7, 2013 at 7:08 AM, Alex Deucher alexdeuc...@gmail.com wrote: On Mon, May 6, 2013 at 7:39 PM, Andy Lutomirski l...@amacapital.net wrote: On Mon, May 6, 2013 at 4:04 PM, Jerome Glisse j.gli...@gmail.com wrote: On Mon, May 6, 2013 at 5:22 PM, Andy Lutomirski l...@amacapital.net wrote:

Re: [PATCH 3/7] drm: Update drm_addmap and drm_mmap to use PAT WC instead of MTRRs

2013-05-06 Thread Dave Airlie
>> >> From memory, even on pat system we need mtrr for VRAM is PCI BAR. We >> cover it with a write combine MTRR. The whole ioctl is use by some ddx >> or maybe even directly the XServer to do this mtrr mess in userspace. > > Egads! So we have a _DRM_WRITE_COMBINING flag, which will continue to >

Re: [PATCH 3/7] drm: Update drm_addmap and drm_mmap to use PAT WC instead of MTRRs

2013-05-06 Thread Andy Lutomirski
On Mon, May 6, 2013 at 4:04 PM, Jerome Glisse wrote: > On Mon, May 6, 2013 at 5:22 PM, Andy Lutomirski wrote: >> On Fri, May 3, 2013 at 4:00 PM, Andy Lutomirski wrote: >>> Signed-off-by: Andy Lutomirski >>> --- >>> >>> This needs careful review. I don't really know what this code does, nor

Re: [PATCH 3/7] drm: Update drm_addmap and drm_mmap to use PAT WC instead of MTRRs

2013-05-06 Thread Jerome Glisse
On Mon, May 6, 2013 at 5:22 PM, Andy Lutomirski wrote: > On Fri, May 3, 2013 at 4:00 PM, Andy Lutomirski wrote: >> Signed-off-by: Andy Lutomirski >> --- >> >> This needs careful review. I don't really know what this code does, nor >> do I have the hardware. (I don't understand AGP and the

Re: [PATCH 3/7] drm: Update drm_addmap and drm_mmap to use PAT WC instead of MTRRs

2013-05-06 Thread Andy Lutomirski
On Fri, May 3, 2013 at 4:00 PM, Andy Lutomirski wrote: > Signed-off-by: Andy Lutomirski > --- > > This needs careful review. I don't really know what this code does, nor > do I have the hardware. (I don't understand AGP and the associated > caching implications.) This patch is wrong (I didn't

Re: [PATCH 3/7] drm: Update drm_addmap and drm_mmap to use PAT WC instead of MTRRs

2013-05-06 Thread Andy Lutomirski
On Fri, May 3, 2013 at 4:00 PM, Andy Lutomirski l...@amacapital.net wrote: Signed-off-by: Andy Lutomirski l...@amacapital.net --- This needs careful review. I don't really know what this code does, nor do I have the hardware. (I don't understand AGP and the associated caching

Re: [PATCH 3/7] drm: Update drm_addmap and drm_mmap to use PAT WC instead of MTRRs

2013-05-06 Thread Jerome Glisse
On Mon, May 6, 2013 at 5:22 PM, Andy Lutomirski l...@amacapital.net wrote: On Fri, May 3, 2013 at 4:00 PM, Andy Lutomirski l...@amacapital.net wrote: Signed-off-by: Andy Lutomirski l...@amacapital.net --- This needs careful review. I don't really know what this code does, nor do I have the