Re: [PATCH 3/8] NTB: Fix the default port and peer numbers for legacy drivers

2018-06-15 Thread Logan Gunthorpe
On 15/06/18 01:48 PM, Serge Semin wrote: > Concerning the fix of the discovered issues and fixes introduced by this > patchset. I'd suggest to add the ports-index callbacks to the Switchtec > driver, which identify local and peer ports. After this the current version > of all the test drivers

Re: [PATCH 3/8] NTB: Fix the default port and peer numbers for legacy drivers

2018-06-15 Thread Logan Gunthorpe
On 15/06/18 01:48 PM, Serge Semin wrote: > Concerning the fix of the discovered issues and fixes introduced by this > patchset. I'd suggest to add the ports-index callbacks to the Switchtec > driver, which identify local and peer ports. After this the current version > of all the test drivers

Re: [PATCH 3/8] NTB: Fix the default port and peer numbers for legacy drivers

2018-06-15 Thread Serge Semin
On Fri, Jun 08, 2018 at 06:08:13PM -0600, Logan Gunthorpe wrote: > When the commit adding ntb_default_port_number() and > ntb_default_peer_port_number() entered the kernel there was no > users of it so it was impossible to tell what the API needed. > > When a user finally landed a year later

Re: [PATCH 3/8] NTB: Fix the default port and peer numbers for legacy drivers

2018-06-15 Thread Serge Semin
On Fri, Jun 08, 2018 at 06:08:13PM -0600, Logan Gunthorpe wrote: > When the commit adding ntb_default_port_number() and > ntb_default_peer_port_number() entered the kernel there was no > users of it so it was impossible to tell what the API needed. > > When a user finally landed a year later

Re: [PATCH 3/8] NTB: Fix the default port and peer numbers for legacy drivers

2018-06-12 Thread Logan Gunthorpe
On 12/06/18 09:59 AM, Jon Mason wrote: >> Patches for ntb_pingpong and ntb_perf follow (which are broken >> otherwise) to support hardware that doesn't have port numbers. This is >> important not only to not break support with existing drivers but for >> the cross link topology which, due to

Re: [PATCH 3/8] NTB: Fix the default port and peer numbers for legacy drivers

2018-06-12 Thread Logan Gunthorpe
On 12/06/18 09:59 AM, Jon Mason wrote: >> Patches for ntb_pingpong and ntb_perf follow (which are broken >> otherwise) to support hardware that doesn't have port numbers. This is >> important not only to not break support with existing drivers but for >> the cross link topology which, due to

Re: [PATCH 3/8] NTB: Fix the default port and peer numbers for legacy drivers

2018-06-12 Thread Jon Mason
On Fri, Jun 8, 2018 at 8:08 PM, Logan Gunthorpe wrote: > When the commit adding ntb_default_port_number() and > ntb_default_peer_port_number() entered the kernel there was no > users of it so it was impossible to tell what the API needed. > > When a user finally landed a year later

Re: [PATCH 3/8] NTB: Fix the default port and peer numbers for legacy drivers

2018-06-12 Thread Jon Mason
On Fri, Jun 8, 2018 at 8:08 PM, Logan Gunthorpe wrote: > When the commit adding ntb_default_port_number() and > ntb_default_peer_port_number() entered the kernel there was no > users of it so it was impossible to tell what the API needed. > > When a user finally landed a year later