Re: [PATCH 3/9] x86/entry/32: fix the end of the stack for newly forked tasks

2016-09-21 Thread Josh Poimboeuf
On Tue, Sep 20, 2016 at 11:39:35PM -0700, Andy Lutomirski wrote: > > And the ia64 entry code has some similar language: > > > > /* > > * Invoke schedule_tail(task) while preserving in0-in7, > > which may be needed > > * in case a system call gets r

Re: [PATCH 3/9] x86/entry/32: fix the end of the stack for newly forked tasks

2016-09-20 Thread Andy Lutomirski
On Sep 20, 2016 5:25 PM, "Josh Poimboeuf" wrote: > > On Tue, Sep 20, 2016 at 09:10:55PM -0400, Brian Gerst wrote: > > Dropping asmlinkage from schedule_tail() would be a better option if > > possible. > > My understanding is that it's still needed for ia64. AFAICT, ia64 > relies on schedule_tail

Re: [PATCH 3/9] x86/entry/32: fix the end of the stack for newly forked tasks

2016-09-20 Thread Josh Poimboeuf
On Tue, Sep 20, 2016 at 10:25:16PM -0500, Josh Poimboeuf wrote: > On Tue, Sep 20, 2016 at 09:10:55PM -0400, Brian Gerst wrote: > > Dropping asmlinkage from schedule_tail() would be a better option if > > possible. > > My understanding is that it's still needed for ia64. AFAICT, ia64 > relies on

Re: [PATCH 3/9] x86/entry/32: fix the end of the stack for newly forked tasks

2016-09-20 Thread Josh Poimboeuf
On Tue, Sep 20, 2016 at 09:10:55PM -0400, Brian Gerst wrote: > Dropping asmlinkage from schedule_tail() would be a better option if possible. My understanding is that it's still needed for ia64. AFAICT, ia64 relies on schedule_tail() having the syscall_linkage function attribute. >From the gcc ma

Re: [PATCH 3/9] x86/entry/32: fix the end of the stack for newly forked tasks

2016-09-20 Thread Brian Gerst
On Tue, Sep 20, 2016 at 4:02 PM, Josh Poimboeuf wrote: > Thanks to all the recent x86 entry code refactoring, most tasks' kernel > stacks start at the same offset right below their saved pt_regs, > regardless of which syscall was used to enter the kernel. That creates > a nice convention which ma