Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
On Sun, Dec 02, 2018 at 09:11:50PM +0100, Greg Kroah-Hartman wrote:
On Sun, Dec 02, 2018 at 11:25:32AM -0500, Sasha Levin wrote:
On Sun, Dec 02, 2018 at 05:15:35PM +0100, Greg Kroah-Hartman wrote:
> On Sun, Dec 02, 2018 at 10:17:32AM -0500, Sasha Levin wrote:
> > On Fri, Nov 30, 2018 at 04:18:43PM +0100, Greg Kroah-Hartman wrote:
> > > On Fri, Nov 30, 2018 at 04:15:54PM +0100, Greg Kroah-Hartman wrote:
> > > > On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux
wrote:
> > > > > Hi,
> > > > >
> > > > > As I've already fed back to Sascha about this, this patch on its own
> > > > > does not fix anything, and is not a stable kernel candidate without
> > > > > a patch that makes use of it (iow, the spectre fixes.) It is a
> > > > > preparatory patch for mainline commit 383fb3ee8024.
> > > > >
> > > > > Every commit in:
> > > > >
> > > > > $ git rev-list v4.16..383fb3ee8024
> > > > >
> > > > > are the ARM spectre fixes, which are being back-ported by David Long.
> > > > >
> > > > > Please do not cherry-pick commits from within this series for _any_
> > > > > stable kernel, but please wait for David to send you the back-ported
> > > > > patches.
> > > >
> > > > Ugh, ok, that's a bunch here.
> > >
> > > Ok, not that bad, only 4:
> > > 383fb3ee8024 ("ARM: spectre-v2: per-CPU vtables to work around big.Little
systems")
> > > e209950fdd06 ("ARM: add PROC_VTABLE and PROC_TABLE macros")
> > > 945aceb1db88 ("ARM: clean up per-processor check_bugs method call")
> > > 899a42f83667 ("ARM: make lookup_processor_type() non-__init")
> > >
> > > I'll go drop them all from the trees now. Turns out for 4.14 one of
> > > these patches broke the build anyway. Sasha, how did that past your
> > > builder tests?
> >
> > Because it builds :)
>
> Really? It broke Guenter's builds...
I might be missing something, but Guenter's reply to this -rc thread
(https://www.spinics.net/lists/stable/msg272294.html) was:
> For v3.18.127-83-gc3953c334bf6:
>
> Build results:
>total: 160 pass: 160 fail: 0
> Qemu test results:
>total: 223 pass: 223 fail: 0
The breakage happened on the 4.14 tree with one of the patches above,
which caused me to do a -rc2.
Oh, I see :(
I suspect that I have a bug somewhere in my scripts that deal with
removing patches from the middle of git branches, I'll try a few
testcases tomorrow.
--
Thanks,
Sasha
Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
On Sun, Dec 02, 2018 at 09:11:50PM +0100, Greg Kroah-Hartman wrote:
On Sun, Dec 02, 2018 at 11:25:32AM -0500, Sasha Levin wrote:
On Sun, Dec 02, 2018 at 05:15:35PM +0100, Greg Kroah-Hartman wrote:
> On Sun, Dec 02, 2018 at 10:17:32AM -0500, Sasha Levin wrote:
> > On Fri, Nov 30, 2018 at 04:18:43PM +0100, Greg Kroah-Hartman wrote:
> > > On Fri, Nov 30, 2018 at 04:15:54PM +0100, Greg Kroah-Hartman wrote:
> > > > On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux
wrote:
> > > > > Hi,
> > > > >
> > > > > As I've already fed back to Sascha about this, this patch on its own
> > > > > does not fix anything, and is not a stable kernel candidate without
> > > > > a patch that makes use of it (iow, the spectre fixes.) It is a
> > > > > preparatory patch for mainline commit 383fb3ee8024.
> > > > >
> > > > > Every commit in:
> > > > >
> > > > > $ git rev-list v4.16..383fb3ee8024
> > > > >
> > > > > are the ARM spectre fixes, which are being back-ported by David Long.
> > > > >
> > > > > Please do not cherry-pick commits from within this series for _any_
> > > > > stable kernel, but please wait for David to send you the back-ported
> > > > > patches.
> > > >
> > > > Ugh, ok, that's a bunch here.
> > >
> > > Ok, not that bad, only 4:
> > > 383fb3ee8024 ("ARM: spectre-v2: per-CPU vtables to work around big.Little
systems")
> > > e209950fdd06 ("ARM: add PROC_VTABLE and PROC_TABLE macros")
> > > 945aceb1db88 ("ARM: clean up per-processor check_bugs method call")
> > > 899a42f83667 ("ARM: make lookup_processor_type() non-__init")
> > >
> > > I'll go drop them all from the trees now. Turns out for 4.14 one of
> > > these patches broke the build anyway. Sasha, how did that past your
> > > builder tests?
> >
> > Because it builds :)
>
> Really? It broke Guenter's builds...
I might be missing something, but Guenter's reply to this -rc thread
(https://www.spinics.net/lists/stable/msg272294.html) was:
> For v3.18.127-83-gc3953c334bf6:
>
> Build results:
>total: 160 pass: 160 fail: 0
> Qemu test results:
>total: 223 pass: 223 fail: 0
The breakage happened on the 4.14 tree with one of the patches above,
which caused me to do a -rc2.
Oh, I see :(
I suspect that I have a bug somewhere in my scripts that deal with
removing patches from the middle of git branches, I'll try a few
testcases tomorrow.
--
Thanks,
Sasha
Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
On Sun, Dec 02, 2018 at 11:25:32AM -0500, Sasha Levin wrote:
> On Sun, Dec 02, 2018 at 05:15:35PM +0100, Greg Kroah-Hartman wrote:
> > On Sun, Dec 02, 2018 at 10:17:32AM -0500, Sasha Levin wrote:
> > > On Fri, Nov 30, 2018 at 04:18:43PM +0100, Greg Kroah-Hartman wrote:
> > > > On Fri, Nov 30, 2018 at 04:15:54PM +0100, Greg Kroah-Hartman wrote:
> > > > > On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux
> > > > > wrote:
> > > > > > Hi,
> > > > > >
> > > > > > As I've already fed back to Sascha about this, this patch on its own
> > > > > > does not fix anything, and is not a stable kernel candidate without
> > > > > > a patch that makes use of it (iow, the spectre fixes.) It is a
> > > > > > preparatory patch for mainline commit 383fb3ee8024.
> > > > > >
> > > > > > Every commit in:
> > > > > >
> > > > > > $ git rev-list v4.16..383fb3ee8024
> > > > > >
> > > > > > are the ARM spectre fixes, which are being back-ported by David
> > > > > > Long.
> > > > > >
> > > > > > Please do not cherry-pick commits from within this series for _any_
> > > > > > stable kernel, but please wait for David to send you the back-ported
> > > > > > patches.
> > > > >
> > > > > Ugh, ok, that's a bunch here.
> > > >
> > > > Ok, not that bad, only 4:
> > > > 383fb3ee8024 ("ARM: spectre-v2: per-CPU vtables to work around
> > > > big.Little systems")
> > > > e209950fdd06 ("ARM: add PROC_VTABLE and PROC_TABLE macros")
> > > > 945aceb1db88 ("ARM: clean up per-processor check_bugs method
> > > > call")
> > > > 899a42f83667 ("ARM: make lookup_processor_type() non-__init")
> > > >
> > > > I'll go drop them all from the trees now. Turns out for 4.14 one of
> > > > these patches broke the build anyway. Sasha, how did that past your
> > > > builder tests?
> > >
> > > Because it builds :)
> >
> > Really? It broke Guenter's builds...
>
> I might be missing something, but Guenter's reply to this -rc thread
> (https://www.spinics.net/lists/stable/msg272294.html) was:
>
> > For v3.18.127-83-gc3953c334bf6:
> >
> > Build results:
> > total: 160 pass: 160 fail: 0
> > Qemu test results:
> > total: 223 pass: 223 fail: 0
The breakage happened on the 4.14 tree with one of the patches above,
which caused me to do a -rc2.
thanks,
greg k-h
Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
On Sun, Dec 02, 2018 at 11:25:32AM -0500, Sasha Levin wrote:
> On Sun, Dec 02, 2018 at 05:15:35PM +0100, Greg Kroah-Hartman wrote:
> > On Sun, Dec 02, 2018 at 10:17:32AM -0500, Sasha Levin wrote:
> > > On Fri, Nov 30, 2018 at 04:18:43PM +0100, Greg Kroah-Hartman wrote:
> > > > On Fri, Nov 30, 2018 at 04:15:54PM +0100, Greg Kroah-Hartman wrote:
> > > > > On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux
> > > > > wrote:
> > > > > > Hi,
> > > > > >
> > > > > > As I've already fed back to Sascha about this, this patch on its own
> > > > > > does not fix anything, and is not a stable kernel candidate without
> > > > > > a patch that makes use of it (iow, the spectre fixes.) It is a
> > > > > > preparatory patch for mainline commit 383fb3ee8024.
> > > > > >
> > > > > > Every commit in:
> > > > > >
> > > > > > $ git rev-list v4.16..383fb3ee8024
> > > > > >
> > > > > > are the ARM spectre fixes, which are being back-ported by David
> > > > > > Long.
> > > > > >
> > > > > > Please do not cherry-pick commits from within this series for _any_
> > > > > > stable kernel, but please wait for David to send you the back-ported
> > > > > > patches.
> > > > >
> > > > > Ugh, ok, that's a bunch here.
> > > >
> > > > Ok, not that bad, only 4:
> > > > 383fb3ee8024 ("ARM: spectre-v2: per-CPU vtables to work around
> > > > big.Little systems")
> > > > e209950fdd06 ("ARM: add PROC_VTABLE and PROC_TABLE macros")
> > > > 945aceb1db88 ("ARM: clean up per-processor check_bugs method
> > > > call")
> > > > 899a42f83667 ("ARM: make lookup_processor_type() non-__init")
> > > >
> > > > I'll go drop them all from the trees now. Turns out for 4.14 one of
> > > > these patches broke the build anyway. Sasha, how did that past your
> > > > builder tests?
> > >
> > > Because it builds :)
> >
> > Really? It broke Guenter's builds...
>
> I might be missing something, but Guenter's reply to this -rc thread
> (https://www.spinics.net/lists/stable/msg272294.html) was:
>
> > For v3.18.127-83-gc3953c334bf6:
> >
> > Build results:
> > total: 160 pass: 160 fail: 0
> > Qemu test results:
> > total: 223 pass: 223 fail: 0
The breakage happened on the 4.14 tree with one of the patches above,
which caused me to do a -rc2.
thanks,
greg k-h
Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
On Sun, Dec 02, 2018 at 05:15:35PM +0100, Greg Kroah-Hartman wrote:
On Sun, Dec 02, 2018 at 10:17:32AM -0500, Sasha Levin wrote:
On Fri, Nov 30, 2018 at 04:18:43PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Nov 30, 2018 at 04:15:54PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux wrote:
> > > Hi,
> > >
> > > As I've already fed back to Sascha about this, this patch on its own
> > > does not fix anything, and is not a stable kernel candidate without
> > > a patch that makes use of it (iow, the spectre fixes.) It is a
> > > preparatory patch for mainline commit 383fb3ee8024.
> > >
> > > Every commit in:
> > >
> > > $ git rev-list v4.16..383fb3ee8024
> > >
> > > are the ARM spectre fixes, which are being back-ported by David Long.
> > >
> > > Please do not cherry-pick commits from within this series for _any_
> > > stable kernel, but please wait for David to send you the back-ported
> > > patches.
> >
> > Ugh, ok, that's a bunch here.
>
> Ok, not that bad, only 4:
>383fb3ee8024 ("ARM: spectre-v2: per-CPU vtables to work around big.Little
systems")
>e209950fdd06 ("ARM: add PROC_VTABLE and PROC_TABLE macros")
>945aceb1db88 ("ARM: clean up per-processor check_bugs method call")
>899a42f83667 ("ARM: make lookup_processor_type() non-__init")
>
> I'll go drop them all from the trees now. Turns out for 4.14 one of
> these patches broke the build anyway. Sasha, how did that past your
> builder tests?
Because it builds :)
Really? It broke Guenter's builds...
I might be missing something, but Guenter's reply to this -rc thread
(https://www.spinics.net/lists/stable/msg272294.html) was:
For v3.18.127-83-gc3953c334bf6:
Build results:
total: 160 pass: 160 fail: 0
Qemu test results:
total: 223 pass: 223 fail: 0
--
Thanks,
Sasha
Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
On Sun, Dec 02, 2018 at 05:15:35PM +0100, Greg Kroah-Hartman wrote:
On Sun, Dec 02, 2018 at 10:17:32AM -0500, Sasha Levin wrote:
On Fri, Nov 30, 2018 at 04:18:43PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Nov 30, 2018 at 04:15:54PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux wrote:
> > > Hi,
> > >
> > > As I've already fed back to Sascha about this, this patch on its own
> > > does not fix anything, and is not a stable kernel candidate without
> > > a patch that makes use of it (iow, the spectre fixes.) It is a
> > > preparatory patch for mainline commit 383fb3ee8024.
> > >
> > > Every commit in:
> > >
> > > $ git rev-list v4.16..383fb3ee8024
> > >
> > > are the ARM spectre fixes, which are being back-ported by David Long.
> > >
> > > Please do not cherry-pick commits from within this series for _any_
> > > stable kernel, but please wait for David to send you the back-ported
> > > patches.
> >
> > Ugh, ok, that's a bunch here.
>
> Ok, not that bad, only 4:
>383fb3ee8024 ("ARM: spectre-v2: per-CPU vtables to work around big.Little
systems")
>e209950fdd06 ("ARM: add PROC_VTABLE and PROC_TABLE macros")
>945aceb1db88 ("ARM: clean up per-processor check_bugs method call")
>899a42f83667 ("ARM: make lookup_processor_type() non-__init")
>
> I'll go drop them all from the trees now. Turns out for 4.14 one of
> these patches broke the build anyway. Sasha, how did that past your
> builder tests?
Because it builds :)
Really? It broke Guenter's builds...
I might be missing something, but Guenter's reply to this -rc thread
(https://www.spinics.net/lists/stable/msg272294.html) was:
For v3.18.127-83-gc3953c334bf6:
Build results:
total: 160 pass: 160 fail: 0
Qemu test results:
total: 223 pass: 223 fail: 0
--
Thanks,
Sasha
Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
On Sun, Dec 02, 2018 at 10:17:32AM -0500, Sasha Levin wrote:
> On Fri, Nov 30, 2018 at 04:18:43PM +0100, Greg Kroah-Hartman wrote:
> > On Fri, Nov 30, 2018 at 04:15:54PM +0100, Greg Kroah-Hartman wrote:
> > > On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux wrote:
> > > > Hi,
> > > >
> > > > As I've already fed back to Sascha about this, this patch on its own
> > > > does not fix anything, and is not a stable kernel candidate without
> > > > a patch that makes use of it (iow, the spectre fixes.) It is a
> > > > preparatory patch for mainline commit 383fb3ee8024.
> > > >
> > > > Every commit in:
> > > >
> > > > $ git rev-list v4.16..383fb3ee8024
> > > >
> > > > are the ARM spectre fixes, which are being back-ported by David Long.
> > > >
> > > > Please do not cherry-pick commits from within this series for _any_
> > > > stable kernel, but please wait for David to send you the back-ported
> > > > patches.
> > >
> > > Ugh, ok, that's a bunch here.
> >
> > Ok, not that bad, only 4:
> > 383fb3ee8024 ("ARM: spectre-v2: per-CPU vtables to work around
> > big.Little systems")
> > e209950fdd06 ("ARM: add PROC_VTABLE and PROC_TABLE macros")
> > 945aceb1db88 ("ARM: clean up per-processor check_bugs method call")
> > 899a42f83667 ("ARM: make lookup_processor_type() non-__init")
> >
> > I'll go drop them all from the trees now. Turns out for 4.14 one of
> > these patches broke the build anyway. Sasha, how did that past your
> > builder tests?
>
> Because it builds :)
Really? It broke Guenter's builds...
Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
On Sun, Dec 02, 2018 at 10:17:32AM -0500, Sasha Levin wrote:
> On Fri, Nov 30, 2018 at 04:18:43PM +0100, Greg Kroah-Hartman wrote:
> > On Fri, Nov 30, 2018 at 04:15:54PM +0100, Greg Kroah-Hartman wrote:
> > > On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux wrote:
> > > > Hi,
> > > >
> > > > As I've already fed back to Sascha about this, this patch on its own
> > > > does not fix anything, and is not a stable kernel candidate without
> > > > a patch that makes use of it (iow, the spectre fixes.) It is a
> > > > preparatory patch for mainline commit 383fb3ee8024.
> > > >
> > > > Every commit in:
> > > >
> > > > $ git rev-list v4.16..383fb3ee8024
> > > >
> > > > are the ARM spectre fixes, which are being back-ported by David Long.
> > > >
> > > > Please do not cherry-pick commits from within this series for _any_
> > > > stable kernel, but please wait for David to send you the back-ported
> > > > patches.
> > >
> > > Ugh, ok, that's a bunch here.
> >
> > Ok, not that bad, only 4:
> > 383fb3ee8024 ("ARM: spectre-v2: per-CPU vtables to work around
> > big.Little systems")
> > e209950fdd06 ("ARM: add PROC_VTABLE and PROC_TABLE macros")
> > 945aceb1db88 ("ARM: clean up per-processor check_bugs method call")
> > 899a42f83667 ("ARM: make lookup_processor_type() non-__init")
> >
> > I'll go drop them all from the trees now. Turns out for 4.14 one of
> > these patches broke the build anyway. Sasha, how did that past your
> > builder tests?
>
> Because it builds :)
Really? It broke Guenter's builds...
Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
On Fri, Nov 30, 2018 at 04:18:43PM +0100, Greg Kroah-Hartman wrote:
On Fri, Nov 30, 2018 at 04:15:54PM +0100, Greg Kroah-Hartman wrote:
On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux wrote:
> Hi,
>
> As I've already fed back to Sascha about this, this patch on its own
> does not fix anything, and is not a stable kernel candidate without
> a patch that makes use of it (iow, the spectre fixes.) It is a
> preparatory patch for mainline commit 383fb3ee8024.
>
> Every commit in:
>
> $ git rev-list v4.16..383fb3ee8024
>
> are the ARM spectre fixes, which are being back-ported by David Long.
>
> Please do not cherry-pick commits from within this series for _any_
> stable kernel, but please wait for David to send you the back-ported
> patches.
Ugh, ok, that's a bunch here.
Ok, not that bad, only 4:
383fb3ee8024 ("ARM: spectre-v2: per-CPU vtables to work around big.Little
systems")
e209950fdd06 ("ARM: add PROC_VTABLE and PROC_TABLE macros")
945aceb1db88 ("ARM: clean up per-processor check_bugs method call")
899a42f83667 ("ARM: make lookup_processor_type() non-__init")
I'll go drop them all from the trees now. Turns out for 4.14 one of
these patches broke the build anyway. Sasha, how did that past your
builder tests?
Because it builds :)
--
Thanks,
Sasha
Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
On Fri, Nov 30, 2018 at 04:18:43PM +0100, Greg Kroah-Hartman wrote:
On Fri, Nov 30, 2018 at 04:15:54PM +0100, Greg Kroah-Hartman wrote:
On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux wrote:
> Hi,
>
> As I've already fed back to Sascha about this, this patch on its own
> does not fix anything, and is not a stable kernel candidate without
> a patch that makes use of it (iow, the spectre fixes.) It is a
> preparatory patch for mainline commit 383fb3ee8024.
>
> Every commit in:
>
> $ git rev-list v4.16..383fb3ee8024
>
> are the ARM spectre fixes, which are being back-ported by David Long.
>
> Please do not cherry-pick commits from within this series for _any_
> stable kernel, but please wait for David to send you the back-ported
> patches.
Ugh, ok, that's a bunch here.
Ok, not that bad, only 4:
383fb3ee8024 ("ARM: spectre-v2: per-CPU vtables to work around big.Little
systems")
e209950fdd06 ("ARM: add PROC_VTABLE and PROC_TABLE macros")
945aceb1db88 ("ARM: clean up per-processor check_bugs method call")
899a42f83667 ("ARM: make lookup_processor_type() non-__init")
I'll go drop them all from the trees now. Turns out for 4.14 one of
these patches broke the build anyway. Sasha, how did that past your
builder tests?
Because it builds :)
--
Thanks,
Sasha
Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
On Fri, Nov 30, 2018 at 04:18:43PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Nov 30, 2018 at 04:15:54PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux wrote:
> > > Hi,
> > >
> > > As I've already fed back to Sascha about this, this patch on its own
> > > does not fix anything, and is not a stable kernel candidate without
> > > a patch that makes use of it (iow, the spectre fixes.) It is a
> > > preparatory patch for mainline commit 383fb3ee8024.
> > >
> > > Every commit in:
> > >
> > > $ git rev-list v4.16..383fb3ee8024
> > >
> > > are the ARM spectre fixes, which are being back-ported by David Long.
> > >
> > > Please do not cherry-pick commits from within this series for _any_
> > > stable kernel, but please wait for David to send you the back-ported
> > > patches.
> >
> > Ugh, ok, that's a bunch here.
>
> Ok, not that bad, only 4:
> 383fb3ee8024 ("ARM: spectre-v2: per-CPU vtables to work around
> big.Little systems")
> e209950fdd06 ("ARM: add PROC_VTABLE and PROC_TABLE macros")
> 945aceb1db88 ("ARM: clean up per-processor check_bugs method call")
> 899a42f83667 ("ARM: make lookup_processor_type() non-__init")
>
> I'll go drop them all from the trees now.
Thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
On Fri, Nov 30, 2018 at 04:18:43PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Nov 30, 2018 at 04:15:54PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux wrote:
> > > Hi,
> > >
> > > As I've already fed back to Sascha about this, this patch on its own
> > > does not fix anything, and is not a stable kernel candidate without
> > > a patch that makes use of it (iow, the spectre fixes.) It is a
> > > preparatory patch for mainline commit 383fb3ee8024.
> > >
> > > Every commit in:
> > >
> > > $ git rev-list v4.16..383fb3ee8024
> > >
> > > are the ARM spectre fixes, which are being back-ported by David Long.
> > >
> > > Please do not cherry-pick commits from within this series for _any_
> > > stable kernel, but please wait for David to send you the back-ported
> > > patches.
> >
> > Ugh, ok, that's a bunch here.
>
> Ok, not that bad, only 4:
> 383fb3ee8024 ("ARM: spectre-v2: per-CPU vtables to work around
> big.Little systems")
> e209950fdd06 ("ARM: add PROC_VTABLE and PROC_TABLE macros")
> 945aceb1db88 ("ARM: clean up per-processor check_bugs method call")
> 899a42f83667 ("ARM: make lookup_processor_type() non-__init")
>
> I'll go drop them all from the trees now.
Thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
On Fri, Nov 30, 2018 at 04:15:54PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux wrote:
> > Hi,
> >
> > As I've already fed back to Sascha about this, this patch on its own
> > does not fix anything, and is not a stable kernel candidate without
> > a patch that makes use of it (iow, the spectre fixes.) It is a
> > preparatory patch for mainline commit 383fb3ee8024.
> >
> > Every commit in:
> >
> > $ git rev-list v4.16..383fb3ee8024
> >
> > are the ARM spectre fixes, which are being back-ported by David Long.
> >
> > Please do not cherry-pick commits from within this series for _any_
> > stable kernel, but please wait for David to send you the back-ported
> > patches.
>
> Ugh, ok, that's a bunch here.
Ok, not that bad, only 4:
383fb3ee8024 ("ARM: spectre-v2: per-CPU vtables to work around
big.Little systems")
e209950fdd06 ("ARM: add PROC_VTABLE and PROC_TABLE macros")
945aceb1db88 ("ARM: clean up per-processor check_bugs method call")
899a42f83667 ("ARM: make lookup_processor_type() non-__init")
I'll go drop them all from the trees now. Turns out for 4.14 one of
these patches broke the build anyway. Sasha, how did that past your
builder tests?
thanks,
greg k-h
Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
On Fri, Nov 30, 2018 at 04:15:54PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux wrote:
> > Hi,
> >
> > As I've already fed back to Sascha about this, this patch on its own
> > does not fix anything, and is not a stable kernel candidate without
> > a patch that makes use of it (iow, the spectre fixes.) It is a
> > preparatory patch for mainline commit 383fb3ee8024.
> >
> > Every commit in:
> >
> > $ git rev-list v4.16..383fb3ee8024
> >
> > are the ARM spectre fixes, which are being back-ported by David Long.
> >
> > Please do not cherry-pick commits from within this series for _any_
> > stable kernel, but please wait for David to send you the back-ported
> > patches.
>
> Ugh, ok, that's a bunch here.
Ok, not that bad, only 4:
383fb3ee8024 ("ARM: spectre-v2: per-CPU vtables to work around
big.Little systems")
e209950fdd06 ("ARM: add PROC_VTABLE and PROC_TABLE macros")
945aceb1db88 ("ARM: clean up per-processor check_bugs method call")
899a42f83667 ("ARM: make lookup_processor_type() non-__init")
I'll go drop them all from the trees now. Turns out for 4.14 one of
these patches broke the build anyway. Sasha, how did that past your
builder tests?
thanks,
greg k-h
Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux wrote: > Hi, > > As I've already fed back to Sascha about this, this patch on its own > does not fix anything, and is not a stable kernel candidate without > a patch that makes use of it (iow, the spectre fixes.) It is a > preparatory patch for mainline commit 383fb3ee8024. > > Every commit in: > > $ git rev-list v4.16..383fb3ee8024 > > are the ARM spectre fixes, which are being back-ported by David Long. > > Please do not cherry-pick commits from within this series for _any_ > stable kernel, but please wait for David to send you the back-ported > patches. Ugh, ok, that's a bunch here. Sasha, let me go dig all of these out now. Russell, thanks for letting me know. greg k-h
Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux wrote: > Hi, > > As I've already fed back to Sascha about this, this patch on its own > does not fix anything, and is not a stable kernel candidate without > a patch that makes use of it (iow, the spectre fixes.) It is a > preparatory patch for mainline commit 383fb3ee8024. > > Every commit in: > > $ git rev-list v4.16..383fb3ee8024 > > are the ARM spectre fixes, which are being back-ported by David Long. > > Please do not cherry-pick commits from within this series for _any_ > stable kernel, but please wait for David to send you the back-ported > patches. Ugh, ok, that's a bunch here. Sasha, let me go dig all of these out now. Russell, thanks for letting me know. greg k-h
Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
Hi,
As I've already fed back to Sascha about this, this patch on its own
does not fix anything, and is not a stable kernel candidate without
a patch that makes use of it (iow, the spectre fixes.) It is a
preparatory patch for mainline commit 383fb3ee8024.
Every commit in:
$ git rev-list v4.16..383fb3ee8024
are the ARM spectre fixes, which are being back-ported by David Long.
Please do not cherry-pick commits from within this series for _any_
stable kernel, but please wait for David to send you the back-ported
patches.
Thanks.
On Thu, Nov 29, 2018 at 03:11:32PM +0100, Greg Kroah-Hartman wrote:
> 3.18-stable review patch. If anyone has any objections, please let me know.
>
> --
>
> [ Upstream commit 899a42f836678a595f7d2bc36a5a0c2b03d08cbc ]
>
> Move lookup_processor_type() out of the __init section so it is callable
> from (eg) the secondary startup code during hotplug.
>
> Reviewed-by: Julien Thierry
> Signed-off-by: Russell King
> Signed-off-by: Sasha Levin
> ---
> arch/arm/kernel/head-common.S | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/kernel/head-common.S b/arch/arm/kernel/head-common.S
> index 8733012d231f..7e662bdd5cb3 100644
> --- a/arch/arm/kernel/head-common.S
> +++ b/arch/arm/kernel/head-common.S
> @@ -122,6 +122,9 @@ __mmap_switched_data:
> .long init_thread_union + THREAD_START_SP @ sp
> .size __mmap_switched_data, . - __mmap_switched_data
>
> + __FINIT
> + .text
> +
> /*
> * This provides a C-API version of __lookup_processor_type
> */
> @@ -133,9 +136,6 @@ ENTRY(lookup_processor_type)
> ldmfd sp!, {r4 - r6, r9, pc}
> ENDPROC(lookup_processor_type)
>
> - __FINIT
> - .text
> -
> /*
> * Read processor ID register (CP#15, CR0), and look up in the linker-built
> * supported processor list. Note that we can't use the absolute addresses
> --
> 2.17.1
>
>
>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init
Hi,
As I've already fed back to Sascha about this, this patch on its own
does not fix anything, and is not a stable kernel candidate without
a patch that makes use of it (iow, the spectre fixes.) It is a
preparatory patch for mainline commit 383fb3ee8024.
Every commit in:
$ git rev-list v4.16..383fb3ee8024
are the ARM spectre fixes, which are being back-ported by David Long.
Please do not cherry-pick commits from within this series for _any_
stable kernel, but please wait for David to send you the back-ported
patches.
Thanks.
On Thu, Nov 29, 2018 at 03:11:32PM +0100, Greg Kroah-Hartman wrote:
> 3.18-stable review patch. If anyone has any objections, please let me know.
>
> --
>
> [ Upstream commit 899a42f836678a595f7d2bc36a5a0c2b03d08cbc ]
>
> Move lookup_processor_type() out of the __init section so it is callable
> from (eg) the secondary startup code during hotplug.
>
> Reviewed-by: Julien Thierry
> Signed-off-by: Russell King
> Signed-off-by: Sasha Levin
> ---
> arch/arm/kernel/head-common.S | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/kernel/head-common.S b/arch/arm/kernel/head-common.S
> index 8733012d231f..7e662bdd5cb3 100644
> --- a/arch/arm/kernel/head-common.S
> +++ b/arch/arm/kernel/head-common.S
> @@ -122,6 +122,9 @@ __mmap_switched_data:
> .long init_thread_union + THREAD_START_SP @ sp
> .size __mmap_switched_data, . - __mmap_switched_data
>
> + __FINIT
> + .text
> +
> /*
> * This provides a C-API version of __lookup_processor_type
> */
> @@ -133,9 +136,6 @@ ENTRY(lookup_processor_type)
> ldmfd sp!, {r4 - r6, r9, pc}
> ENDPROC(lookup_processor_type)
>
> - __FINIT
> - .text
> -
> /*
> * Read processor ID register (CP#15, CR0), and look up in the linker-built
> * supported processor list. Note that we can't use the absolute addresses
> --
> 2.17.1
>
>
>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
