Re: [PATCH 4/4] arm64: Kconfig: Fix EXYNOS driver dependencies

2019-09-12 Thread Mark Brown 
On Thu, Sep 12, 2019 at 03:48:48AM +0530, Amit Kucheria wrote:

> Push various EXYNOS drivers behind ARCH_EXYNOS dependency so that it
> doesn't get enabled by default on other platforms.

>  config REGULATOR_S2MPS11
>   tristate "Samsung S2MPS11/13/14/15/S2MPU02 voltage regulator"
> + depends on ARCH_EXYNOS
>   depends on MFD_SEC_CORE
>   help
>This driver supports a Samsung S2MPS11/13/14/15/S2MPU02 voltage

This doesn't match the changelog at all.  This driver is not
enabled by default since it's just a normal tristate, they are
disabled by default.  As far as I can see all this change will
do is reduce our build test coverage by adding an artificial
dependency without an || COMPILE_TEST.


signature.asc
Description: PGP signature

Re: [PATCH 4/4] arm64: Kconfig: Fix EXYNOS driver dependencies

2019-09-12 Thread Arnd Bergmann 
On Thu, Sep 12, 2019 at 12:19 AM Amit Kucheria  wrote:

> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 9b2790d3f18a..bdf164a7a7c5 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -194,6 +194,7 @@ config COMMON_CLK_ASPEED
>
>  config COMMON_CLK_S2MPS11
> tristate "Clock driver for S2MPS1X/S5M8767 MFD"
> +   depends on ARCH_EXYNOS
> depends on MFD_SEC_CORE || COMPILE_TEST
> ---help---
>   This driver supports S2MPS11/S2MPS14/S5M8767 crystal oscillator

This breaks compile-testing on non-ARM targets.

> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index b57093d7c01f..a4c4f01343fd 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -797,6 +797,7 @@ config REGULATOR_S2MPA01
>
>  config REGULATOR_S2MPS11
> tristate "Samsung S2MPS11/13/14/15/S2MPU02 voltage regulator"
> +   depends on ARCH_EXYNOS
> depends on MFD_SEC_CORE
> help
>  This driver supports a Samsung S2MPS11/13/14/15/S2MPU02 voltage

Same here. What you could do instead is add

depends on ARCH_EXYNOS || COMPILE_TEST

to MFD_SEC_CORE, this would then propagate to these
two drivers as well.

  Arnd