Re: [PATCH 4/4] pinctrl: samsung: Remove unused local variable

[Charles Keepax]

On Wed, Feb 15, 2017 at 07:43:03PM +0200, Krzysztof Kozlowski wrote:
> On Mon, Feb 13, 2017 at 10:11:06AM +, Charles Keepax wrote:
> > Signed-off-by: Charles Keepax 
> 
> "The local variable drvdata is not used in samsung_gpio_set_direction()"?
> 
> Reviewed-by: Krzysztof Kozlowski 
> 

Thanks, will update the commit messages with your
recommendations and resend.

Thanks,
Charles

Re: [PATCH 4/4] pinctrl: samsung: Remove unused local variable

[Krzysztof Kozlowski]

On Mon, Feb 13, 2017 at 10:11:06AM +, Charles Keepax wrote:
> Signed-off-by: Charles Keepax 

"The local variable drvdata is not used in samsung_gpio_set_direction()"?

Reviewed-by: Krzysztof Kozlowski 

Best regards,
Krzysztof

> ---
>  drivers/pinctrl/samsung/pinctrl-samsung.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c 
> b/drivers/pinctrl/samsung/pinctrl-samsung.c
> index f291cbf..eb08f30 100644
> --- a/drivers/pinctrl/samsung/pinctrl-samsung.c
> +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
> @@ -566,13 +566,11 @@ static int samsung_gpio_set_direction(struct gpio_chip 
> *gc,
>  {
>   const struct samsung_pin_bank_type *type;
>   struct samsung_pin_bank *bank;
> - struct samsung_pinctrl_drv_data *drvdata;
>   void __iomem *reg;
>   u32 data, mask, shift;
>  
>   bank = gpiochip_get_data(gc);
>   type = bank->type;
> - drvdata = bank->drvdata;
>  
>   reg = bank->pctl_base + bank->pctl_offset
>   + type->reg_offset[PINCFG_TYPE_FUNC];
> -- 
> 2.1.4
>