Re: [PATCH 4/5] ASoC: lpass: use the clock provider API

2021-04-12 Thread Srinivas Kandagatla
On 12/04/2021 13:17, Jerome Brunet wrote: -return of_clk_add_provider(np, of_clk_src_simple_get, va->hw.clk); + return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, >hw); Now that we convert this to devm, You missed error path and driver remove where we delete clk

Re: [PATCH 4/5] ASoC: lpass: use the clock provider API

2021-04-12 Thread Jerome Brunet
On Mon 12 Apr 2021 at 11:38, Srinivas Kandagatla wrote: > Thanks Jerome for the patch, > > > On 10/04/2021 12:13, Jerome Brunet wrote: >> Clock providers should be registered using the clk_hw API. >> Signed-off-by: Jerome Brunet >> --- >> sound/soc/codecs/lpass-va-macro.c | 2 +- >>

Re: [PATCH 4/5] ASoC: lpass: use the clock provider API

2021-04-12 Thread Srinivas Kandagatla
Thanks Jerome for the patch, On 10/04/2021 12:13, Jerome Brunet wrote: Clock providers should be registered using the clk_hw API. Signed-off-by: Jerome Brunet --- sound/soc/codecs/lpass-va-macro.c | 2 +- sound/soc/codecs/lpass-wsa-macro.c | 9 +++-- 2 files changed, 4