Re: [PATCH 4/6] lib/scatterlist: Unexport some trivial wrappers
On 07/03/18 16:19, Bart Van Assche wrote: On Wed, 2018-03-07 at 12:47 +, Tvrtko Ursulin wrote: Save some kernel size by moving trivial wrappers to header as static inline instead of exporting symbols for them. Something that you may be unaware of is that the introduction of the sgl helper functions is only a first step. The next step will be to introduce a caching allocator for sg-lists. So for small sg-lists inlining won't help performance. But moving these definitions from a .c file into a .h file will (slightly) slow down kernel compilation. So I'd prefer that you drop this patch. Question is how will the future work influence these trivial wrappers? I wasn't suggesting I removed them for performance reasons, but just because they are really trivial and so there is no need right now to have them as exported symbols. And actually in one of the earlier work I did in lib/scatterlist.c Andrew Morton complained a bit to the prevalence of these trivial wrappers. So I even had plans to remove some of the existing ones but never got round to it. Regards, Tvrtko
Re: [PATCH 4/6] lib/scatterlist: Unexport some trivial wrappers
On 07/03/18 16:19, Bart Van Assche wrote: On Wed, 2018-03-07 at 12:47 +, Tvrtko Ursulin wrote: Save some kernel size by moving trivial wrappers to header as static inline instead of exporting symbols for them. Something that you may be unaware of is that the introduction of the sgl helper functions is only a first step. The next step will be to introduce a caching allocator for sg-lists. So for small sg-lists inlining won't help performance. But moving these definitions from a .c file into a .h file will (slightly) slow down kernel compilation. So I'd prefer that you drop this patch. Question is how will the future work influence these trivial wrappers? I wasn't suggesting I removed them for performance reasons, but just because they are really trivial and so there is no need right now to have them as exported symbols. And actually in one of the earlier work I did in lib/scatterlist.c Andrew Morton complained a bit to the prevalence of these trivial wrappers. So I even had plans to remove some of the existing ones but never got round to it. Regards, Tvrtko
Re: [PATCH 4/6] lib/scatterlist: Unexport some trivial wrappers
On Wed, 2018-03-07 at 12:47 +, Tvrtko Ursulin wrote: > Save some kernel size by moving trivial wrappers to header as static > inline instead of exporting symbols for them. Something that you may be unaware of is that the introduction of the sgl helper functions is only a first step. The next step will be to introduce a caching allocator for sg-lists. So for small sg-lists inlining won't help performance. But moving these definitions from a .c file into a .h file will (slightly) slow down kernel compilation. So I'd prefer that you drop this patch. Thanks, Bart.
Re: [PATCH 4/6] lib/scatterlist: Unexport some trivial wrappers
On Wed, 2018-03-07 at 12:47 +, Tvrtko Ursulin wrote: > Save some kernel size by moving trivial wrappers to header as static > inline instead of exporting symbols for them. Something that you may be unaware of is that the introduction of the sgl helper functions is only a first step. The next step will be to introduce a caching allocator for sg-lists. So for small sg-lists inlining won't help performance. But moving these definitions from a .c file into a .h file will (slightly) slow down kernel compilation. So I'd prefer that you drop this patch. Thanks, Bart.
