Re: [PATCH 4/6] staging/fbtft: Stop using BL_CORE_DRIVER1

2018-04-30 Thread Greg KH
On Mon, Apr 30, 2018 at 10:54:15AM +0100, Lee Jones wrote: > Greg, Thomas, > > On Wed, 25 Apr 2018, Daniel Vetter wrote: > > Leaking driver internal tracking into the already massively confusing > > backlight power tracking is really confusing. > > > > Luckily we have already a drvdata

Re: [PATCH 4/6] staging/fbtft: Stop using BL_CORE_DRIVER1

2018-04-30 Thread Greg KH
On Mon, Apr 30, 2018 at 10:54:15AM +0100, Lee Jones wrote: > Greg, Thomas, > > On Wed, 25 Apr 2018, Daniel Vetter wrote: > > Leaking driver internal tracking into the already massively confusing > > backlight power tracking is really confusing. > > > > Luckily we have already a drvdata

Re: [PATCH 4/6] staging/fbtft: Stop using BL_CORE_DRIVER1

2018-04-30 Thread Jani Nikula
On Wed, 25 Apr 2018, Daniel Vetter wrote: > Leaking driver internal tracking into the already massively confusing > backlight power tracking is really confusing. > > Luckily we have already a drvdata structure, so fixing this is really > easy. > > Cc: Lee Jones

Re: [PATCH 4/6] staging/fbtft: Stop using BL_CORE_DRIVER1

2018-04-30 Thread Jani Nikula
On Wed, 25 Apr 2018, Daniel Vetter wrote: > Leaking driver internal tracking into the already massively confusing > backlight power tracking is really confusing. > > Luckily we have already a drvdata structure, so fixing this is really > easy. > > Cc: Lee Jones > Cc: Daniel Thompson > Cc:

Re: [PATCH 4/6] staging/fbtft: Stop using BL_CORE_DRIVER1

2018-04-30 Thread Lee Jones
Greg, Thomas, On Wed, 25 Apr 2018, Daniel Vetter wrote: > Leaking driver internal tracking into the already massively confusing > backlight power tracking is really confusing. > > Luckily we have already a drvdata structure, so fixing this is really > easy. > > Cc: Lee Jones

Re: [PATCH 4/6] staging/fbtft: Stop using BL_CORE_DRIVER1

2018-04-30 Thread Lee Jones
Greg, Thomas, On Wed, 25 Apr 2018, Daniel Vetter wrote: > Leaking driver internal tracking into the already massively confusing > backlight power tracking is really confusing. > > Luckily we have already a drvdata structure, so fixing this is really > easy. > > Cc: Lee Jones > Cc: Daniel

Re: [PATCH 4/6] staging/fbtft: Stop using BL_CORE_DRIVER1

2018-01-17 Thread Daniel Thompson
On 17/01/18 14:01, Daniel Vetter wrote: Leaking driver internal tracking into the already massively confusing backlight power tracking is really confusing. Luckily we have already a drvdata structure, so fixing this is really easy. Cc: Lee Jones Cc: Daniel Thompson

Re: [PATCH 4/6] staging/fbtft: Stop using BL_CORE_DRIVER1

2018-01-17 Thread Daniel Thompson
On 17/01/18 14:01, Daniel Vetter wrote: Leaking driver internal tracking into the already massively confusing backlight power tracking is really confusing. Luckily we have already a drvdata structure, so fixing this is really easy. Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Cc: Thomas