Re: [PATCH 4/7] ARM: dts: stm32: Enable USB HS on stm32746g-eval

2017-08-17 Thread Amelie DELAUNAY 
Hi!

On 08/17/2017 12:44 PM, Sergei Shtylyov wrote:
> Hello!
> 
> On 8/17/2017 12:33 PM, Amelie Delaunay wrote:
> 
>> This patch enables USB HS on stm32746g-eval (Host mode).
>>
>> Signed-off-by: Amelie Delaunay 
>> ---
>>   arch/arm/boot/dts/stm32746g-eval.dts | 16 
>>   1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32746g-eval.dts 
>> b/arch/arm/boot/dts/stm32746g-eval.dts
>> index 69a9579..944501d 100644
>> --- a/arch/arm/boot/dts/stm32746g-eval.dts
>> +++ b/arch/arm/boot/dts/stm32746g-eval.dts
>> @@ -83,6 +83,13 @@
>>   gpios = < 13 0>;
>>   };
>>   };
>> +
>> +usbotg_hs_phy: usbphy {
> 
> Name it "usb-phy" please, tpo be m,ore in line with the DT spec.
OK, will be fixed in v2. Thanks!
> 
> [...]
> 
> MBR, Sergei

Regards,
Amelie

Re: [PATCH 4/7] ARM: dts: stm32: Enable USB HS on stm32746g-eval

2017-08-17 Thread Amelie DELAUNAY 
Hi!

On 08/17/2017 12:44 PM, Sergei Shtylyov wrote:
> Hello!
> 
> On 8/17/2017 12:33 PM, Amelie Delaunay wrote:
> 
>> This patch enables USB HS on stm32746g-eval (Host mode).
>>
>> Signed-off-by: Amelie Delaunay 
>> ---
>>   arch/arm/boot/dts/stm32746g-eval.dts | 16 
>>   1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32746g-eval.dts 
>> b/arch/arm/boot/dts/stm32746g-eval.dts
>> index 69a9579..944501d 100644
>> --- a/arch/arm/boot/dts/stm32746g-eval.dts
>> +++ b/arch/arm/boot/dts/stm32746g-eval.dts
>> @@ -83,6 +83,13 @@
>>   gpios = < 13 0>;
>>   };
>>   };
>> +
>> +usbotg_hs_phy: usbphy {
> 
> Name it "usb-phy" please, tpo be m,ore in line with the DT spec.
OK, will be fixed in v2. Thanks!
> 
> [...]
> 
> MBR, Sergei

Regards,
Amelie

Re: [PATCH 4/7] ARM: dts: stm32: Enable USB HS on stm32746g-eval

2017-08-17 Thread Sergei Shtylyov 

Hello!

On 8/17/2017 12:33 PM, Amelie Delaunay wrote:


This patch enables USB HS on stm32746g-eval (Host mode).

Signed-off-by: Amelie Delaunay 
---
  arch/arm/boot/dts/stm32746g-eval.dts | 16 
  1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/stm32746g-eval.dts 
b/arch/arm/boot/dts/stm32746g-eval.dts
index 69a9579..944501d 100644
--- a/arch/arm/boot/dts/stm32746g-eval.dts
+++ b/arch/arm/boot/dts/stm32746g-eval.dts
@@ -83,6 +83,13 @@
gpios = < 13 0>;
};
};
+
+   usbotg_hs_phy: usbphy {


   Name it "usb-phy" please, tpo be m,ore in line with the DT spec.

[...]

MBR, Sergei

Re: [PATCH 4/7] ARM: dts: stm32: Enable USB HS on stm32746g-eval

2017-08-17 Thread Sergei Shtylyov 

Hello!

On 8/17/2017 12:33 PM, Amelie Delaunay wrote:


This patch enables USB HS on stm32746g-eval (Host mode).

Signed-off-by: Amelie Delaunay 
---
  arch/arm/boot/dts/stm32746g-eval.dts | 16 
  1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/stm32746g-eval.dts 
b/arch/arm/boot/dts/stm32746g-eval.dts
index 69a9579..944501d 100644
--- a/arch/arm/boot/dts/stm32746g-eval.dts
+++ b/arch/arm/boot/dts/stm32746g-eval.dts
@@ -83,6 +83,13 @@
gpios = < 13 0>;
};
};
+
+   usbotg_hs_phy: usbphy {


   Name it "usb-phy" please, tpo be m,ore in line with the DT spec.

[...]

MBR, Sergei