Re: [PATCH 4/8] Input: elantech - split device info into a separate structure
Hi Benjamin, I love your patch! Perhaps something to improve: [auto build test WARNING on next-20180405] [cannot apply to input/next v4.16 v4.16-rc7 v4.16-rc6 v4.16] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Benjamin-Tissoires/Input-support-for-latest-Lenovo-thinkpads-series-80/20180406-110729 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/input/mouse/elantech.c:1665:5: sparse: symbol 'elantech_query_info' >> was not declared. Should it be static? drivers/input/mouse/elantech.c: In function 'elantech_init': drivers/input/mouse/elantech.c:1839:9: warning: 'error' may be used uninitialized in this function [-Wmaybe-uninitialized] return error; ^ Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH 4/8] Input: elantech - split device info into a separate structure
Hi Benjamin, I love your patch! Perhaps something to improve: [auto build test WARNING on next-20180405] [cannot apply to input/next v4.16 v4.16-rc7 v4.16-rc6 v4.16] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Benjamin-Tissoires/Input-support-for-latest-Lenovo-thinkpads-series-80/20180406-110729 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/input/mouse/elantech.c:1665:5: sparse: symbol 'elantech_query_info' >> was not declared. Should it be static? drivers/input/mouse/elantech.c: In function 'elantech_init': drivers/input/mouse/elantech.c:1839:9: warning: 'error' may be used uninitialized in this function [-Wmaybe-uninitialized] return error; ^ Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
