Re: [PATCH 4/8] struct page: add field for vm_struct
On 3/15/18 2:38 AM, Igor Stoppa wrote: On 14/03/18 19:43, J Freyensee wrote: On 3/13/18 3:00 PM, Matthew Wilcox wrote: [...] Signed-off-by: Igor Stoppa Reviewed-by: Matthew Wilcox Igor, do you mind sticking these tags on the files that have spent some time reviewing a revision of your patchset (like the Reviewed-by: tags I provided last revision?) Apologies, that was not intentional, I forgot it. I will do it, although most of the files will now change so much that I am not sure what will survive, beside this patch, in the form that you reviewed. I suppose the Review-by tag drops, if the patch changes. That's true, if so much of the patch changes it basically looks like something different, the Reviewed-by: would drop. Jay -- igor
Re: [PATCH 4/8] struct page: add field for vm_struct
On 14/03/18 19:43, J Freyensee wrote: > On 3/13/18 3:00 PM, Matthew Wilcox wrote: [...] >>> Signed-off-by: Igor Stoppa >> Reviewed-by: Matthew Wilcox > > Igor, do you mind sticking these tags on the files that have spent some > time reviewing a revision of your patchset (like the Reviewed-by: tags I > provided last revision?) Apologies, that was not intentional, I forgot it. I will do it, although most of the files will now change so much that I am not sure what will survive, beside this patch, in the form that you reviewed. I suppose the Review-by tag drops, if the patch changes. -- igor
Re: [PATCH 4/8] struct page: add field for vm_struct
On 3/13/18 3:00 PM, Matthew Wilcox wrote: On Tue, Mar 13, 2018 at 11:45:50PM +0200, Igor Stoppa wrote: When a page is used for virtual memory, it is often necessary to obtain a handler to the corresponding vm_struct, which refers to the virtually continuous area generated when invoking vmalloc. The struct page has a "mapping" field, which can be re-used, to store a pointer to the parent area. This will avoid more expensive searches, later on. Signed-off-by: Igor Stoppa Reviewed-by: Matthew Wilcox Igor, do you mind sticking these tags on the files that have spent some time reviewing a revision of your patchset (like the Reviewed-by: tags I provided last revision?) Thanks, Jay
Re: [PATCH 4/8] struct page: add field for vm_struct
On Tue, Mar 13, 2018 at 11:45:50PM +0200, Igor Stoppa wrote: > When a page is used for virtual memory, it is often necessary to obtain > a handler to the corresponding vm_struct, which refers to the virtually > continuous area generated when invoking vmalloc. > > The struct page has a "mapping" field, which can be re-used, to store a > pointer to the parent area. > > This will avoid more expensive searches, later on. > > Signed-off-by: Igor Stoppa Reviewed-by: Matthew Wilcox Regardless of the fate of the rest of this patchset, this makes sense and we should have this.
