Re: [PATCH 5/5] PCI: Add host drivers for Cavium ThunderX processors.

2015-07-17 Thread Arnd Bergmann
On Wednesday 15 July 2015 09:54:45 David Daney wrote: > From: David Daney > > Signed-off-by: David Daney Please describe here in what way is this incompatible with SBSA. >From earlier discussions I had expected ThunderX to be SBSA compliant, so I'm a bit surprised to see a PCI hack now. >

Re: [PATCH 5/5] PCI: Add host drivers for Cavium ThunderX processors.

2015-07-17 Thread Arnd Bergmann
On Wednesday 15 July 2015 09:54:45 David Daney wrote: From: David Daney david.da...@cavium.com Signed-off-by: David Daney david.da...@cavium.com Please describe here in what way is this incompatible with SBSA. From earlier discussions I had expected ThunderX to be SBSA compliant, so I'm a bit

Re: [PATCH 5/5] PCI: Add host drivers for Cavium ThunderX processors.

2015-07-16 Thread David Daney
On 07/16/2015 01:31 AM, Paul Bolle wrote: On wo, 2015-07-15 at 09:54 -0700, David Daney wrote: --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig +config PCI_THUNDER_PEM + bool Do you expect other symbols to select this symbol in the future? No, ... Because at this

Re: [PATCH 5/5] PCI: Add host drivers for Cavium ThunderX processors.

2015-07-16 Thread Lorenzo Pieralisi
Hi David, On Wed, Jul 15, 2015 at 05:54:45PM +0100, David Daney wrote: > From: David Daney > -ENOCOMMITLOG > Signed-off-by: David Daney > --- > drivers/pci/host/Kconfig| 12 + > drivers/pci/host/Makefile | 2 + > drivers/pci/host/pcie-thunder-pem.c | 462 >

Re: [PATCH 5/5] PCI: Add host drivers for Cavium ThunderX processors.

2015-07-16 Thread Paul Bolle
On wo, 2015-07-15 at 09:54 -0700, David Daney wrote: > --- a/drivers/pci/host/Kconfig > +++ b/drivers/pci/host/Kconfig > +config PCI_THUNDER_PEM > + bool Do you expect other symbols to select this symbol in the future? Because at this moment PCI_THUNDER_PEM is merely an alias for

Re: [PATCH 5/5] PCI: Add host drivers for Cavium ThunderX processors.

2015-07-16 Thread Paul Bolle
On wo, 2015-07-15 at 09:54 -0700, David Daney wrote: --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig +config PCI_THUNDER_PEM + bool Do you expect other symbols to select this symbol in the future? Because at this moment PCI_THUNDER_PEM is merely an alias for PCI_THUNDER.

Re: [PATCH 5/5] PCI: Add host drivers for Cavium ThunderX processors.

2015-07-16 Thread Lorenzo Pieralisi
Hi David, On Wed, Jul 15, 2015 at 05:54:45PM +0100, David Daney wrote: From: David Daney david.da...@cavium.com -ENOCOMMITLOG Signed-off-by: David Daney david.da...@cavium.com --- drivers/pci/host/Kconfig| 12 + drivers/pci/host/Makefile | 2 +

Re: [PATCH 5/5] PCI: Add host drivers for Cavium ThunderX processors.

2015-07-16 Thread David Daney
On 07/16/2015 01:31 AM, Paul Bolle wrote: On wo, 2015-07-15 at 09:54 -0700, David Daney wrote: --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig +config PCI_THUNDER_PEM + bool Do you expect other symbols to select this symbol in the future? No, ... Because at this

Re: [PATCH 5/5] PCI: Add host drivers for Cavium ThunderX processors.

2015-07-15 Thread Marc Zyngier
On 15/07/15 17:54, David Daney wrote: > From: David Daney > > Signed-off-by: David Daney > --- > drivers/pci/host/Kconfig| 12 + > drivers/pci/host/Makefile | 2 + > drivers/pci/host/pcie-thunder-pem.c | 462 > >

Re: [PATCH 5/5] PCI: Add host drivers for Cavium ThunderX processors.

2015-07-15 Thread Mark Rutland
Hi, As mentioned in my reply to the cover letter, a DT binding document is necessary for this. It looks like many of the properties of your root complex which should be described (e.g. physical addresses, master IDs as visible to MSI controllers) are blindly assumed by this driver, and I expect

Re: [PATCH 5/5] PCI: Add host drivers for Cavium ThunderX processors.

2015-07-15 Thread Marc Zyngier
On 15/07/15 17:54, David Daney wrote: From: David Daney david.da...@cavium.com Signed-off-by: David Daney david.da...@cavium.com --- drivers/pci/host/Kconfig| 12 + drivers/pci/host/Makefile | 2 + drivers/pci/host/pcie-thunder-pem.c | 462

Re: [PATCH 5/5] PCI: Add host drivers for Cavium ThunderX processors.

2015-07-15 Thread Mark Rutland
Hi, As mentioned in my reply to the cover letter, a DT binding document is necessary for this. It looks like many of the properties of your root complex which should be described (e.g. physical addresses, master IDs as visible to MSI controllers) are blindly assumed by this driver, and I expect