Re: [PATCH 5/6] GPU-DRM-GMA500: One error message less for a GCT revision mismatch in mid_get_vbt_data()

2016-09-20 Thread Patrik Jakobsson
On Tue, Sep 20, 2016 at 2:08 PM, Jani Nikula wrote: > On Tue, 20 Sep 2016, Dan Carpenter wrote: >> Don't be a dummy... This is easy to review an it fixes a bug. In this particular case it might not be clear that an unknown GCT version

Re: [PATCH 5/6] GPU-DRM-GMA500: One error message less for a GCT revision mismatch in mid_get_vbt_data()

2016-09-20 Thread Patrik Jakobsson
On Tue, Sep 20, 2016 at 2:08 PM, Jani Nikula wrote: > On Tue, 20 Sep 2016, Dan Carpenter wrote: >> Don't be a dummy... This is easy to review an it fixes a bug. In this particular case it might not be clear that an unknown GCT version causes a complete GCT failure so both messages are useful.

Re: [PATCH 5/6] GPU-DRM-GMA500: One error message less for a GCT revision mismatch in mid_get_vbt_data()

2016-09-20 Thread Jani Nikula
On Tue, 20 Sep 2016, Dan Carpenter wrote: > Don't be a dummy... This is easy to review an it fixes a bug. > > I'm fine with you NAKing all these patches based on who they are from. > I mostly just delete these without responding because the guy has > history of

Re: [PATCH 5/6] GPU-DRM-GMA500: One error message less for a GCT revision mismatch in mid_get_vbt_data()

2016-09-20 Thread Jani Nikula
On Tue, 20 Sep 2016, Dan Carpenter wrote: > Don't be a dummy... This is easy to review an it fixes a bug. > > I'm fine with you NAKing all these patches based on who they are from. > I mostly just delete these without responding because the guy has > history of introducing bugs and never listens

Re: [PATCH 5/6] GPU-DRM-GMA500: One error message less for a GCT revision mismatch in mid_get_vbt_data()

2016-09-20 Thread Dan Carpenter
On Tue, Sep 20, 2016 at 01:07:35PM +0300, Jani Nikula wrote: > On Tue, 20 Sep 2016, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Tue, 20 Sep 2016 10:36:19 +0200 > > > > A single error message should be sufficient to

Re: [PATCH 5/6] GPU-DRM-GMA500: One error message less for a GCT revision mismatch in mid_get_vbt_data()

2016-09-20 Thread Dan Carpenter
On Tue, Sep 20, 2016 at 01:07:35PM +0300, Jani Nikula wrote: > On Tue, 20 Sep 2016, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Tue, 20 Sep 2016 10:36:19 +0200 > > > > A single error message should be sufficient to inform about > > the detection of an unknown GCT revision at the

Re: [PATCH 5/6] GPU-DRM-GMA500: One error message less for a GCT revision mismatch in mid_get_vbt_data()

2016-09-20 Thread Jani Nikula
On Tue, 20 Sep 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 20 Sep 2016 10:36:19 +0200 > > A single error message should be sufficient to inform about > the detection of an unknown GCT revision at the end. > Thus

Re: [PATCH 5/6] GPU-DRM-GMA500: One error message less for a GCT revision mismatch in mid_get_vbt_data()

2016-09-20 Thread Jani Nikula
On Tue, 20 Sep 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 20 Sep 2016 10:36:19 +0200 > > A single error message should be sufficient to inform about > the detection of an unknown GCT revision at the end. > Thus return after the logging call in this case directly. Did you