Re: [PATCH 5/6] Pmalloc: self-test

2018-02-22 Thread Igor Stoppa
On 22/02/18 00:24, Kees Cook wrote: > On Tue, Feb 20, 2018 at 8:40 AM, Igor Stoppa wrote: [...] >> sorry for being dense ... are you proposing that I do something to >> lkdtm_rodata.c ? An example would probably help me understand. > > It would likely live in

Re: [PATCH 5/6] Pmalloc: self-test

2018-02-22 Thread Igor Stoppa
On 22/02/18 00:24, Kees Cook wrote: > On Tue, Feb 20, 2018 at 8:40 AM, Igor Stoppa wrote: [...] >> sorry for being dense ... are you proposing that I do something to >> lkdtm_rodata.c ? An example would probably help me understand. > > It would likely live in lkdtm_perms.c (or maybe

Re: [PATCH 5/6] Pmalloc: self-test

2018-02-21 Thread Kees Cook
On Tue, Feb 20, 2018 at 8:40 AM, Igor Stoppa wrote: > > On 13/02/18 01:43, Kees Cook wrote: >> On Mon, Feb 12, 2018 at 8:53 AM, Igor Stoppa wrote: > > [...] > >>> +obj-$(CONFIG_PROTECTABLE_MEMORY_SELFTEST) += pmalloc-selftest.o >> >> Nit: self-test

Re: [PATCH 5/6] Pmalloc: self-test

2018-02-21 Thread Kees Cook
On Tue, Feb 20, 2018 at 8:40 AM, Igor Stoppa wrote: > > On 13/02/18 01:43, Kees Cook wrote: >> On Mon, Feb 12, 2018 at 8:53 AM, Igor Stoppa wrote: > > [...] > >>> +obj-$(CONFIG_PROTECTABLE_MEMORY_SELFTEST) += pmalloc-selftest.o >> >> Nit: self-test modules are traditionally named "test_$thing.o"

Re: [PATCH 5/6] Pmalloc: self-test

2018-02-20 Thread Igor Stoppa
On 13/02/18 01:43, Kees Cook wrote: > On Mon, Feb 12, 2018 at 8:53 AM, Igor Stoppa wrote: [...] >> +obj-$(CONFIG_PROTECTABLE_MEMORY_SELFTEST) += pmalloc-selftest.o > > Nit: self-test modules are traditionally named "test_$thing.o" > (outside of the tools/ directory).

Re: [PATCH 5/6] Pmalloc: self-test

2018-02-20 Thread Igor Stoppa
On 13/02/18 01:43, Kees Cook wrote: > On Mon, Feb 12, 2018 at 8:53 AM, Igor Stoppa wrote: [...] >> +obj-$(CONFIG_PROTECTABLE_MEMORY_SELFTEST) += pmalloc-selftest.o > > Nit: self-test modules are traditionally named "test_$thing.o" > (outside of the tools/ directory). ok [...] > I wonder if

Re: [PATCH 5/6] Pmalloc: self-test

2018-02-12 Thread kbuild test robot
Hi Igor, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc1 next-20180212] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 5/6] Pmalloc: self-test

2018-02-12 Thread kbuild test robot
Hi Igor, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc1 next-20180212] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 5/6] Pmalloc: self-test

2018-02-12 Thread Kees Cook
On Mon, Feb 12, 2018 at 8:53 AM, Igor Stoppa wrote: > Add basic self-test functionality for pmalloc. > > Signed-off-by: Igor Stoppa > --- > mm/Kconfig| 9 > mm/Makefile | 1 + > mm/pmalloc-selftest.c | 64 >

Re: [PATCH 5/6] Pmalloc: self-test

2018-02-12 Thread Kees Cook
On Mon, Feb 12, 2018 at 8:53 AM, Igor Stoppa wrote: > Add basic self-test functionality for pmalloc. > > Signed-off-by: Igor Stoppa > --- > mm/Kconfig| 9 > mm/Makefile | 1 + > mm/pmalloc-selftest.c | 64 > +++ >

Re: [PATCH 5/6] Pmalloc: self-test

2018-02-10 Thread Igor Stoppa
On 07/02/18 19:18, kbuild test robot wrote: > Hi Igor, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on kees/for-next/pstore] > [also build test ERROR on v4.15] > [cannot apply to linus/master mmotm/master next-20180207] > [if your patch is applied to the

Re: [PATCH 5/6] Pmalloc: self-test

2018-02-10 Thread Igor Stoppa
On 07/02/18 19:18, kbuild test robot wrote: > Hi Igor, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on kees/for-next/pstore] > [also build test ERROR on v4.15] > [cannot apply to linus/master mmotm/master next-20180207] > [if your patch is applied to the

Re: [PATCH 5/6] Pmalloc: self-test

2018-02-07 Thread kbuild test robot
Hi Igor, Thank you for the patch! Yet something to improve: [auto build test ERROR on kees/for-next/pstore] [also build test ERROR on v4.15] [cannot apply to linus/master mmotm/master next-20180207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the

Re: [PATCH 5/6] Pmalloc: self-test

2018-02-07 Thread kbuild test robot
Hi Igor, Thank you for the patch! Yet something to improve: [auto build test ERROR on kees/for-next/pstore] [also build test ERROR on v4.15] [cannot apply to linus/master mmotm/master next-20180207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the