Re: [PATCH 5/6] net: dsa: mv88e6060: add register defines header file

2015-11-10 Thread Andrew Lunn
> Is something like this OK ? > /* > * drivers/net/dsa/mv88e6060.h - Marvell 88e6060 switch chip support > * Copyright (c) 2015 Neil Armstrong > * > * Based on mv88e6xxx.h > * Copyright (c) 2008 Marvell Semiconductor > * > * This program is free software; you can redistribute it and/or

Re: [PATCH 5/6] net: dsa: mv88e6060: add register defines header file

2015-11-10 Thread Vivien Didelot
On Nov. Tuesday 10 (46) 03:42 PM, Neil Armstrong wrote: > On 11/10/2015 03:25 PM, Vivien Didelot wrote: > > Hi Neil, > > > > On Nov. Tuesday 10 (46) 02:25 PM, Neil Armstrong wrote: > >> To align with the mv88e6xxx code, add a similar header file > >> with all the register defines. > >> The file

Re: [PATCH 5/6] net: dsa: mv88e6060: add register defines header file

2015-11-10 Thread Neil Armstrong
On 11/10/2015 03:25 PM, Vivien Didelot wrote: > Hi Neil, > > On Nov. Tuesday 10 (46) 02:25 PM, Neil Armstrong wrote: >> To align with the mv88e6xxx code, add a similar header file >> with all the register defines. >> The file is based on the mv88e6xxx header for coherency. >> >> Signed-off-by:

Re: [PATCH 5/6] net: dsa: mv88e6060: add register defines header file

2015-11-10 Thread Vivien Didelot
On Nov. Tuesday 10 (46) 03:30 PM, Andrew Lunn wrote: > On Tue, Nov 10, 2015 at 09:25:51AM -0500, Vivien Didelot wrote: > > Hi Neil, > > > > On Nov. Tuesday 10 (46) 02:25 PM, Neil Armstrong wrote: > > > To align with the mv88e6xxx code, add a similar header file > > > with all the register

Re: [PATCH 5/6] net: dsa: mv88e6060: add register defines header file

2015-11-10 Thread Andrew Lunn
On Tue, Nov 10, 2015 at 09:25:51AM -0500, Vivien Didelot wrote: > Hi Neil, > > On Nov. Tuesday 10 (46) 02:25 PM, Neil Armstrong wrote: > > To align with the mv88e6xxx code, add a similar header file > > with all the register defines. > > The file is based on the mv88e6xxx header for coherency. >

Re: [PATCH 5/6] net: dsa: mv88e6060: add register defines header file

2015-11-10 Thread Vivien Didelot
Hi Neil, On Nov. Tuesday 10 (46) 02:25 PM, Neil Armstrong wrote: > To align with the mv88e6xxx code, add a similar header file > with all the register defines. > The file is based on the mv88e6xxx header for coherency. > > Signed-off-by: Neil Armstrong In the RFC patchset, Andrew mentioned

Re: [PATCH 5/6] net: dsa: mv88e6060: add register defines header file

2015-11-10 Thread Vivien Didelot
On Nov. Tuesday 10 (46) 03:42 PM, Neil Armstrong wrote: > On 11/10/2015 03:25 PM, Vivien Didelot wrote: > > Hi Neil, > > > > On Nov. Tuesday 10 (46) 02:25 PM, Neil Armstrong wrote: > >> To align with the mv88e6xxx code, add a similar header file > >> with all the register defines. > >> The file

Re: [PATCH 5/6] net: dsa: mv88e6060: add register defines header file

2015-11-10 Thread Andrew Lunn
> Is something like this OK ? > /* > * drivers/net/dsa/mv88e6060.h - Marvell 88e6060 switch chip support > * Copyright (c) 2015 Neil Armstrong > * > * Based on mv88e6xxx.h > * Copyright (c) 2008 Marvell Semiconductor > * > * This program is free software; you can redistribute it and/or

Re: [PATCH 5/6] net: dsa: mv88e6060: add register defines header file

2015-11-10 Thread Vivien Didelot
Hi Neil, On Nov. Tuesday 10 (46) 02:25 PM, Neil Armstrong wrote: > To align with the mv88e6xxx code, add a similar header file > with all the register defines. > The file is based on the mv88e6xxx header for coherency. > > Signed-off-by: Neil Armstrong In the RFC

Re: [PATCH 5/6] net: dsa: mv88e6060: add register defines header file

2015-11-10 Thread Andrew Lunn
On Tue, Nov 10, 2015 at 09:25:51AM -0500, Vivien Didelot wrote: > Hi Neil, > > On Nov. Tuesday 10 (46) 02:25 PM, Neil Armstrong wrote: > > To align with the mv88e6xxx code, add a similar header file > > with all the register defines. > > The file is based on the mv88e6xxx header for coherency. >

Re: [PATCH 5/6] net: dsa: mv88e6060: add register defines header file

2015-11-10 Thread Vivien Didelot
On Nov. Tuesday 10 (46) 03:30 PM, Andrew Lunn wrote: > On Tue, Nov 10, 2015 at 09:25:51AM -0500, Vivien Didelot wrote: > > Hi Neil, > > > > On Nov. Tuesday 10 (46) 02:25 PM, Neil Armstrong wrote: > > > To align with the mv88e6xxx code, add a similar header file > > > with all the register

Re: [PATCH 5/6] net: dsa: mv88e6060: add register defines header file

2015-11-10 Thread Neil Armstrong
On 11/10/2015 03:25 PM, Vivien Didelot wrote: > Hi Neil, > > On Nov. Tuesday 10 (46) 02:25 PM, Neil Armstrong wrote: >> To align with the mv88e6xxx code, add a similar header file >> with all the register defines. >> The file is based on the mv88e6xxx header for coherency. >> >> Signed-off-by: