Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier
On Sat, Nov 10, 2018 at 11:23 AM Fabio Estevam wrote:> > Hi Matheus, > > On Fri, Nov 9, 2018 at 10:27 PM Matheus Tavares Bernardino > wrote: > > > Got it, thanks for the explanation! I'll correct this in v2. > > One more suggestion: in v2 you could also consider to remove the legal > text that says GPL v2, as you are adding the SPDX tag. Okay, I'll do it! Thanks again for the review and suggestions! Matheus
Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier
On Sat, Nov 10, 2018 at 11:23 AM Fabio Estevam wrote:> > Hi Matheus, > > On Fri, Nov 9, 2018 at 10:27 PM Matheus Tavares Bernardino > wrote: > > > Got it, thanks for the explanation! I'll correct this in v2. > > One more suggestion: in v2 you could also consider to remove the legal > text that says GPL v2, as you are adding the SPDX tag. Okay, I'll do it! Thanks again for the review and suggestions! Matheus
Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier
Hi Matheus, On Fri, Nov 9, 2018 at 10:27 PM Matheus Tavares Bernardino wrote: > Got it, thanks for the explanation! I'll correct this in v2. One more suggestion: in v2 you could also consider to remove the legal text that says GPL v2, as you are adding the SPDX tag.
Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier
Hi Matheus, On Fri, Nov 9, 2018 at 10:27 PM Matheus Tavares Bernardino wrote: > Got it, thanks for the explanation! I'll correct this in v2. One more suggestion: in v2 you could also consider to remove the legal text that says GPL v2, as you are adding the SPDX tag.
Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier
On Fri, Nov 9, 2018 at 10:20 PM Greg Kroah-Hartman wrote: > > On Fri, Nov 09, 2018 at 09:19:52PM -0200, Matheus Tavares Bernardino wrote: > > On Fri, Nov 9, 2018 at 8:13 PM Fabio Estevam wrote: > > > > > > Hi Matheus, > > > > > > > Hi, Fabio > > > > > On Fri, Nov 9, 2018 at 8:01 PM Matheus Tavares > > > wrote: > > > > > > > > This patch adds the SPDX GPL-2.0-only license identifier to ad2s90.c, > > > > which solves the checkpatch.pl warning: > > > > "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". > > > > > > > > Signed-off-by: Matheus Tavares > > > > --- > > > > drivers/staging/iio/resolver/ad2s90.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/staging/iio/resolver/ad2s90.c > > > > b/drivers/staging/iio/resolver/ad2s90.c > > > > index 949ff55ac6b0..f439da721df8 100644 > > > > --- a/drivers/staging/iio/resolver/ad2s90.c > > > > +++ b/drivers/staging/iio/resolver/ad2s90.c > > > > @@ -1,3 +1,4 @@ > > > > +// SPDX-License-Identifier: GPL-2.0-only > > > > > > This should be: > > > // SPDX-License-Identifier: GPL-2.0 > > > > Hm, but it seems that the identifier "GPL-2.0" is deprecated, look: > > https://spdx.org/licenses/GPL-2.0.html. It has been updated to > > "GPL-2.0-only" in license list v3 > > (https://spdx.org/licenses/GPL-2.0-only.html). Is there some other > > reason to use the deprecated "GPL-2.0" that I'm not aware of? > > Yes, please read the in-kernel documentation for all of this at: > Documentation/process/license-rules.rst > > Long story short, we started the adding of these tags to the kernel > before the crazyness of the "-only" markings for GPL in spdx. Let's > keep it this way for now, if we ever get the whole kernel finished, then > we can revisit the markings and maybe do a wholesale conversion, if it's > really needed. > Got it, thanks for the explanation! I'll correct this in v2. Thanks, Matheus > thanks, > > greg k-h
Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier
On Fri, Nov 9, 2018 at 10:20 PM Greg Kroah-Hartman wrote: > > On Fri, Nov 09, 2018 at 09:19:52PM -0200, Matheus Tavares Bernardino wrote: > > On Fri, Nov 9, 2018 at 8:13 PM Fabio Estevam wrote: > > > > > > Hi Matheus, > > > > > > > Hi, Fabio > > > > > On Fri, Nov 9, 2018 at 8:01 PM Matheus Tavares > > > wrote: > > > > > > > > This patch adds the SPDX GPL-2.0-only license identifier to ad2s90.c, > > > > which solves the checkpatch.pl warning: > > > > "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". > > > > > > > > Signed-off-by: Matheus Tavares > > > > --- > > > > drivers/staging/iio/resolver/ad2s90.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/staging/iio/resolver/ad2s90.c > > > > b/drivers/staging/iio/resolver/ad2s90.c > > > > index 949ff55ac6b0..f439da721df8 100644 > > > > --- a/drivers/staging/iio/resolver/ad2s90.c > > > > +++ b/drivers/staging/iio/resolver/ad2s90.c > > > > @@ -1,3 +1,4 @@ > > > > +// SPDX-License-Identifier: GPL-2.0-only > > > > > > This should be: > > > // SPDX-License-Identifier: GPL-2.0 > > > > Hm, but it seems that the identifier "GPL-2.0" is deprecated, look: > > https://spdx.org/licenses/GPL-2.0.html. It has been updated to > > "GPL-2.0-only" in license list v3 > > (https://spdx.org/licenses/GPL-2.0-only.html). Is there some other > > reason to use the deprecated "GPL-2.0" that I'm not aware of? > > Yes, please read the in-kernel documentation for all of this at: > Documentation/process/license-rules.rst > > Long story short, we started the adding of these tags to the kernel > before the crazyness of the "-only" markings for GPL in spdx. Let's > keep it this way for now, if we ever get the whole kernel finished, then > we can revisit the markings and maybe do a wholesale conversion, if it's > really needed. > Got it, thanks for the explanation! I'll correct this in v2. Thanks, Matheus > thanks, > > greg k-h
Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier
On Fri, Nov 09, 2018 at 09:19:52PM -0200, Matheus Tavares Bernardino wrote: > On Fri, Nov 9, 2018 at 8:13 PM Fabio Estevam wrote: > > > > Hi Matheus, > > > > Hi, Fabio > > > On Fri, Nov 9, 2018 at 8:01 PM Matheus Tavares > > wrote: > > > > > > This patch adds the SPDX GPL-2.0-only license identifier to ad2s90.c, > > > which solves the checkpatch.pl warning: > > > "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". > > > > > > Signed-off-by: Matheus Tavares > > > --- > > > drivers/staging/iio/resolver/ad2s90.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/staging/iio/resolver/ad2s90.c > > > b/drivers/staging/iio/resolver/ad2s90.c > > > index 949ff55ac6b0..f439da721df8 100644 > > > --- a/drivers/staging/iio/resolver/ad2s90.c > > > +++ b/drivers/staging/iio/resolver/ad2s90.c > > > @@ -1,3 +1,4 @@ > > > +// SPDX-License-Identifier: GPL-2.0-only > > > > This should be: > > // SPDX-License-Identifier: GPL-2.0 > > Hm, but it seems that the identifier "GPL-2.0" is deprecated, look: > https://spdx.org/licenses/GPL-2.0.html. It has been updated to > "GPL-2.0-only" in license list v3 > (https://spdx.org/licenses/GPL-2.0-only.html). Is there some other > reason to use the deprecated "GPL-2.0" that I'm not aware of? Yes, please read the in-kernel documentation for all of this at: Documentation/process/license-rules.rst Long story short, we started the adding of these tags to the kernel before the crazyness of the "-only" markings for GPL in spdx. Let's keep it this way for now, if we ever get the whole kernel finished, then we can revisit the markings and maybe do a wholesale conversion, if it's really needed. thanks, greg k-h
Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier
On Fri, Nov 09, 2018 at 09:19:52PM -0200, Matheus Tavares Bernardino wrote: > On Fri, Nov 9, 2018 at 8:13 PM Fabio Estevam wrote: > > > > Hi Matheus, > > > > Hi, Fabio > > > On Fri, Nov 9, 2018 at 8:01 PM Matheus Tavares > > wrote: > > > > > > This patch adds the SPDX GPL-2.0-only license identifier to ad2s90.c, > > > which solves the checkpatch.pl warning: > > > "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". > > > > > > Signed-off-by: Matheus Tavares > > > --- > > > drivers/staging/iio/resolver/ad2s90.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/staging/iio/resolver/ad2s90.c > > > b/drivers/staging/iio/resolver/ad2s90.c > > > index 949ff55ac6b0..f439da721df8 100644 > > > --- a/drivers/staging/iio/resolver/ad2s90.c > > > +++ b/drivers/staging/iio/resolver/ad2s90.c > > > @@ -1,3 +1,4 @@ > > > +// SPDX-License-Identifier: GPL-2.0-only > > > > This should be: > > // SPDX-License-Identifier: GPL-2.0 > > Hm, but it seems that the identifier "GPL-2.0" is deprecated, look: > https://spdx.org/licenses/GPL-2.0.html. It has been updated to > "GPL-2.0-only" in license list v3 > (https://spdx.org/licenses/GPL-2.0-only.html). Is there some other > reason to use the deprecated "GPL-2.0" that I'm not aware of? Yes, please read the in-kernel documentation for all of this at: Documentation/process/license-rules.rst Long story short, we started the adding of these tags to the kernel before the crazyness of the "-only" markings for GPL in spdx. Let's keep it this way for now, if we ever get the whole kernel finished, then we can revisit the markings and maybe do a wholesale conversion, if it's really needed. thanks, greg k-h
Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier
On Fri, Nov 9, 2018 at 8:13 PM Fabio Estevam wrote: > > Hi Matheus, > Hi, Fabio > On Fri, Nov 9, 2018 at 8:01 PM Matheus Tavares > wrote: > > > > This patch adds the SPDX GPL-2.0-only license identifier to ad2s90.c, > > which solves the checkpatch.pl warning: > > "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". > > > > Signed-off-by: Matheus Tavares > > --- > > drivers/staging/iio/resolver/ad2s90.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/iio/resolver/ad2s90.c > > b/drivers/staging/iio/resolver/ad2s90.c > > index 949ff55ac6b0..f439da721df8 100644 > > --- a/drivers/staging/iio/resolver/ad2s90.c > > +++ b/drivers/staging/iio/resolver/ad2s90.c > > @@ -1,3 +1,4 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > This should be: > // SPDX-License-Identifier: GPL-2.0 Hm, but it seems that the identifier "GPL-2.0" is deprecated, look: https://spdx.org/licenses/GPL-2.0.html. It has been updated to "GPL-2.0-only" in license list v3 (https://spdx.org/licenses/GPL-2.0-only.html). Is there some other reason to use the deprecated "GPL-2.0" that I'm not aware of? Thanks, Matheus
Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier
On Fri, Nov 9, 2018 at 8:13 PM Fabio Estevam wrote: > > Hi Matheus, > Hi, Fabio > On Fri, Nov 9, 2018 at 8:01 PM Matheus Tavares > wrote: > > > > This patch adds the SPDX GPL-2.0-only license identifier to ad2s90.c, > > which solves the checkpatch.pl warning: > > "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". > > > > Signed-off-by: Matheus Tavares > > --- > > drivers/staging/iio/resolver/ad2s90.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/iio/resolver/ad2s90.c > > b/drivers/staging/iio/resolver/ad2s90.c > > index 949ff55ac6b0..f439da721df8 100644 > > --- a/drivers/staging/iio/resolver/ad2s90.c > > +++ b/drivers/staging/iio/resolver/ad2s90.c > > @@ -1,3 +1,4 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > This should be: > // SPDX-License-Identifier: GPL-2.0 Hm, but it seems that the identifier "GPL-2.0" is deprecated, look: https://spdx.org/licenses/GPL-2.0.html. It has been updated to "GPL-2.0-only" in license list v3 (https://spdx.org/licenses/GPL-2.0-only.html). Is there some other reason to use the deprecated "GPL-2.0" that I'm not aware of? Thanks, Matheus
Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier
Hi Matheus, On Fri, Nov 9, 2018 at 8:01 PM Matheus Tavares wrote: > > This patch adds the SPDX GPL-2.0-only license identifier to ad2s90.c, > which solves the checkpatch.pl warning: > "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". > > Signed-off-by: Matheus Tavares > --- > drivers/staging/iio/resolver/ad2s90.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/iio/resolver/ad2s90.c > b/drivers/staging/iio/resolver/ad2s90.c > index 949ff55ac6b0..f439da721df8 100644 > --- a/drivers/staging/iio/resolver/ad2s90.c > +++ b/drivers/staging/iio/resolver/ad2s90.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0-only This should be: // SPDX-License-Identifier: GPL-2.0
Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier
Hi Matheus, On Fri, Nov 9, 2018 at 8:01 PM Matheus Tavares wrote: > > This patch adds the SPDX GPL-2.0-only license identifier to ad2s90.c, > which solves the checkpatch.pl warning: > "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". > > Signed-off-by: Matheus Tavares > --- > drivers/staging/iio/resolver/ad2s90.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/iio/resolver/ad2s90.c > b/drivers/staging/iio/resolver/ad2s90.c > index 949ff55ac6b0..f439da721df8 100644 > --- a/drivers/staging/iio/resolver/ad2s90.c > +++ b/drivers/staging/iio/resolver/ad2s90.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0-only This should be: // SPDX-License-Identifier: GPL-2.0
