Re: [PATCH 6/6] GPU-DRM-GMA500: Rename a jump label in mid_get_vbt_data()

2016-09-20 Thread Dan Carpenter
On Tue, Sep 20, 2016 at 01:08:12PM +0300, Jani Nikula wrote: > On Tue, 20 Sep 2016, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Tue, 20 Sep 2016 10:40:22 +0200 > > > > * Adjust a jump target. > > Please don't. >

Re: [PATCH 6/6] GPU-DRM-GMA500: Rename a jump label in mid_get_vbt_data()

2016-09-20 Thread Dan Carpenter
On Tue, Sep 20, 2016 at 01:08:12PM +0300, Jani Nikula wrote: > On Tue, 20 Sep 2016, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Tue, 20 Sep 2016 10:40:22 +0200 > > > > * Adjust a jump target. > > Please don't. > Also there is nothing in CodingStyle that prohibits out: labels.

Re: [PATCH 6/6] GPU-DRM-GMA500: Rename a jump label in mid_get_vbt_data()

2016-09-20 Thread Jani Nikula
On Tue, 20 Sep 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 20 Sep 2016 10:40:22 +0200 > > * Adjust a jump target. Please don't. BR, Jani. > > * Delete the explicit initialisation for the local variable "ret"

Re: [PATCH 6/6] GPU-DRM-GMA500: Rename a jump label in mid_get_vbt_data()

2016-09-20 Thread Jani Nikula
On Tue, 20 Sep 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 20 Sep 2016 10:40:22 +0200 > > * Adjust a jump target. Please don't. BR, Jani. > > * Delete the explicit initialisation for the local variable "ret" > which became unnecessary with this refactoring. > >