Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

On 08/03/18 15:56, Bart Van Assche wrote: On Thu, 2018-03-08 at 07:59 +, Tvrtko Ursulin wrote: However there is a different bug in my patch relating to the last entry which can have shorter length from the rest. So get_order on the last entry is incorrect - I have to store the deduced

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

On 08/03/18 15:56, Bart Van Assche wrote: On Thu, 2018-03-08 at 07:59 +, Tvrtko Ursulin wrote: However there is a different bug in my patch relating to the last entry which can have shorter length from the rest. So get_order on the last entry is incorrect - I have to store the deduced

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

On Thu, 2018-03-08 at 07:59 +, Tvrtko Ursulin wrote: > However there is a different bug in my patch relating to the last entry > which can have shorter length from the rest. So get_order on the last > entry is incorrect - I have to store the deduced order and carry it over. Will that work

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

On Thu, 2018-03-08 at 07:59 +, Tvrtko Ursulin wrote: > However there is a different bug in my patch relating to the last entry > which can have shorter length from the rest. So get_order on the last > entry is incorrect - I have to store the deduced order and carry it over. Will that work

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

Hi, On 07/03/18 18:30, James Bottomley wrote: On Wed, 2018-03-07 at 12:47 +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Firstly, I don't see any justifiable benefit to churning this API, so why bother? but secondly this: Primarily because I wanted to extend

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

Hi, On 07/03/18 18:30, James Bottomley wrote: On Wed, 2018-03-07 at 12:47 +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Firstly, I don't see any justifiable benefit to churning this API, so why bother? but secondly this: Primarily because I wanted to extend sgl_alloc_order slightly in

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

On Wed, 2018-03-07 at 12:47 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin Firstly, I don't see any justifiable benefit to churning this API, so why bother? but secondly this: > We can derive the order from sg->length and so do not need to pass it > in explicitly.

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

On Wed, 2018-03-07 at 12:47 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin Firstly, I don't see any justifiable benefit to churning this API, so why bother? but secondly this: > We can derive the order from sg->length and so do not need to pass it > in explicitly. Is wrong.  I can have a

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

On Wed, 2018-03-07 at 17:23 +, Tvrtko Ursulin wrote: > Ok I guess my main questions are the ones from the cover letter - where > is this API going and why did it get in a bit of a funky state? Because > it doesn't look fully thought through and tested to me. Funky state? Not fully tested?

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

On Wed, 2018-03-07 at 17:23 +, Tvrtko Ursulin wrote: > Ok I guess my main questions are the ones from the cover letter - where > is this API going and why did it get in a bit of a funky state? Because > it doesn't look fully thought through and tested to me. Funky state? Not fully tested?

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

On 07/03/18 16:23, Bart Van Assche wrote: On Wed, 2018-03-07 at 12:47 +, Tvrtko Ursulin wrote: We can derive the order from sg->length and so do not need to pass it in explicitly. Rename the function to sgl_free_n. Using get_order() to compute the order looks fine to me but this patch

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

On 07/03/18 16:23, Bart Van Assche wrote: On Wed, 2018-03-07 at 12:47 +, Tvrtko Ursulin wrote: We can derive the order from sg->length and so do not need to pass it in explicitly. Rename the function to sgl_free_n. Using get_order() to compute the order looks fine to me but this patch

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

On Wed, 2018-03-07 at 12:47 +, Tvrtko Ursulin wrote: > We can derive the order from sg->length and so do not need to pass it in > explicitly. Rename the function to sgl_free_n. Using get_order() to compute the order looks fine to me but this patch will have to rebased in order to address the

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

On Wed, 2018-03-07 at 12:47 +, Tvrtko Ursulin wrote: > We can derive the order from sg->length and so do not need to pass it in > explicitly. Rename the function to sgl_free_n. Using get_order() to compute the order looks fine to me but this patch will have to rebased in order to address the