Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-02-13 Thread Felipe Balbi
On Fri, Feb 13, 2015 at 02:03:45PM -0800, David Cohen wrote: > Hi Heikki, > > On Fri, Feb 13, 2015 at 03:16:40PM +0200, Heikki Krogerus wrote: > > On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote: > > > On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: > > > > > > diff

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-02-13 Thread David Cohen
Hi Heikki, On Fri, Feb 13, 2015 at 03:16:40PM +0200, Heikki Krogerus wrote: > On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote: > > On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: > > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > > > index

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-02-13 Thread Heikki Krogerus
On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote: > On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > > index a8c9062..66cbf38 100644 > > > > --- a/drivers/usb/dwc3/core.c > > > > +++

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-02-13 Thread Heikki Krogerus
On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote: On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index a8c9062..66cbf38 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-02-13 Thread Felipe Balbi
On Fri, Feb 13, 2015 at 02:03:45PM -0800, David Cohen wrote: Hi Heikki, On Fri, Feb 13, 2015 at 03:16:40PM +0200, Heikki Krogerus wrote: On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote: On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: diff --git

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-02-13 Thread David Cohen
Hi Heikki, On Fri, Feb 13, 2015 at 03:16:40PM +0200, Heikki Krogerus wrote: On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote: On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-02-12 Thread David Cohen
On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote: > On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > > index a8c9062..66cbf38 100644 > > > > --- a/drivers/usb/dwc3/core.c > > > > +++

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-02-12 Thread David Cohen
On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > index a8c9062..66cbf38 100644 > > > --- a/drivers/usb/dwc3/core.c > > > +++ b/drivers/usb/dwc3/core.c > > > @@ -879,6 +879,10 @@ static int dwc3_probe(struct

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-02-12 Thread Heikki Krogerus
> > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > index a8c9062..66cbf38 100644 > > --- a/drivers/usb/dwc3/core.c > > +++ b/drivers/usb/dwc3/core.c > > @@ -879,6 +879,10 @@ static int dwc3_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, dwc); > >

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-02-12 Thread Heikki Krogerus
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index a8c9062..66cbf38 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -879,6 +879,10 @@ static int dwc3_probe(struct platform_device *pdev) platform_set_drvdata(pdev, dwc);

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-02-12 Thread David Cohen
On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index a8c9062..66cbf38 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -879,6 +879,10 @@ static int dwc3_probe(struct platform_device

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-02-12 Thread David Cohen
On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote: On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index a8c9062..66cbf38 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-02-11 Thread David Cohen
Hi Heikki, On Fri, Jan 23, 2015 at 05:12:56PM +0200, Heikki Krogerus wrote: > Registers DWC3's ULPI interface with the ULPI bus when it's > available. > > Signed-off-by: Heikki Krogerus > --- > drivers/usb/dwc3/Kconfig | 7 +++ > drivers/usb/dwc3/Makefile | 4 ++ > drivers/usb/dwc3/core.c

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-02-11 Thread David Cohen
Hi Heikki, On Fri, Jan 23, 2015 at 05:12:56PM +0200, Heikki Krogerus wrote: Registers DWC3's ULPI interface with the ULPI bus when it's available. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com --- drivers/usb/dwc3/Kconfig | 7 +++ drivers/usb/dwc3/Makefile | 4 ++

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-01-27 Thread Felipe Balbi
On Tue, Jan 27, 2015 at 01:09:25PM +0200, Heikki Krogerus wrote: > > look at your patch again. In case DWC3_ULPI isn't enabled, this file > > won't be linked at all. You're using stubs, so taht's fine. > > > > In case it _is_ enabled, you're breaking out early if you can't register > > ulpi

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-01-27 Thread Heikki Krogerus
> look at your patch again. In case DWC3_ULPI isn't enabled, this file > won't be linked at all. You're using stubs, so taht's fine. > > In case it _is_ enabled, you're breaking out early if you can't register > ulpi interface, meaning you're exitting probe() (which, in fact, seems > wrong as I

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-01-27 Thread Heikki Krogerus
look at your patch again. In case DWC3_ULPI isn't enabled, this file won't be linked at all. You're using stubs, so taht's fine. In case it _is_ enabled, you're breaking out early if you can't register ulpi interface, meaning you're exitting probe() (which, in fact, seems wrong as I want to

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-01-27 Thread Felipe Balbi
On Tue, Jan 27, 2015 at 01:09:25PM +0200, Heikki Krogerus wrote: look at your patch again. In case DWC3_ULPI isn't enabled, this file won't be linked at all. You're using stubs, so taht's fine. In case it _is_ enabled, you're breaking out early if you can't register ulpi interface,

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-01-26 Thread Felipe Balbi
On Mon, Jan 26, 2015 at 01:46:10PM +0200, Heikki Krogerus wrote: > On Fri, Jan 23, 2015 at 10:24:43AM -0600, Felipe Balbi wrote: > > On Fri, Jan 23, 2015 at 05:12:56PM +0200, Heikki Krogerus wrote: > > > +int dwc3_ulpi_init(struct dwc3 *dwc) > > > +{ > > > + u32 reg; > > > + > > > + /* First check

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-01-26 Thread Heikki Krogerus
On Fri, Jan 23, 2015 at 10:24:43AM -0600, Felipe Balbi wrote: > On Fri, Jan 23, 2015 at 05:12:56PM +0200, Heikki Krogerus wrote: > > +int dwc3_ulpi_init(struct dwc3 *dwc) > > +{ > > + u32 reg; > > + > > + /* First check USB2 PHY interface type */ > > + switch

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-01-26 Thread Felipe Balbi
On Mon, Jan 26, 2015 at 01:46:10PM +0200, Heikki Krogerus wrote: On Fri, Jan 23, 2015 at 10:24:43AM -0600, Felipe Balbi wrote: On Fri, Jan 23, 2015 at 05:12:56PM +0200, Heikki Krogerus wrote: +int dwc3_ulpi_init(struct dwc3 *dwc) +{ + u32 reg; + + /* First check USB2 PHY

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-01-26 Thread Heikki Krogerus
On Fri, Jan 23, 2015 at 10:24:43AM -0600, Felipe Balbi wrote: On Fri, Jan 23, 2015 at 05:12:56PM +0200, Heikki Krogerus wrote: +int dwc3_ulpi_init(struct dwc3 *dwc) +{ + u32 reg; + + /* First check USB2 PHY interface type */ + switch

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-01-23 Thread Felipe Balbi
Hi, On Fri, Jan 23, 2015 at 05:12:56PM +0200, Heikki Krogerus wrote: > +int dwc3_ulpi_init(struct dwc3 *dwc) > +{ > + u32 reg; > + > + /* First check USB2 PHY interface type */ > + switch (DWC3_GHWPARAMS3_HSPHY_IFC(dwc->hwparams.hwparams3)) { > + case

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-01-23 Thread Felipe Balbi
Hi, On Fri, Jan 23, 2015 at 05:12:56PM +0200, Heikki Krogerus wrote: +int dwc3_ulpi_init(struct dwc3 *dwc) +{ + u32 reg; + + /* First check USB2 PHY interface type */ + switch (DWC3_GHWPARAMS3_HSPHY_IFC(dwc-hwparams.hwparams3)) { + case DWC3_GHWPARAMS3_HSPHY_IFC_UTMI_ULPI: