Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Ulf, On 2016/11/29 19:11, Ulf Hansson wrote: > [...] > > Sorry that I didn't make myself clear. Our host PHY delay line consists of hundreds of sampling points. Each sampling point represents a different phase shift. In lower speed mode, our

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Ulf, On 2016/11/29 19:11, Ulf Hansson wrote: > [...] > > Sorry that I didn't make myself clear. Our host PHY delay line consists of hundreds of sampling points. Each sampling point represents a different phase shift. In lower speed mode, our

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

[...] >>> >>>Sorry that I didn't make myself clear. >>> >>>Our host PHY delay line consists of hundreds of sampling points. >>>Each sampling point represents a different phase shift. >>> >>>In lower speed mode, our host driver will scan the delay line. >>>It will select

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

[...] >>> >>>Sorry that I didn't make myself clear. >>> >>>Our host PHY delay line consists of hundreds of sampling points. >>>Each sampling point represents a different phase shift. >>> >>>In lower speed mode, our host driver will scan the delay line. >>>It will select

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Ulf, On 2016/11/29 15:49, Ulf Hansson wrote: > On 29 November 2016 at 03:53, Ziji Hu wrote: >> Hi Ulf, >> >> On 2016/11/28 23:16, Ulf Hansson wrote: >>> On 28 November 2016 at 12:38, Ziji Hu wrote: Hi Ulf, On 2016/11/28 19:13, Ulf

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Ulf, On 2016/11/29 15:49, Ulf Hansson wrote: > On 29 November 2016 at 03:53, Ziji Hu wrote: >> Hi Ulf, >> >> On 2016/11/28 23:16, Ulf Hansson wrote: >>> On 28 November 2016 at 12:38, Ziji Hu wrote: Hi Ulf, On 2016/11/28 19:13, Ulf Hansson wrote: >> >> As you

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

On 29 November 2016 at 03:53, Ziji Hu wrote: > Hi Ulf, > > On 2016/11/28 23:16, Ulf Hansson wrote: >> On 28 November 2016 at 12:38, Ziji Hu wrote: >>> Hi Ulf, >>> >>> On 2016/11/28 19:13, Ulf Hansson wrote: > > As you suggest, I replace

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

On 29 November 2016 at 03:53, Ziji Hu wrote: > Hi Ulf, > > On 2016/11/28 23:16, Ulf Hansson wrote: >> On 28 November 2016 at 12:38, Ziji Hu wrote: >>> Hi Ulf, >>> >>> On 2016/11/28 19:13, Ulf Hansson wrote: > > As you suggest, I replace mmc_wait_for_cmd() with mmc_send_tuning(),

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Ulf, On 2016/11/28 23:16, Ulf Hansson wrote: > On 28 November 2016 at 12:38, Ziji Hu wrote: >> Hi Ulf, >> >> On 2016/11/28 19:13, Ulf Hansson wrote: As you suggest, I replace mmc_wait_for_cmd() with mmc_send_tuning(), to send commands for testing

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Ulf, On 2016/11/28 23:16, Ulf Hansson wrote: > On 28 November 2016 at 12:38, Ziji Hu wrote: >> Hi Ulf, >> >> On 2016/11/28 19:13, Ulf Hansson wrote: As you suggest, I replace mmc_wait_for_cmd() with mmc_send_tuning(), to send commands for testing current sampling point

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

On 28 November 2016 at 12:38, Ziji Hu wrote: > Hi Ulf, > > On 2016/11/28 19:13, Ulf Hansson wrote: >>> >>> As you suggest, I replace mmc_wait_for_cmd() with mmc_send_tuning(), to >>> send commands for testing current sampling point set in our host PHY. >>> >>>

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

On 28 November 2016 at 12:38, Ziji Hu wrote: > Hi Ulf, > > On 2016/11/28 19:13, Ulf Hansson wrote: >>> >>> As you suggest, I replace mmc_wait_for_cmd() with mmc_send_tuning(), to >>> send commands for testing current sampling point set in our host PHY. >>> >>> According to my test

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Ulf, On 2016/11/28 19:13, Ulf Hansson wrote: >> >> As you suggest, I replace mmc_wait_for_cmd() with mmc_send_tuning(), to >> send commands for testing current sampling point set in our host PHY. >> >> According to my test result, it shows that mmc_send_tuning() can only >>

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Ulf, On 2016/11/28 19:13, Ulf Hansson wrote: >> >> As you suggest, I replace mmc_wait_for_cmd() with mmc_send_tuning(), to >> send commands for testing current sampling point set in our host PHY. >> >> According to my test result, it shows that mmc_send_tuning() can only >>

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

> > As you suggest, I replace mmc_wait_for_cmd() with mmc_send_tuning(), to > send commands for testing current sampling point set in our host PHY. > > According to my test result, it shows that mmc_send_tuning() can only > support > tuning command (CMD21/CMD19). > As a

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

> > As you suggest, I replace mmc_wait_for_cmd() with mmc_send_tuning(), to > send commands for testing current sampling point set in our host PHY. > > According to my test result, it shows that mmc_send_tuning() can only > support > tuning command (CMD21/CMD19). > As a

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

[...] > > Could you please tell me the requirement of "op_code" parameter in > mmc_send_tuning()? > According to mmc_send_tuning(),it seems that tuning command(CMD19/CMD21) > is required. Thus device will not response mmc_send_tuning() if current > speed mode doesn't support

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

[...] > > Could you please tell me the requirement of "op_code" parameter in > mmc_send_tuning()? > According to mmc_send_tuning(),it seems that tuning command(CMD19/CMD21) > is required. Thus device will not response mmc_send_tuning() if current > speed mode doesn't support

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Ulf, On 2016/11/24 23:37, Ziji Hu wrote: > Hi Ulf, > > On 2016/11/24 22:33, Ulf Hansson wrote: >>> >>>As result, our SDHC driver has to implement the functionality to >>>send commands and check the results, in host layer. >>>If directly calling mmc_wait_for_cmd() is improper,

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Ulf, On 2016/11/24 23:37, Ziji Hu wrote: > Hi Ulf, > > On 2016/11/24 22:33, Ulf Hansson wrote: >>> >>>As result, our SDHC driver has to implement the functionality to >>>send commands and check the results, in host layer. >>>If directly calling mmc_wait_for_cmd() is improper,

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Ulf, On 2016/11/24 22:33, Ulf Hansson wrote: > [...] > >>> + +static int __xenon_emmc_delay_adj_test(struct mmc_card *card) +{ + int err; + u8 *ext_csd = NULL; + + err = mmc_get_ext_csd(card, _csd); + kfree(ext_csd); >>> >>>

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Ulf, On 2016/11/24 22:33, Ulf Hansson wrote: > [...] > >>> + +static int __xenon_emmc_delay_adj_test(struct mmc_card *card) +{ + int err; + u8 *ext_csd = NULL; + + err = mmc_get_ext_csd(card, _csd); + kfree(ext_csd); >>> >>>

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

[...] >> >>> >>> + >>> +static int __xenon_emmc_delay_adj_test(struct mmc_card *card) >>> +{ >>> + int err; >>> + u8 *ext_csd = NULL; >>> + >>> + err = mmc_get_ext_csd(card, _csd); >>> + kfree(ext_csd); >> >> Why do you read the ext csd here? >> >I would like to simply

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

[...] >> >>> >>> + >>> +static int __xenon_emmc_delay_adj_test(struct mmc_card *card) >>> +{ >>> + int err; >>> + u8 *ext_csd = NULL; >>> + >>> + err = mmc_get_ext_csd(card, _csd); >>> + kfree(ext_csd); >> >> Why do you read the ext csd here? >> >I would like to simply

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Ulf, Thanks a lot for the review. On 2016/11/24 19:37, Ulf Hansson wrote: > On 31 October 2016 at 12:09, Gregory CLEMENT > wrote: >> From: Ziji Hu >> >> Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. >> Three types of PHYs

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Ulf, Thanks a lot for the review. On 2016/11/24 19:37, Ulf Hansson wrote: > On 31 October 2016 at 12:09, Gregory CLEMENT > wrote: >> From: Ziji Hu >> >> Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. >> Three types of PHYs are supported. >> >> Add support to multiple types of

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

On 31 October 2016 at 12:09, Gregory CLEMENT wrote: > From: Ziji Hu > > Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. > Three types of PHYs are supported. > > Add support to multiple types of PHYs init and configuration. > Add

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

On 31 October 2016 at 12:09, Gregory CLEMENT wrote: > From: Ziji Hu > > Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. > Three types of PHYs are supported. > > Add support to multiple types of PHYs init and configuration. > Add register definitions of PHYs. > > Signed-off-by: Hu Ziji

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

On Thursday, November 24, 2016 6:57:18 PM CET Ziji Hu wrote: > > > > Please explain in the changelog why this is not a generic > > phy driver (or three of them). > > > Actually we tried to put the PHY code into Linux PHY framework. > But it cannot fit in Linux common PHY

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

On Thursday, November 24, 2016 6:57:18 PM CET Ziji Hu wrote: > > > > Please explain in the changelog why this is not a generic > > phy driver (or three of them). > > > Actually we tried to put the PHY code into Linux PHY framework. > But it cannot fit in Linux common PHY

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Arnd, On 2016/11/24 17:56, Arnd Bergmann wrote: > On Monday, October 31, 2016 12:09:56 PM CET Gregory CLEMENT wrote: >> From: Ziji Hu >> >> Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. >> Three types of PHYs are supported. >> >> Add support to multiple types of

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Arnd, On 2016/11/24 17:56, Arnd Bergmann wrote: > On Monday, October 31, 2016 12:09:56 PM CET Gregory CLEMENT wrote: >> From: Ziji Hu >> >> Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. >> Three types of PHYs are supported. >> >> Add support to multiple types of PHYs init and

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

On Monday, October 31, 2016 12:09:56 PM CET Gregory CLEMENT wrote: > From: Ziji Hu > > Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. > Three types of PHYs are supported. > > Add support to multiple types of PHYs init and configuration. > Add register definitions

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

On Monday, October 31, 2016 12:09:56 PM CET Gregory CLEMENT wrote: > From: Ziji Hu > > Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. > Three types of PHYs are supported. > > Add support to multiple types of PHYs init and configuration. > Add register definitions of PHYs. > >

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

On 18/10/16 15:04, Ziji Hu wrote: > Hi Adrian, > > On 2016/10/17 15:55, Adrian Hunter wrote: >> On 12/10/16 15:17, Ziji Hu wrote: >>> Hi Adrian, >>> >>> On 2016/10/11 20:39, Adrian Hunter wrote: > > +static int __xenon_emmc_delay_adj_test(struct mmc_card *card) > +{ > + int err;

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

On 18/10/16 15:04, Ziji Hu wrote: > Hi Adrian, > > On 2016/10/17 15:55, Adrian Hunter wrote: >> On 12/10/16 15:17, Ziji Hu wrote: >>> Hi Adrian, >>> >>> On 2016/10/11 20:39, Adrian Hunter wrote: > > +static int __xenon_emmc_delay_adj_test(struct mmc_card *card) > +{ > + int err;

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Adrian, On 2016/10/17 15:55, Adrian Hunter wrote: > On 12/10/16 15:17, Ziji Hu wrote: >> Hi Adrian, >> >> On 2016/10/11 20:39, Adrian Hunter wrote: +static int __xenon_emmc_delay_adj_test(struct mmc_card *card) +{ + int err; + u8 *ext_csd = NULL; + + err =

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Adrian, On 2016/10/17 15:55, Adrian Hunter wrote: > On 12/10/16 15:17, Ziji Hu wrote: >> Hi Adrian, >> >> On 2016/10/11 20:39, Adrian Hunter wrote: +static int __xenon_emmc_delay_adj_test(struct mmc_card *card) +{ + int err; + u8 *ext_csd = NULL; + + err =

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

On 12/10/16 15:17, Ziji Hu wrote: > Hi Adrian, > > On 2016/10/11 20:39, Adrian Hunter wrote: >> On 07/10/16 18:22, Gregory CLEMENT wrote: >>> From: Ziji Hu >>> >>> Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. >>> Three types of PHYs are supported. >>> >>> Add

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

On 12/10/16 15:17, Ziji Hu wrote: > Hi Adrian, > > On 2016/10/11 20:39, Adrian Hunter wrote: >> On 07/10/16 18:22, Gregory CLEMENT wrote: >>> From: Ziji Hu >>> >>> Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. >>> Three types of PHYs are supported. >>> >>> Add support to multiple

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Adrian, On 2016/10/11 20:39, Adrian Hunter wrote: > On 07/10/16 18:22, Gregory CLEMENT wrote: >> From: Ziji Hu >> >> Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. >> Three types of PHYs are supported. >> >> Add support to multiple types of PHYs init and

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Adrian, On 2016/10/11 20:39, Adrian Hunter wrote: > On 07/10/16 18:22, Gregory CLEMENT wrote: >> From: Ziji Hu >> >> Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. >> Three types of PHYs are supported. >> >> Add support to multiple types of PHYs init and configuration. >> Add

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

On 07/10/16 18:22, Gregory CLEMENT wrote: > From: Ziji Hu > > Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. > Three types of PHYs are supported. > > Add support to multiple types of PHYs init and configuration. > Add register definitions of PHYs. > >

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

On 07/10/16 18:22, Gregory CLEMENT wrote: > From: Ziji Hu > > Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. > Three types of PHYs are supported. > > Add support to multiple types of PHYs init and configuration. > Add register definitions of PHYs. > > Signed-off-by: Hu Ziji >

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

在 2016/10/8 17:28, Ziji Hu 写道: Hi Shawn, On 2016/10/8 10:44, Shawn Lin wrote: 在 2016/10/7 23:22, Gregory CLEMENT 写道: From: Ziji Hu Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. Three types of PHYs are supported. Add support to multiple types of PHYs init and

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

在 2016/10/8 17:28, Ziji Hu 写道: Hi Shawn, On 2016/10/8 10:44, Shawn Lin wrote: 在 2016/10/7 23:22, Gregory CLEMENT 写道: From: Ziji Hu Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. Three types of PHYs are supported. Add support to multiple types of PHYs init and configuration. Add

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Shawn, On 2016/10/8 10:44, Shawn Lin wrote: > 在 2016/10/7 23:22, Gregory CLEMENT 写道: >> From: Ziji Hu >> >> Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. >> Three types of PHYs are supported. >> >> Add support to multiple types of PHYs init and configuration. >>

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

Hi Shawn, On 2016/10/8 10:44, Shawn Lin wrote: > 在 2016/10/7 23:22, Gregory CLEMENT 写道: >> From: Ziji Hu >> >> Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. >> Three types of PHYs are supported. >> >> Add support to multiple types of PHYs init and configuration. >> Add register

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

在 2016/10/7 23:22, Gregory CLEMENT 写道: From: Ziji Hu Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. Three types of PHYs are supported. Add support to multiple types of PHYs init and configuration. Add register definitions of PHYs. Signed-off-by: Hu Ziji

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

在 2016/10/7 23:22, Gregory CLEMENT 写道: From: Ziji Hu Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. Three types of PHYs are supported. Add support to multiple types of PHYs init and configuration. Add register definitions of PHYs. Signed-off-by: Hu Ziji Reviewed-by: Gregory