Re: [PATCH 7/7] trace: Update documentation for mono, mono_raw and boot clock

[Thomas Gleixner]

On Tue, 29 Nov 2016, Joel Fernandes wrote:
> On Mon, Nov 28, 2016 at 11:26 PM, Ingo Molnar  wrote:
> >
> > * John Stultz  wrote:
> >
> >> +   boot: This is the boot clock (CLOCK_BOOTTIME) and is based on the
> >> + fast monotonic clock, but also accounts for time spent in
> >> + suspend. Since the clock access is designed for use in
> >> + tracing in the suspend path, some side effects are possible
> >> + if clock is accessed after the suspend time is accounted 
> >> before
> >> + the fast mono clock is updated. In this case, the clock 
> >> update
> >> + appears to happen slightly sooner than it normally would 
> >> have.
> >> + Also on 32-bit systems, its possible that the 64-bit boot 
> >> offset
> >> + sees a partial update. These effects are rare and post
> >> + processing should be able to handle them. See comments on
> >> + ktime_get_boot_fast_ns function for more information.
> >
> > s/its possible/it's possible
> > s/comments on ktime_get_boost_fast_ns function/comments in the 
> > ktime_get_boost_fast_ns() function
> >
> 
> Thanks, I'll fix these up and repost.

Don't bother. I have fixed it up locally already.

Thanks,

tglx

Re: [PATCH 7/7] trace: Update documentation for mono, mono_raw and boot clock

[Thomas Gleixner]

On Tue, 29 Nov 2016, Joel Fernandes wrote:
> On Mon, Nov 28, 2016 at 11:26 PM, Ingo Molnar  wrote:
> >
> > * John Stultz  wrote:
> >
> >> +   boot: This is the boot clock (CLOCK_BOOTTIME) and is based on the
> >> + fast monotonic clock, but also accounts for time spent in
> >> + suspend. Since the clock access is designed for use in
> >> + tracing in the suspend path, some side effects are possible
> >> + if clock is accessed after the suspend time is accounted 
> >> before
> >> + the fast mono clock is updated. In this case, the clock 
> >> update
> >> + appears to happen slightly sooner than it normally would 
> >> have.
> >> + Also on 32-bit systems, its possible that the 64-bit boot 
> >> offset
> >> + sees a partial update. These effects are rare and post
> >> + processing should be able to handle them. See comments on
> >> + ktime_get_boot_fast_ns function for more information.
> >
> > s/its possible/it's possible
> > s/comments on ktime_get_boost_fast_ns function/comments in the 
> > ktime_get_boost_fast_ns() function
> >
> 
> Thanks, I'll fix these up and repost.

Don't bother. I have fixed it up locally already.

Thanks,

tglx

Re: [PATCH 7/7] trace: Update documentation for mono, mono_raw and boot clock

[Joel Fernandes]

On Mon, Nov 28, 2016 at 11:26 PM, Ingo Molnar  wrote:
>
> * John Stultz  wrote:
>
>> +   boot: This is the boot clock (CLOCK_BOOTTIME) and is based on the
>> + fast monotonic clock, but also accounts for time spent in
>> + suspend. Since the clock access is designed for use in
>> + tracing in the suspend path, some side effects are possible
>> + if clock is accessed after the suspend time is accounted before
>> + the fast mono clock is updated. In this case, the clock update
>> + appears to happen slightly sooner than it normally would have.
>> + Also on 32-bit systems, its possible that the 64-bit boot 
>> offset
>> + sees a partial update. These effects are rare and post
>> + processing should be able to handle them. See comments on
>> + ktime_get_boot_fast_ns function for more information.
>
> s/its possible/it's possible
> s/comments on ktime_get_boost_fast_ns function/comments in the 
> ktime_get_boost_fast_ns() function
>

Thanks, I'll fix these up and repost.

Regards,
Joel

> Thanks,
>
> Ingo

Re: [PATCH 7/7] trace: Update documentation for mono, mono_raw and boot clock

[Joel Fernandes]

On Mon, Nov 28, 2016 at 11:26 PM, Ingo Molnar  wrote:
>
> * John Stultz  wrote:
>
>> +   boot: This is the boot clock (CLOCK_BOOTTIME) and is based on the
>> + fast monotonic clock, but also accounts for time spent in
>> + suspend. Since the clock access is designed for use in
>> + tracing in the suspend path, some side effects are possible
>> + if clock is accessed after the suspend time is accounted before
>> + the fast mono clock is updated. In this case, the clock update
>> + appears to happen slightly sooner than it normally would have.
>> + Also on 32-bit systems, its possible that the 64-bit boot 
>> offset
>> + sees a partial update. These effects are rare and post
>> + processing should be able to handle them. See comments on
>> + ktime_get_boot_fast_ns function for more information.
>
> s/its possible/it's possible
> s/comments on ktime_get_boost_fast_ns function/comments in the 
> ktime_get_boost_fast_ns() function
>

Thanks, I'll fix these up and repost.

Regards,
Joel

> Thanks,
>
> Ingo

Re: [PATCH 7/7] trace: Update documentation for mono, mono_raw and boot clock

[Ingo Molnar]

* John Stultz  wrote:

> +   boot: This is the boot clock (CLOCK_BOOTTIME) and is based on the
> + fast monotonic clock, but also accounts for time spent in
> + suspend. Since the clock access is designed for use in
> + tracing in the suspend path, some side effects are possible
> + if clock is accessed after the suspend time is accounted before
> + the fast mono clock is updated. In this case, the clock update
> + appears to happen slightly sooner than it normally would have.
> + Also on 32-bit systems, its possible that the 64-bit boot offset
> + sees a partial update. These effects are rare and post
> + processing should be able to handle them. See comments on
> + ktime_get_boot_fast_ns function for more information.

s/its possible/it's possible
s/comments on ktime_get_boost_fast_ns function/comments in the 
ktime_get_boost_fast_ns() function

Thanks,

Ingo

Re: [PATCH 7/7] trace: Update documentation for mono, mono_raw and boot clock

[Ingo Molnar]

* John Stultz  wrote:

> +   boot: This is the boot clock (CLOCK_BOOTTIME) and is based on the
> + fast monotonic clock, but also accounts for time spent in
> + suspend. Since the clock access is designed for use in
> + tracing in the suspend path, some side effects are possible
> + if clock is accessed after the suspend time is accounted before
> + the fast mono clock is updated. In this case, the clock update
> + appears to happen slightly sooner than it normally would have.
> + Also on 32-bit systems, its possible that the 64-bit boot offset
> + sees a partial update. These effects are rare and post
> + processing should be able to handle them. See comments on
> + ktime_get_boot_fast_ns function for more information.

s/its possible/it's possible
s/comments on ktime_get_boost_fast_ns function/comments in the 
ktime_get_boost_fast_ns() function

Thanks,

Ingo

Re: [PATCH 7/7] trace: Update documentation for mono, mono_raw and boot clock

[Steven Rostedt]

On Mon, 28 Nov 2016 14:35:24 -0800
John Stultz  wrote:

> From: Joel Fernandes 
> 
> Documentation was missing for mono and mono_raw, add them and also for
> the boot clock introduced in this series.
> 
> Cc: Steven Rostedt 

Acked-by: Steven Rostedt 

-- Steve

> Cc: Thomas Gleixner 
> Cc: Ingo Molnar 
> Cc: Richard Cochran 
> Cc: Prarit Bhargava 
> Reviewed-by: Thomas Gleixner 
> Signed-off-by: Joel Fernandes 
> Signed-off-by: John Stultz 
> ---

Re: [PATCH 7/7] trace: Update documentation for mono, mono_raw and boot clock

[Steven Rostedt]

On Mon, 28 Nov 2016 14:35:24 -0800
John Stultz  wrote:

> From: Joel Fernandes 
> 
> Documentation was missing for mono and mono_raw, add them and also for
> the boot clock introduced in this series.
> 
> Cc: Steven Rostedt 

Acked-by: Steven Rostedt 

-- Steve

> Cc: Thomas Gleixner 
> Cc: Ingo Molnar 
> Cc: Richard Cochran 
> Cc: Prarit Bhargava 
> Reviewed-by: Thomas Gleixner 
> Signed-off-by: Joel Fernandes 
> Signed-off-by: John Stultz 
> ---