Re: [PATCH 7/8] docs: kernel-doc: Finish moving STATE_* code out of process_file()

2018-02-09 Thread Jani Nikula
On Thu, 08 Feb 2018, Jonathan Corbet wrote: > On Thu, 8 Feb 2018 13:29:53 +1100 > "Tobin C. Harding" wrote: > >> It doesn't appear to be introduced by you but the brace positions are >> non-uniform in this patch. >> >> if >> { >> ... >> } >> else >> { >> ...

Re: [PATCH 7/8] docs: kernel-doc: Finish moving STATE_* code out of process_file()

2018-02-09 Thread Jani Nikula
On Thu, 08 Feb 2018, Jonathan Corbet wrote: > On Thu, 8 Feb 2018 13:29:53 +1100 > "Tobin C. Harding" wrote: > >> It doesn't appear to be introduced by you but the brace positions are >> non-uniform in this patch. >> >> if >> { >> ... >> } >> else >> { >> ... >> } >> >> instead of >> >> if

Re: [PATCH 7/8] docs: kernel-doc: Finish moving STATE_* code out of process_file()

2018-02-08 Thread Jonathan Corbet
On Thu, 8 Feb 2018 13:29:53 +1100 "Tobin C. Harding" wrote: > It doesn't appear to be introduced by you but the brace positions are > non-uniform in this patch. > > if > { > ... > } > else > { > ... > } > > instead of > > if { > ... > } else { > eee > } True, that's

Re: [PATCH 7/8] docs: kernel-doc: Finish moving STATE_* code out of process_file()

2018-02-08 Thread Jonathan Corbet
On Thu, 8 Feb 2018 13:29:53 +1100 "Tobin C. Harding" wrote: > It doesn't appear to be introduced by you but the brace positions are > non-uniform in this patch. > > if > { > ... > } > else > { > ... > } > > instead of > > if { > ... > } else { > eee > } True, that's worth fixing up

Re: [PATCH 7/8] docs: kernel-doc: Finish moving STATE_* code out of process_file()

2018-02-07 Thread Tobin C. Harding
On Wed, Feb 07, 2018 at 10:26:23AM -0700, Jonathan Corbet wrote: > Move STATE_INLINE and STATE_DOCBLOCK code out of process_file(), which now > actually fits on a single screen. Delete an unused variable and add a > couple of comments while I'm at it. > > Signed-off-by: Jonathan Corbet

Re: [PATCH 7/8] docs: kernel-doc: Finish moving STATE_* code out of process_file()

2018-02-07 Thread Tobin C. Harding
On Wed, Feb 07, 2018 at 10:26:23AM -0700, Jonathan Corbet wrote: > Move STATE_INLINE and STATE_DOCBLOCK code out of process_file(), which now > actually fits on a single screen. Delete an unused variable and add a > couple of comments while I'm at it. > > Signed-off-by: Jonathan Corbet > --- >