On Thu, 08 Feb 2018, Jonathan Corbet wrote:
> On Thu, 8 Feb 2018 13:29:53 +1100
> "Tobin C. Harding" wrote:
>
>> It doesn't appear to be introduced by you but the brace positions are
>> non-uniform in this patch.
>>
>> if
>> {
>> ...
>> }
>> else
>> {
>> ...
On Thu, 08 Feb 2018, Jonathan Corbet wrote:
> On Thu, 8 Feb 2018 13:29:53 +1100
> "Tobin C. Harding" wrote:
>
>> It doesn't appear to be introduced by you but the brace positions are
>> non-uniform in this patch.
>>
>> if
>> {
>> ...
>> }
>> else
>> {
>> ...
>> }
>>
>> instead of
>>
>> if
On Thu, 8 Feb 2018 13:29:53 +1100
"Tobin C. Harding" wrote:
> It doesn't appear to be introduced by you but the brace positions are
> non-uniform in this patch.
>
> if
> {
> ...
> }
> else
> {
> ...
> }
>
> instead of
>
> if {
> ...
> } else {
> eee
> }
True, that's
On Thu, 8 Feb 2018 13:29:53 +1100
"Tobin C. Harding" wrote:
> It doesn't appear to be introduced by you but the brace positions are
> non-uniform in this patch.
>
> if
> {
> ...
> }
> else
> {
> ...
> }
>
> instead of
>
> if {
> ...
> } else {
> eee
> }
True, that's worth fixing up
On Wed, Feb 07, 2018 at 10:26:23AM -0700, Jonathan Corbet wrote:
> Move STATE_INLINE and STATE_DOCBLOCK code out of process_file(), which now
> actually fits on a single screen. Delete an unused variable and add a
> couple of comments while I'm at it.
>
> Signed-off-by: Jonathan Corbet
On Wed, Feb 07, 2018 at 10:26:23AM -0700, Jonathan Corbet wrote:
> Move STATE_INLINE and STATE_DOCBLOCK code out of process_file(), which now
> actually fits on a single screen. Delete an unused variable and add a
> couple of comments while I'm at it.
>
> Signed-off-by: Jonathan Corbet
> ---
>
6 matches
Mail list logo