Re: [PATCH RESEND] PM / sleep: Fix racing timers

2015-01-24 Thread Thomas Gleixner
On Fri, 23 Jan 2015, Sören Brinkmann wrote: > On Mon, 2015-01-12 at 04:14PM +, Lorenzo Pieralisi wrote: > > I thought that a shutdown clock event device explicitly disables IRQ > > assertion, that's why I am inquiring, I do not understand how this > > can happen - how can you have a pending

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2015-01-24 Thread Thomas Gleixner
On Fri, 23 Jan 2015, Sören Brinkmann wrote: On Mon, 2015-01-12 at 04:14PM +, Lorenzo Pieralisi wrote: I thought that a shutdown clock event device explicitly disables IRQ assertion, that's why I am inquiring, I do not understand how this can happen - how can you have a pending timer IRQ

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2015-01-23 Thread Sören Brinkmann
On Mon, 2015-01-12 at 12:20AM +0100, Rafael J. Wysocki wrote: > On Friday, January 09, 2015 01:50:59 PM Sören Brinkmann wrote: > > On Sat, 2014-11-08 at 03:56PM -0800, Sören Brinkmann wrote: > > > Hi Rafael, > > > > > > On Thu, 2014-11-06 at 01:33AM +0100, Rafael J. Wysocki wrote: > > > > On

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2015-01-23 Thread Sören Brinkmann
Sorry for the delay, but a lot of stuff came in between and I need to rebase a couple of branches and re-test things. Some comments inline below: On Mon, 2015-01-12 at 04:14PM +, Lorenzo Pieralisi wrote: > On Mon, Jan 12, 2015 at 03:55:05PM +, Sören Brinkmann wrote: > > On Mon, 2015-01-12

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2015-01-23 Thread Sören Brinkmann
On Mon, 2015-01-12 at 12:20AM +0100, Rafael J. Wysocki wrote: On Friday, January 09, 2015 01:50:59 PM Sören Brinkmann wrote: On Sat, 2014-11-08 at 03:56PM -0800, Sören Brinkmann wrote: Hi Rafael, On Thu, 2014-11-06 at 01:33AM +0100, Rafael J. Wysocki wrote: On Thursday, October

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2015-01-23 Thread Sören Brinkmann
Sorry for the delay, but a lot of stuff came in between and I need to rebase a couple of branches and re-test things. Some comments inline below: On Mon, 2015-01-12 at 04:14PM +, Lorenzo Pieralisi wrote: On Mon, Jan 12, 2015 at 03:55:05PM +, Sören Brinkmann wrote: On Mon, 2015-01-12 at

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2015-01-12 Thread Lorenzo Pieralisi
On Mon, Jan 12, 2015 at 03:55:05PM +, Sören Brinkmann wrote: > On Mon, 2015-01-12 at 03:43PM +, Lorenzo Pieralisi wrote: > > Hi Rafael, Soren, > > > > On Sun, Jan 11, 2015 at 11:20:36PM +, Rafael J. Wysocki wrote: > > > On Friday, January 09, 2015 01:50:59 PM Sören Brinkmann wrote: > >

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2015-01-12 Thread Sören Brinkmann
On Mon, 2015-01-12 at 03:43PM +, Lorenzo Pieralisi wrote: > Hi Rafael, Soren, > > On Sun, Jan 11, 2015 at 11:20:36PM +, Rafael J. Wysocki wrote: > > On Friday, January 09, 2015 01:50:59 PM Sören Brinkmann wrote: > > > On Sat, 2014-11-08 at 03:56PM -0800, Sören Brinkmann wrote: > > > > Hi

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2015-01-12 Thread Lorenzo Pieralisi
Hi Rafael, Soren, On Sun, Jan 11, 2015 at 11:20:36PM +, Rafael J. Wysocki wrote: > On Friday, January 09, 2015 01:50:59 PM Sören Brinkmann wrote: > > On Sat, 2014-11-08 at 03:56PM -0800, Sören Brinkmann wrote: > > > Hi Rafael, > > > > > > On Thu, 2014-11-06 at 01:33AM +0100, Rafael J.

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2015-01-12 Thread Lorenzo Pieralisi
Hi Rafael, Soren, On Sun, Jan 11, 2015 at 11:20:36PM +, Rafael J. Wysocki wrote: On Friday, January 09, 2015 01:50:59 PM Sören Brinkmann wrote: On Sat, 2014-11-08 at 03:56PM -0800, Sören Brinkmann wrote: Hi Rafael, On Thu, 2014-11-06 at 01:33AM +0100, Rafael J. Wysocki wrote:

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2015-01-12 Thread Sören Brinkmann
On Mon, 2015-01-12 at 03:43PM +, Lorenzo Pieralisi wrote: Hi Rafael, Soren, On Sun, Jan 11, 2015 at 11:20:36PM +, Rafael J. Wysocki wrote: On Friday, January 09, 2015 01:50:59 PM Sören Brinkmann wrote: On Sat, 2014-11-08 at 03:56PM -0800, Sören Brinkmann wrote: Hi Rafael,

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2015-01-12 Thread Lorenzo Pieralisi
On Mon, Jan 12, 2015 at 03:55:05PM +, Sören Brinkmann wrote: On Mon, 2015-01-12 at 03:43PM +, Lorenzo Pieralisi wrote: Hi Rafael, Soren, On Sun, Jan 11, 2015 at 11:20:36PM +, Rafael J. Wysocki wrote: On Friday, January 09, 2015 01:50:59 PM Sören Brinkmann wrote: On Sat,

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2015-01-11 Thread Rafael J. Wysocki
On Friday, January 09, 2015 01:50:59 PM Sören Brinkmann wrote: > On Sat, 2014-11-08 at 03:56PM -0800, Sören Brinkmann wrote: > > Hi Rafael, > > > > On Thu, 2014-11-06 at 01:33AM +0100, Rafael J. Wysocki wrote: > > > On Thursday, October 02, 2014 09:01:15 AM Sören Brinkmann wrote: > > > > Hi

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2015-01-11 Thread Rafael J. Wysocki
On Friday, January 09, 2015 01:50:59 PM Sören Brinkmann wrote: On Sat, 2014-11-08 at 03:56PM -0800, Sören Brinkmann wrote: Hi Rafael, On Thu, 2014-11-06 at 01:33AM +0100, Rafael J. Wysocki wrote: On Thursday, October 02, 2014 09:01:15 AM Sören Brinkmann wrote: Hi Rafael, Hi,

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2015-01-09 Thread Sören Brinkmann
On Sat, 2014-11-08 at 03:56PM -0800, Sören Brinkmann wrote: > Hi Rafael, > > On Thu, 2014-11-06 at 01:33AM +0100, Rafael J. Wysocki wrote: > > On Thursday, October 02, 2014 09:01:15 AM Sören Brinkmann wrote: > > > Hi Rafael, > > > > Hi, > > > > Sorry for the huge delay. > > > > > On Tue,

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2015-01-09 Thread Sören Brinkmann
On Sat, 2014-11-08 at 03:56PM -0800, Sören Brinkmann wrote: Hi Rafael, On Thu, 2014-11-06 at 01:33AM +0100, Rafael J. Wysocki wrote: On Thursday, October 02, 2014 09:01:15 AM Sören Brinkmann wrote: Hi Rafael, Hi, Sorry for the huge delay. On Tue, 2014-09-23 at 01:01AM

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2014-11-08 Thread Sören Brinkmann
Hi Rafael, On Thu, 2014-11-06 at 01:33AM +0100, Rafael J. Wysocki wrote: > On Thursday, October 02, 2014 09:01:15 AM Sören Brinkmann wrote: > > Hi Rafael, > > Hi, > > Sorry for the huge delay. > > > On Tue, 2014-09-23 at 01:01AM +0200, Rafael J. Wysocki wrote: > > > On Monday, September 22,

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2014-11-08 Thread Sören Brinkmann
Hi Rafael, On Thu, 2014-11-06 at 01:33AM +0100, Rafael J. Wysocki wrote: On Thursday, October 02, 2014 09:01:15 AM Sören Brinkmann wrote: Hi Rafael, Hi, Sorry for the huge delay. On Tue, 2014-09-23 at 01:01AM +0200, Rafael J. Wysocki wrote: On Monday, September 22, 2014 10:07:03

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2014-11-05 Thread Rafael J. Wysocki
On Thursday, October 02, 2014 09:01:15 AM Sören Brinkmann wrote: > Hi Rafael, Hi, Sorry for the huge delay. > On Tue, 2014-09-23 at 01:01AM +0200, Rafael J. Wysocki wrote: > > On Monday, September 22, 2014 10:07:03 AM Soren Brinkmann wrote: > > > On platforms that do not power off during

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2014-11-05 Thread Rafael J. Wysocki
On Thursday, October 02, 2014 09:01:15 AM Sören Brinkmann wrote: Hi Rafael, Hi, Sorry for the huge delay. On Tue, 2014-09-23 at 01:01AM +0200, Rafael J. Wysocki wrote: On Monday, September 22, 2014 10:07:03 AM Soren Brinkmann wrote: On platforms that do not power off during suspend,

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2014-10-28 Thread Sören Brinkmann
Hi Rafael, any opinion on this? Thanks, Sören On Thu, 2014-10-02 at 09:01AM -0700, Sören Brinkmann wrote: > Hi Rafael, > > On Tue, 2014-09-23 at 01:01AM +0200, Rafael J. Wysocki wrote: > > On Monday, September 22, 2014 10:07:03 AM Soren Brinkmann wrote: > > > On platforms that

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2014-10-28 Thread Sören Brinkmann
Hi Rafael, any opinion on this? Thanks, Sören On Thu, 2014-10-02 at 09:01AM -0700, Sören Brinkmann wrote: Hi Rafael, On Tue, 2014-09-23 at 01:01AM +0200, Rafael J. Wysocki wrote: On Monday, September 22, 2014 10:07:03 AM Soren Brinkmann wrote: On platforms that do not

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2014-10-02 Thread Sören Brinkmann
Hi Rafael, On Tue, 2014-09-23 at 01:01AM +0200, Rafael J. Wysocki wrote: > On Monday, September 22, 2014 10:07:03 AM Soren Brinkmann wrote: > > On platforms that do not power off during suspend, successfully entering > > suspend races with timers. > > > > The race happening in a couple of

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2014-10-02 Thread Sören Brinkmann
Hi Rafael, On Tue, 2014-09-23 at 01:01AM +0200, Rafael J. Wysocki wrote: On Monday, September 22, 2014 10:07:03 AM Soren Brinkmann wrote: On platforms that do not power off during suspend, successfully entering suspend races with timers. The race happening in a couple of location is:

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2014-09-22 Thread Rafael J. Wysocki
On Monday, September 22, 2014 10:07:03 AM Soren Brinkmann wrote: > On platforms that do not power off during suspend, successfully entering > suspend races with timers. > > The race happening in a couple of location is: > > 1. disable IRQs (e.g. arch_suspend_disable_irqs()) >

Re: [PATCH RESEND] PM / sleep: Fix racing timers

2014-09-22 Thread Rafael J. Wysocki
On Monday, September 22, 2014 10:07:03 AM Soren Brinkmann wrote: On platforms that do not power off during suspend, successfully entering suspend races with timers. The race happening in a couple of location is: 1. disable IRQs (e.g. arch_suspend_disable_irqs()) ...