Re: [PATCH V2 1/2] ARM: dts: imx7s: add temperature monitor support

2018-02-04 Thread Shawn Guo
On Fri, Jan 26, 2018 at 04:09:39PM +0800, Anson Huang wrote:
> Add i.MX7 temperature monitor support.
> 
> Signed-off-by: Anson Huang 
> Acked-by: Dong Aisheng 
> ---
> no changes since V1.
>  .../devicetree/bindings/thermal/imx-thermal.txt  |  5 +++--

The bindings doc should be a separate patch or part of related
imx-thermal driver patch ...

>  arch/arm/boot/dts/imx7s.dtsi | 20 
> 

..., and shouldn't be mixed with dts changes.

Shawn


Re: [PATCH V2 1/2] ARM: dts: imx7s: add temperature monitor support

2018-02-04 Thread Rob Herring
On Fri, Jan 26, 2018 at 04:09:39PM +0800, Anson Huang wrote:
> Add i.MX7 temperature monitor support.
> 
> Signed-off-by: Anson Huang 
> Acked-by: Dong Aisheng 
> ---
> no changes since V1.
>  .../devicetree/bindings/thermal/imx-thermal.txt  |  5 +++--
>  arch/arm/boot/dts/imx7s.dtsi | 20 
> 
>  2 files changed, 23 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/imx-thermal.txt 
> b/Documentation/devicetree/bindings/thermal/imx-thermal.txt
> index 28be51a..9575d45 100644
> --- a/Documentation/devicetree/bindings/thermal/imx-thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/imx-thermal.txt
> @@ -1,8 +1,9 @@
>  * Temperature Monitor (TEMPMON) on Freescale i.MX SoCs
>  
>  Required properties:
> -- compatible : "fsl,imx6q-tempmon" for i.MX6Q, "fsl,imx6sx-tempmon" for 
> i.MX6SX.
> -  i.MX6SX has two more IRQs than i.MX6Q, one is IRQ_LOW and the other is 
> IRQ_PANIC,
> +- compatible : "fsl,imx6q-tempmon" for i.MX6Q, "fsl,imx6sx-tempmon" for 
> i.MX6SX,
> +  "fsl,imx7-tempmon" for i.MX7S/D.

Please format as one valid compatible combination per line.

> +  i.MX6SX and i.MX7S/D have two more IRQs than i.MX6Q, one is IRQ_LOW and 
> the other is IRQ_PANIC,

This belongs with the interrupt property.

>when temperature is below than low threshold, IRQ_LOW will be triggered, 
> when temperature
>is higher than panic threshold, system will auto reboot by SRC module.
>  - fsl,tempmon : phandle pointer to system controller that contains TEMPMON
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index 82ad26e..2e2eda53 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -497,9 +497,29 @@
>   };
>  
>   ocotp: ocotp-ctrl@3035 {
> + #address-cells = <1>;
> + #size-cells = <1>;
>   compatible = "fsl,imx7d-ocotp", "syscon";
>   reg = <0x3035 0x1>;
>   clocks = <&clks IMX7D_OCOTP_CLK>;
> +
> + tempmon_calib: calib@3c {
> + reg = <0x3c 0x4>;
> + };
> +
> + tempmon_temp_grade: temp-grade@10 {
> + reg = <0x10 0x4>;
> + };
> + };
> +
> + tempmon: tempmon {
> + compatible = "fsl,imx7-tempmon";
> + interrupts = ;
> + fsl,tempmon =<&anatop>;
> + nvmem-cells = <&tempmon_calib>,
> + <&tempmon_temp_grade>;
> + nvmem-cell-names = "calib", "temp_grade";
> + clocks = <&clks IMX7D_PLL_SYS_MAIN_CLK>;
>   };
>  
>   anatop: anatop@3036 {
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html