Re: [PATCH V4 1/5] nvme: do atomically bit operations on nvme_request.flags

[jianchao.wang]

Hi Christoph

Thanks for your precious time for reviewing this.

On 03/08/2018 03:57 PM, Christoph Hellwig wrote:
>> -u8  flags;
>>  u16 status;
>> +unsigned long flags;
> Please align the field name like the others, though

Yes, I will change this next version.

Thanks
Jianchao

Re: [PATCH V4 1/5] nvme: do atomically bit operations on nvme_request.flags

[jianchao.wang]

Hi Christoph

Thanks for your precious time for reviewing this.

On 03/08/2018 03:57 PM, Christoph Hellwig wrote:
>> -u8  flags;
>>  u16 status;
>> +unsigned long flags;
> Please align the field name like the others, though

Yes, I will change this next version.

Thanks
Jianchao

Re: [PATCH V4 1/5] nvme: do atomically bit operations on nvme_request.flags

[Christoph Hellwig]

On Thu, Mar 08, 2018 at 02:19:27PM +0800, Jianchao Wang wrote:
> Do atomically bit operations on nvme_request.flags instead of
> regular read/write, then we could add other flags and set/clear
> them safely.
> 
> Signed-off-by: Jianchao Wang 

Looks good, assuming an actual need for this shows up in the next
patches :)

Reviewed-by: Christoph Hellwig 

> diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
> index e80fd74..02097e8 100644
> --- a/drivers/nvme/host/nvme.h
> +++ b/drivers/nvme/host/nvme.h
> @@ -93,8 +93,8 @@ struct nvme_request {
>   struct nvme_command *cmd;
>   union nvme_result   result;
>   u8  retries;
> - u8  flags;
>   u16 status;
> + unsigned long flags;

Please align the field name like the others, though.

Re: [PATCH V4 1/5] nvme: do atomically bit operations on nvme_request.flags

[Christoph Hellwig]

On Thu, Mar 08, 2018 at 02:19:27PM +0800, Jianchao Wang wrote:
> Do atomically bit operations on nvme_request.flags instead of
> regular read/write, then we could add other flags and set/clear
> them safely.
> 
> Signed-off-by: Jianchao Wang 

Looks good, assuming an actual need for this shows up in the next
patches :)

Reviewed-by: Christoph Hellwig 

> diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
> index e80fd74..02097e8 100644
> --- a/drivers/nvme/host/nvme.h
> +++ b/drivers/nvme/host/nvme.h
> @@ -93,8 +93,8 @@ struct nvme_request {
>   struct nvme_command *cmd;
>   union nvme_result   result;
>   u8  retries;
> - u8  flags;
>   u16 status;
> + unsigned long flags;

Please align the field name like the others, though.