Re: [PATCH V5 1/2] x86: IOSF: add dummy functions for loadable modules

2014-03-03 Thread One Thousand Gnomes 
On Mon, 03 Mar 2014 15:21:40 +0800
"Li, Aubrey"  wrote:

> On 2014/3/1 10:40, David E. Box wrote:
> > From: "David E. Box" 
> > 
> > Some loadable modules only need IOSF access on the platforms where it 
> > exists.
> > Provide dummy functions to allow these modules to compile and load on the
> > platforms where it doesn't exist.
> 
> This is not the right way, I think.

Disagree. There are various drivers that can use the IOSF interface but
do not need it, and need to also build and run on platforms without it.

The current code IMHO is correct. We want to make sure it builds without
IOSF, but that any attempt to use IOSF in such a runtime errors - that's
what this code does.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH V5 1/2] x86: IOSF: add dummy functions for loadable modules

2014-03-03 Thread One Thousand Gnomes 
On Mon, 03 Mar 2014 15:21:40 +0800
Li, Aubrey aubrey...@linux.intel.com wrote:

 On 2014/3/1 10:40, David E. Box wrote:
  From: David E. Box david.e@linux.intel.com
  
  Some loadable modules only need IOSF access on the platforms where it 
  exists.
  Provide dummy functions to allow these modules to compile and load on the
  platforms where it doesn't exist.
 
 This is not the right way, I think.

Disagree. There are various drivers that can use the IOSF interface but
do not need it, and need to also build and run on platforms without it.

The current code IMHO is correct. We want to make sure it builds without
IOSF, but that any attempt to use IOSF in such a runtime errors - that's
what this code does.

Alan
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH V5 1/2] x86: IOSF: add dummy functions for loadable modules

2014-03-02 Thread Li, Aubrey 
On 2014/3/1 10:40, David E. Box wrote:
> From: "David E. Box" 
> 
> Some loadable modules only need IOSF access on the platforms where it exists.
> Provide dummy functions to allow these modules to compile and load on the
> platforms where it doesn't exist.

This is not the right way, I think.

We can either default built-in this IOSF component, so that the
interface is always here, Or we can register the interfaces to the
global hooks, so that the consumers are able to check the hook to see if
it's available and make the calls if it is.

In the long turn, this could be a bus driver and framework needed.

Thanks,
-Aubrey
> 
> Signed-off-by: David E. Box 
> ---
>  arch/x86/include/asm/iosf_mbi.h |   33 +
>  arch/x86/kernel/iosf_mbi.c  |6 ++
>  2 files changed, 39 insertions(+)
> 
> diff --git a/arch/x86/include/asm/iosf_mbi.h b/arch/x86/include/asm/iosf_mbi.h
> index 8e71c79..9fc5402 100644
> --- a/arch/x86/include/asm/iosf_mbi.h
> +++ b/arch/x86/include/asm/iosf_mbi.h
> @@ -5,6 +5,8 @@
>  #ifndef IOSF_MBI_SYMS_H
>  #define IOSF_MBI_SYMS_H
>  
> +#ifdef CONFIG_IOSF_MBI
> +
>  #define MBI_MCR_OFFSET   0xD0
>  #define MBI_MDR_OFFSET   0xD4
>  #define MBI_MCRX_OFFSET  0xD8
> @@ -50,6 +52,8 @@
>  #define BT_MBI_PCIE_READ 0x00
>  #define BT_MBI_PCIE_WRITE0x01
>  
> +bool iosf_mbi_available(void);
> +
>  /**
>   * iosf_mbi_read() - MailBox Interface read command
>   * @port:port indicating subunit being accessed
> @@ -87,4 +91,33 @@ int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 
> mdr);
>   */
>  int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask);
>  
> +#else /* CONFIG_IOSF_MBI is not enabled */
> +static inline
> +bool iosf_mbi_available(void)
> +{
> + return false;
> +}
> +
> +static inline
> +int iosf_mbi_read(u8 port, u8 opcode, u32 offset, u32 *mdr)
> +{
> + WARN();
> + return -EPERM;
> +}
> +
> +static inline
> +int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 mdr)
> +{
> + WARN();
> + return -EPERM;
> +}
> +
> +static inline
> +int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask)
> +{
> + WARN();
> + return -EPERM;
> +}
> +#endif /* CONFIG_IOSF_MBI */
> +
>  #endif /* IOSF_MBI_SYMS_H */
> diff --git a/arch/x86/kernel/iosf_mbi.c b/arch/x86/kernel/iosf_mbi.c
> index c3aae66..d3803c6 100644
> --- a/arch/x86/kernel/iosf_mbi.c
> +++ b/arch/x86/kernel/iosf_mbi.c
> @@ -177,6 +177,12 @@ int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 
> mdr, u32 mask)
>  }
>  EXPORT_SYMBOL(iosf_mbi_modify);
>  
> +bool iosf_mbi_available(void)
> +{
> + return mbi_pdev;
> +}
> +EXPORT_SYMBOL(iosf_mbi_available);
> +
>  static int iosf_mbi_probe(struct pci_dev *pdev,
> const struct pci_device_id *unused)
>  {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH V5 1/2] x86: IOSF: add dummy functions for loadable modules

2014-03-02 Thread Li, Aubrey 
On 2014/3/1 10:40, David E. Box wrote:
 From: David E. Box david.e@linux.intel.com
 
 Some loadable modules only need IOSF access on the platforms where it exists.
 Provide dummy functions to allow these modules to compile and load on the
 platforms where it doesn't exist.

This is not the right way, I think.

We can either default built-in this IOSF component, so that the
interface is always here, Or we can register the interfaces to the
global hooks, so that the consumers are able to check the hook to see if
it's available and make the calls if it is.

In the long turn, this could be a bus driver and framework needed.

Thanks,
-Aubrey
 
 Signed-off-by: David E. Box david.e@linux.intel.com
 ---
  arch/x86/include/asm/iosf_mbi.h |   33 +
  arch/x86/kernel/iosf_mbi.c  |6 ++
  2 files changed, 39 insertions(+)
 
 diff --git a/arch/x86/include/asm/iosf_mbi.h b/arch/x86/include/asm/iosf_mbi.h
 index 8e71c79..9fc5402 100644
 --- a/arch/x86/include/asm/iosf_mbi.h
 +++ b/arch/x86/include/asm/iosf_mbi.h
 @@ -5,6 +5,8 @@
  #ifndef IOSF_MBI_SYMS_H
  #define IOSF_MBI_SYMS_H
  
 +#ifdef CONFIG_IOSF_MBI
 +
  #define MBI_MCR_OFFSET   0xD0
  #define MBI_MDR_OFFSET   0xD4
  #define MBI_MCRX_OFFSET  0xD8
 @@ -50,6 +52,8 @@
  #define BT_MBI_PCIE_READ 0x00
  #define BT_MBI_PCIE_WRITE0x01
  
 +bool iosf_mbi_available(void);
 +
  /**
   * iosf_mbi_read() - MailBox Interface read command
   * @port:port indicating subunit being accessed
 @@ -87,4 +91,33 @@ int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 
 mdr);
   */
  int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask);
  
 +#else /* CONFIG_IOSF_MBI is not enabled */
 +static inline
 +bool iosf_mbi_available(void)
 +{
 + return false;
 +}
 +
 +static inline
 +int iosf_mbi_read(u8 port, u8 opcode, u32 offset, u32 *mdr)
 +{
 + WARN();
 + return -EPERM;
 +}
 +
 +static inline
 +int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 mdr)
 +{
 + WARN();
 + return -EPERM;
 +}
 +
 +static inline
 +int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask)
 +{
 + WARN();
 + return -EPERM;
 +}
 +#endif /* CONFIG_IOSF_MBI */
 +
  #endif /* IOSF_MBI_SYMS_H */
 diff --git a/arch/x86/kernel/iosf_mbi.c b/arch/x86/kernel/iosf_mbi.c
 index c3aae66..d3803c6 100644
 --- a/arch/x86/kernel/iosf_mbi.c
 +++ b/arch/x86/kernel/iosf_mbi.c
 @@ -177,6 +177,12 @@ int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 
 mdr, u32 mask)
  }
  EXPORT_SYMBOL(iosf_mbi_modify);
  
 +bool iosf_mbi_available(void)
 +{
 + return mbi_pdev;
 +}
 +EXPORT_SYMBOL(iosf_mbi_available);
 +
  static int iosf_mbi_probe(struct pci_dev *pdev,
 const struct pci_device_id *unused)
  {
 

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/