Re: [PATCH bpf-next 1/3] libbpf: add asm/unistd.h to xsk to get __NR_mmap2

On Wed, Aug 14, 2019 at 2:24 AM Ivan Khoronzhuk wrote: > > On Tue, Aug 13, 2019 at 04:38:13PM -0700, Andrii Nakryiko wrote: > > Hi, Andrii > > >On Tue, Aug 13, 2019 at 3:24 AM Ivan Khoronzhuk > > wrote: > >> > >> That's needed to get __NR_mmap2 when mmap2 syscall is used. > >> > >> Signed-off-by:

Re: [PATCH bpf-next 1/3] libbpf: add asm/unistd.h to xsk to get __NR_mmap2

On Wed, Aug 14, 2019 at 03:32:24PM +0200, Björn Töpel wrote: On Wed, 14 Aug 2019 at 13:57, Ivan Khoronzhuk wrote: On Wed, Aug 14, 2019 at 12:24:05PM +0300, Ivan Khoronzhuk wrote: >On Tue, Aug 13, 2019 at 04:38:13PM -0700, Andrii Nakryiko wrote: > >Hi, Andrii > >>On Tue, Aug 13, 2019 at 3:24

Re: [PATCH bpf-next 1/3] libbpf: add asm/unistd.h to xsk to get __NR_mmap2

On 8/14/19 6:32 AM, Björn Töpel wrote: > On Wed, 14 Aug 2019 at 13:57, Ivan Khoronzhuk > wrote: >> >> On Wed, Aug 14, 2019 at 12:24:05PM +0300, Ivan Khoronzhuk wrote: >>> On Tue, Aug 13, 2019 at 04:38:13PM -0700, Andrii Nakryiko wrote: >>> >>> Hi, Andrii >>> On Tue, Aug 13, 2019 at 3:24 AM

Re: [PATCH bpf-next 1/3] libbpf: add asm/unistd.h to xsk to get __NR_mmap2

On 8/14/19 2:24 AM, Ivan Khoronzhuk wrote: > On Tue, Aug 13, 2019 at 04:38:13PM -0700, Andrii Nakryiko wrote: > > Hi, Andrii > >> On Tue, Aug 13, 2019 at 3:24 AM Ivan Khoronzhuk >> wrote: >>> >>> That's needed to get __NR_mmap2 when mmap2 syscall is used. >>> >>> Signed-off-by: Ivan

Re: [PATCH bpf-next 1/3] libbpf: add asm/unistd.h to xsk to get __NR_mmap2

On Wed, 14 Aug 2019 at 13:57, Ivan Khoronzhuk wrote: > > On Wed, Aug 14, 2019 at 12:24:05PM +0300, Ivan Khoronzhuk wrote: > >On Tue, Aug 13, 2019 at 04:38:13PM -0700, Andrii Nakryiko wrote: > > > >Hi, Andrii > > > >>On Tue, Aug 13, 2019 at 3:24 AM Ivan Khoronzhuk > >> wrote: > >>> > >>>That's

Re: [PATCH bpf-next 1/3] libbpf: add asm/unistd.h to xsk to get __NR_mmap2

On Wed, Aug 14, 2019 at 12:24:05PM +0300, Ivan Khoronzhuk wrote: On Tue, Aug 13, 2019 at 04:38:13PM -0700, Andrii Nakryiko wrote: Hi, Andrii On Tue, Aug 13, 2019 at 3:24 AM Ivan Khoronzhuk wrote: That's needed to get __NR_mmap2 when mmap2 syscall is used. Signed-off-by: Ivan Khoronzhuk

Re: [PATCH bpf-next 1/3] libbpf: add asm/unistd.h to xsk to get __NR_mmap2

On Wed, Aug 14, 2019 at 12:32:41AM +, Yonghong Song wrote: Hi, Yonghong Song On 8/13/19 3:23 AM, Ivan Khoronzhuk wrote: That's needed to get __NR_mmap2 when mmap2 syscall is used. It seems I did not have this issue on x64 machine e.g., Fedora 29. My glibc version is 2.28. gcc 8.2.1.

Re: [PATCH bpf-next 1/3] libbpf: add asm/unistd.h to xsk to get __NR_mmap2

On Tue, Aug 13, 2019 at 04:38:13PM -0700, Andrii Nakryiko wrote: Hi, Andrii On Tue, Aug 13, 2019 at 3:24 AM Ivan Khoronzhuk wrote: That's needed to get __NR_mmap2 when mmap2 syscall is used. Signed-off-by: Ivan Khoronzhuk --- tools/lib/bpf/xsk.c | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH bpf-next 1/3] libbpf: add asm/unistd.h to xsk to get __NR_mmap2

On 8/13/19 3:23 AM, Ivan Khoronzhuk wrote: > That's needed to get __NR_mmap2 when mmap2 syscall is used. It seems I did not have this issue on x64 machine e.g., Fedora 29. My glibc version is 2.28. gcc 8.2.1. What is your particular system glibc version? So needing kernel asm/unistd.h is

Re: [PATCH bpf-next 1/3] libbpf: add asm/unistd.h to xsk to get __NR_mmap2

On Tue, Aug 13, 2019 at 3:24 AM Ivan Khoronzhuk wrote: > > That's needed to get __NR_mmap2 when mmap2 syscall is used. > > Signed-off-by: Ivan Khoronzhuk > --- > tools/lib/bpf/xsk.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/lib/bpf/xsk.c b/tools/lib/bpf/xsk.c > index

Re: [PATCH bpf-next 1/3] libbpf: add asm/unistd.h to xsk to get __NR_mmap2

On 13 Aug 2019, at 3:23, Ivan Khoronzhuk wrote: > That's needed to get __NR_mmap2 when mmap2 syscall is used. > > Signed-off-by: Ivan Khoronzhuk Acked-by: Jonathan Lemon