Re: [PATCH bpf-next v2 2/3] xdp: xdp_umem: replace kmap on vmap for umem map

2019-08-15 Thread Jonathan Lemon
On 15 Aug 2019, at 5:13, Ivan Khoronzhuk wrote: > For 64-bit there is no reason to use vmap/vunmap, so use page_address > as it was initially. For 32 bits, in some apps, like in samples > xdpsock_user.c when number of pgs in use is quite big, the kmap > memory can be not enough, despite on this

Re: [PATCH bpf-next v2 2/3] xdp: xdp_umem: replace kmap on vmap for umem map

2019-08-15 Thread Jonathan Lemon
On 15 Aug 2019, at 12:19, Ivan Khoronzhuk wrote: On Thu, Aug 15, 2019 at 11:23:16AM -0700, Jonathan Lemon wrote: On 15 Aug 2019, at 5:13, Ivan Khoronzhuk wrote: For 64-bit there is no reason to use vmap/vunmap, so use page_address as it was initially. For 32 bits, in some apps, like in sa

Re: [PATCH bpf-next v2 2/3] xdp: xdp_umem: replace kmap on vmap for umem map

2019-08-15 Thread Ivan Khoronzhuk
On Thu, Aug 15, 2019 at 11:23:16AM -0700, Jonathan Lemon wrote: On 15 Aug 2019, at 5:13, Ivan Khoronzhuk wrote: For 64-bit there is no reason to use vmap/vunmap, so use page_address as it was initially. For 32 bits, in some apps, like in samples xdpsock_user.c when number of pgs in use is quite

Re: [PATCH bpf-next v2 2/3] xdp: xdp_umem: replace kmap on vmap for umem map

2019-08-15 Thread Jonathan Lemon
On 15 Aug 2019, at 5:13, Ivan Khoronzhuk wrote: For 64-bit there is no reason to use vmap/vunmap, so use page_address as it was initially. For 32 bits, in some apps, like in samples xdpsock_user.c when number of pgs in use is quite big, the kmap memory can be not enough, despite on this, kmap lo