Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

2018-04-13 Thread Wang, Haiyue
On 2018-04-13 21:50, Corey Minyard wrote: On 04/07/2018 02:54 AM, Wang, Haiyue wrote: Hi Corey, Since IPMI 2.0 just defined minimum, no maximum: KCS/SMIC Input : Required: 40 bytes IPMI Message, minimum KCS/SMIC Output : Required: 38 bytes IPMI Message, minimum Yes, though there

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

2018-04-13 Thread Corey Minyard
On 04/07/2018 02:54 AM, Wang, Haiyue wrote: Hi Corey, Since IPMI 2.0 just defined minimum, no maximum: KCS/SMIC Input : Required: 40 bytes IPMI Message, minimum KCS/SMIC Output : Required: 38 bytes IPMI Message, minimum Yes, though there are practical maximums that are much smaller

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

2018-04-07 Thread Wang, Haiyue
Hi Corey, Since IPMI 2.0 just defined minimum, no maximum: KCS/SMIC Input : Required: 40 bytes IPMI Message, minimum KCS/SMIC Output : Required: 38 bytes IPMI Message, minimum We can enlarge the block size for avoiding waste, and make our driver support most worst message size

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

2018-04-06 Thread Wang, Haiyue
On 2018-04-07 05:47, Corey Minyard wrote: On 03/15/2018 07:20 AM, Haiyue Wang wrote: Allocate a continuous memory block for the three KCS data buffers with related index assignment. I'm finally getting to this. Is there a reason you want to do this?  In general, it's better to not try to

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

2018-04-06 Thread Corey Minyard
On 03/15/2018 07:20 AM, Haiyue Wang wrote: Allocate a continuous memory block for the three KCS data buffers with related index assignment. I'm finally getting to this. Is there a reason you want to do this?  In general, it's better to not try to outsmart your base system.  Depending on the

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

2018-04-03 Thread Wang, Haiyue
Just a small piece of cake, not so urgent. I just try to understand the code commitment process, such as time etc. :) Thanks! BR, Haiyue On 2018-04-04 02:45, Corey Minyard wrote: On 04/03/2018 01:00 AM, Wang, Haiyue wrote: Hi Corey, The 4.17 merge window is opened now, this patch is not

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

2018-04-03 Thread Corey Minyard
On 04/03/2018 01:00 AM, Wang, Haiyue wrote: Hi Corey, The 4.17 merge window is opened now, this patch is not yet in linux-next tree, so it will be merged into 4.18 ? Yeah, this came in kind of late, and I had some other critical things I was having to focus on, so I've been kind of out of

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

2018-04-03 Thread Wang, Haiyue
Hi Corey, The 4.17 merge window is opened now, this patch is not yet in linux-next tree, so it will be merged into 4.18 ? Thanks & Regards, Haiyue On 2018-03-15 20:20, Haiyue Wang wrote: Allocate a continuous memory block for the three KCS data buffers with related index assignment.