Re: [PATCH net] net/ncsi: Don't assume last available channel exists

2017-09-26 Thread Samuel Mendoza-Jonas
On Thu, 2017-09-21 at 18:11 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas > Date: Fri, 22 Sep 2017 11:00:00 +1000 > > > If we haven't configured a channel yet (or are in the process of doing > > so) we won't have a hot_channel - does it make more sense to > > - check against the hot_cha

Re: [PATCH net] net/ncsi: Don't assume last available channel exists

2017-09-21 Thread David Miller
From: Samuel Mendoza-Jonas Date: Fri, 22 Sep 2017 11:00:00 +1000 > If we haven't configured a channel yet (or are in the process of doing > so) we won't have a hot_channel - does it make more sense to > - check against the hot_channel as currently done, > - only check the filter size at configure

Re: [PATCH net] net/ncsi: Don't assume last available channel exists

2017-09-21 Thread Samuel Mendoza-Jonas
On Wed, 2017-09-20 at 16:05 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas > Date: Wed, 20 Sep 2017 14:12:51 +1000 > > > When handling new VLAN tags in NCSI we check the maximum allowed number > > of filters on the last active ("hot") channel. However if the 'add' > > callback is called

Re: [PATCH net] net/ncsi: Don't assume last available channel exists

2017-09-20 Thread David Miller
From: Samuel Mendoza-Jonas Date: Wed, 20 Sep 2017 14:12:51 +1000 > When handling new VLAN tags in NCSI we check the maximum allowed number > of filters on the last active ("hot") channel. However if the 'add' > callback is called before NCSI has configured a channel, this causes a > NULL derefere