Re: [PATCH resend] arch/sh: mach-kfr2r09: fix struct mtd_oob_ops build warning
On 11/2/18 12:52 AM, jacopo mondi wrote:
> Hi Randy,
>thanks for the patch.
>
> On Thu, Nov 01, 2018 at 04:38:30PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap
>>
>> arch/sh/boards/mach-kfr2r09/setup.c does not need to #include
>> , and doing so causes a build warning, so drop
>> that header file.
>>
>> In file included from ../arch/sh/boards/mach-kfr2r09/setup.c:28:
>> ../include/linux/mtd/onenand.h:225:12: warning: 'struct mtd_oob_ops'
>> declared inside parameter list will not be visible outside of this
>> definition or declaration
>> struct mtd_oob_ops *ops);
>>
>> Fixes: f3590dc32974 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera
>> driver")
>
> Not sure if this is worth pointing out, but this commit only resorts
> headers. The one introducing the warning is actually 33893d7aa.
>
> I felt like reporting this, as introducing a "Fixes" line for that
> commit too would help backporting maybe?
Oops, thanks, I'll fix that and send a v2 with your Ack.
> In any case:
> Acked-by: Jacopo Mondi
>
> Thanks
>j
>
>>
>> Reported-by: Geert Uytterhoeven
>> Suggested-by: Miquel Raynal
>> Signed-off-by: Randy Dunlap
>> Reviewed-by: Miquel Raynal
>> Cc: Yoshinori Sato
>> Cc: Rich Felker
>> Cc: Jacopo Mondi
>> Cc: Magnus Damm
>> Cc: linux-...@lists.infradead.org
>> Cc: linux...@vger.kernel.org
>> ---
>> arch/sh/boards/mach-kfr2r09/setup.c |1 -
>> 1 file changed, 1 deletion(-)
>>
>> --- linux-next-20181101.orig/arch/sh/boards/mach-kfr2r09/setup.c
>> +++ linux-next-20181101/arch/sh/boards/mach-kfr2r09/setup.c
>> @@ -25,7 +25,6 @@
>> #include
>> #include
>> #include
>> -#include
>> #include
>> #include
>> #include
>>
>>
--
~Randy
Re: [PATCH resend] arch/sh: mach-kfr2r09: fix struct mtd_oob_ops build warning
On 11/2/18 12:52 AM, jacopo mondi wrote:
> Hi Randy,
>thanks for the patch.
>
> On Thu, Nov 01, 2018 at 04:38:30PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap
>>
>> arch/sh/boards/mach-kfr2r09/setup.c does not need to #include
>> , and doing so causes a build warning, so drop
>> that header file.
>>
>> In file included from ../arch/sh/boards/mach-kfr2r09/setup.c:28:
>> ../include/linux/mtd/onenand.h:225:12: warning: 'struct mtd_oob_ops'
>> declared inside parameter list will not be visible outside of this
>> definition or declaration
>> struct mtd_oob_ops *ops);
>>
>> Fixes: f3590dc32974 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera
>> driver")
>
> Not sure if this is worth pointing out, but this commit only resorts
> headers. The one introducing the warning is actually 33893d7aa.
>
> I felt like reporting this, as introducing a "Fixes" line for that
> commit too would help backporting maybe?
Oops, thanks, I'll fix that and send a v2 with your Ack.
> In any case:
> Acked-by: Jacopo Mondi
>
> Thanks
>j
>
>>
>> Reported-by: Geert Uytterhoeven
>> Suggested-by: Miquel Raynal
>> Signed-off-by: Randy Dunlap
>> Reviewed-by: Miquel Raynal
>> Cc: Yoshinori Sato
>> Cc: Rich Felker
>> Cc: Jacopo Mondi
>> Cc: Magnus Damm
>> Cc: linux-...@lists.infradead.org
>> Cc: linux...@vger.kernel.org
>> ---
>> arch/sh/boards/mach-kfr2r09/setup.c |1 -
>> 1 file changed, 1 deletion(-)
>>
>> --- linux-next-20181101.orig/arch/sh/boards/mach-kfr2r09/setup.c
>> +++ linux-next-20181101/arch/sh/boards/mach-kfr2r09/setup.c
>> @@ -25,7 +25,6 @@
>> #include
>> #include
>> #include
>> -#include
>> #include
>> #include
>> #include
>>
>>
--
~Randy
Re: [PATCH resend] arch/sh: mach-kfr2r09: fix struct mtd_oob_ops build warning
Hi Randy,
thanks for the patch.
On Thu, Nov 01, 2018 at 04:38:30PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap
>
> arch/sh/boards/mach-kfr2r09/setup.c does not need to #include
> , and doing so causes a build warning, so drop
> that header file.
>
> In file included from ../arch/sh/boards/mach-kfr2r09/setup.c:28:
> ../include/linux/mtd/onenand.h:225:12: warning: 'struct mtd_oob_ops' declared
> inside parameter list will not be visible outside of this definition or
> declaration
> struct mtd_oob_ops *ops);
>
> Fixes: f3590dc32974 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera
> driver")
Not sure if this is worth pointing out, but this commit only resorts
headers. The one introducing the warning is actually 33893d7aa.
I felt like reporting this, as introducing a "Fixes" line for that
commit too would help backporting maybe?
In any case:
Acked-by: Jacopo Mondi
Thanks
j
>
> Reported-by: Geert Uytterhoeven
> Suggested-by: Miquel Raynal
> Signed-off-by: Randy Dunlap
> Reviewed-by: Miquel Raynal
> Cc: Yoshinori Sato
> Cc: Rich Felker
> Cc: Jacopo Mondi
> Cc: Magnus Damm
> Cc: linux-...@lists.infradead.org
> Cc: linux...@vger.kernel.org
> ---
> arch/sh/boards/mach-kfr2r09/setup.c |1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-next-20181101.orig/arch/sh/boards/mach-kfr2r09/setup.c
> +++ linux-next-20181101/arch/sh/boards/mach-kfr2r09/setup.c
> @@ -25,7 +25,6 @@
> #include
> #include
> #include
> -#include
> #include
> #include
> #include
>
>
signature.asc
Description: PGP signature
Re: [PATCH resend] arch/sh: mach-kfr2r09: fix struct mtd_oob_ops build warning
Hi Randy,
thanks for the patch.
On Thu, Nov 01, 2018 at 04:38:30PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap
>
> arch/sh/boards/mach-kfr2r09/setup.c does not need to #include
> , and doing so causes a build warning, so drop
> that header file.
>
> In file included from ../arch/sh/boards/mach-kfr2r09/setup.c:28:
> ../include/linux/mtd/onenand.h:225:12: warning: 'struct mtd_oob_ops' declared
> inside parameter list will not be visible outside of this definition or
> declaration
> struct mtd_oob_ops *ops);
>
> Fixes: f3590dc32974 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera
> driver")
Not sure if this is worth pointing out, but this commit only resorts
headers. The one introducing the warning is actually 33893d7aa.
I felt like reporting this, as introducing a "Fixes" line for that
commit too would help backporting maybe?
In any case:
Acked-by: Jacopo Mondi
Thanks
j
>
> Reported-by: Geert Uytterhoeven
> Suggested-by: Miquel Raynal
> Signed-off-by: Randy Dunlap
> Reviewed-by: Miquel Raynal
> Cc: Yoshinori Sato
> Cc: Rich Felker
> Cc: Jacopo Mondi
> Cc: Magnus Damm
> Cc: linux-...@lists.infradead.org
> Cc: linux...@vger.kernel.org
> ---
> arch/sh/boards/mach-kfr2r09/setup.c |1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-next-20181101.orig/arch/sh/boards/mach-kfr2r09/setup.c
> +++ linux-next-20181101/arch/sh/boards/mach-kfr2r09/setup.c
> @@ -25,7 +25,6 @@
> #include
> #include
> #include
> -#include
> #include
> #include
> #include
>
>
signature.asc
Description: PGP signature
