Re: [PATCH v06 12/36] x86 uapi asm/signal.h: use __kernel_size_t instead of size_t

[Dmitry V. Levin]

On Sun, Aug 06, 2017 at 06:44:03PM +0200, Mikko Rapeli wrote:
> Fixes userspace compilation error:
> 
> error: unknown type name ‘size_t’
> 
> Signed-off-by: Mikko Rapeli 
> Cc: Al Viro 
> Cc: Arnd Bergmann 
> Cc: H. Peter Anvin 
> ---
>  arch/x86/include/uapi/asm/signal.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/uapi/asm/signal.h 
> b/arch/x86/include/uapi/asm/signal.h
> index 8264f47cf53e..74346db30758 100644
> --- a/arch/x86/include/uapi/asm/signal.h
> +++ b/arch/x86/include/uapi/asm/signal.h
> @@ -127,7 +127,7 @@ struct sigaction {
>  typedef struct sigaltstack {
>   void __user *ss_sp;
>   int ss_flags;
> - size_t ss_size;
> + __kernel_size_t ss_size;
>  } stack_t;
>  
>  #endif /* __ASSEMBLY__ */

This is definitely wrong because sizeof(size_t) < sizeof(__kernel_size_t) on 
x32.
I submitted a different fix some time ago, see
http://lkml.kernel.org/r/20170303005930.ga10...@altlinux.org
and
http://lkml.kernel.org/r/20170303005950.gb10...@altlinux.org


-- 
ldv


signature.asc
Description: PGP signature

Re: [PATCH v06 12/36] x86 uapi asm/signal.h: use __kernel_size_t instead of size_t

[Dmitry V. Levin]

On Sun, Aug 06, 2017 at 06:44:03PM +0200, Mikko Rapeli wrote:
> Fixes userspace compilation error:
> 
> error: unknown type name ‘size_t’
> 
> Signed-off-by: Mikko Rapeli 
> Cc: Al Viro 
> Cc: Arnd Bergmann 
> Cc: H. Peter Anvin 
> ---
>  arch/x86/include/uapi/asm/signal.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/uapi/asm/signal.h 
> b/arch/x86/include/uapi/asm/signal.h
> index 8264f47cf53e..74346db30758 100644
> --- a/arch/x86/include/uapi/asm/signal.h
> +++ b/arch/x86/include/uapi/asm/signal.h
> @@ -127,7 +127,7 @@ struct sigaction {
>  typedef struct sigaltstack {
>   void __user *ss_sp;
>   int ss_flags;
> - size_t ss_size;
> + __kernel_size_t ss_size;
>  } stack_t;
>  
>  #endif /* __ASSEMBLY__ */

This is definitely wrong because sizeof(size_t) < sizeof(__kernel_size_t) on 
x32.
I submitted a different fix some time ago, see
http://lkml.kernel.org/r/20170303005930.ga10...@altlinux.org
and
http://lkml.kernel.org/r/20170303005950.gb10...@altlinux.org


-- 
ldv


signature.asc
Description: PGP signature

Re: [PATCH v06 12/36] x86 uapi asm/signal.h: use __kernel_size_t instead of size_t

[Arnd Bergmann]

On Sun, Aug 6, 2017 at 6:44 PM, Mikko Rapeli  wrote:
> Fixes userspace compilation error:
>
> error: unknown type name ‘size_t’
>
> Signed-off-by: Mikko Rapeli 
> Cc: Al Viro 
> Cc: Arnd Bergmann 
> Cc: H. Peter Anvin 
> ---
>  arch/x86/include/uapi/asm/signal.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/uapi/asm/signal.h 
> b/arch/x86/include/uapi/asm/signal.h
> index 8264f47cf53e..74346db30758 100644
> --- a/arch/x86/include/uapi/asm/signal.h
> +++ b/arch/x86/include/uapi/asm/signal.h
> @@ -127,7 +127,7 @@ struct sigaction {
>  typedef struct sigaltstack {
> void __user *ss_sp;
> int ss_flags;
> -   size_t ss_size;
> +   __kernel_size_t ss_size;
>  } stack_t;
>

In patch 14, you took a different approach based on an earlier comment
of mine, for the same structure. I think we should definitely take the same
approach for signal.h across all architectures, whichever we end up using.

  Arnd

Re: [PATCH v06 12/36] x86 uapi asm/signal.h: use __kernel_size_t instead of size_t

[Arnd Bergmann]

On Sun, Aug 6, 2017 at 6:44 PM, Mikko Rapeli  wrote:
> Fixes userspace compilation error:
>
> error: unknown type name ‘size_t’
>
> Signed-off-by: Mikko Rapeli 
> Cc: Al Viro 
> Cc: Arnd Bergmann 
> Cc: H. Peter Anvin 
> ---
>  arch/x86/include/uapi/asm/signal.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/uapi/asm/signal.h 
> b/arch/x86/include/uapi/asm/signal.h
> index 8264f47cf53e..74346db30758 100644
> --- a/arch/x86/include/uapi/asm/signal.h
> +++ b/arch/x86/include/uapi/asm/signal.h
> @@ -127,7 +127,7 @@ struct sigaction {
>  typedef struct sigaltstack {
> void __user *ss_sp;
> int ss_flags;
> -   size_t ss_size;
> +   __kernel_size_t ss_size;
>  } stack_t;
>

In patch 14, you took a different approach based on an earlier comment
of mine, for the same structure. I think we should definitely take the same
approach for signal.h across all architectures, whichever we end up using.

  Arnd