Re: [PATCH v06 19/36] uapi linux/omapfb.h: use __kernel_size_t instead of size_t

2017-08-08 Thread Dmitry V. Levin 
On Sun, Aug 06, 2017 at 06:44:10PM +0200, Mikko Rapeli wrote:
> Fixes userspace compilation error:
> 
> error: unknown type name ‘size_t’
> 
> Signed-off-by: Mikko Rapeli 
> Cc: linux-o...@vger.kernel.org
> Cc: Tomi Valkeinen 
> Cc: Aaro Koskinen 
> ---
>  include/uapi/linux/omapfb.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/omapfb.h b/include/uapi/linux/omapfb.h
> index 7c97bc00ac6d..b637a924618f 100644
> --- a/include/uapi/linux/omapfb.h
> +++ b/include/uapi/linux/omapfb.h
> @@ -181,7 +181,7 @@ struct omapfb_memory_read {
>   __u16 y;
>   __u16 w;
>   __u16 h;
> - size_t buffer_size;
> + __kernel_size_t buffer_size;
>   void __user *buffer;
>  };

You generally cannot replace size_t with __kernel_size_t in a header that
affects x32, but this case is really bad one: the kernel treats
struct omapfb_memory_read.buffer_size as __kernel_size_t, while
x32 userspace treats it as size_t.  As result, the offset of
struct omapfb_memory_read.buffer on x32 is different between the kernel
and userspace.

In other words, the whole thing seems to be totally broken on x32 already
and it's not important whether you use __kernel_size_t or
__kernel_uapi_size_t as a type of struct omapfb_memory_read.buffer_size.

This deserves a word in the commit message, though.


-- 
ldv


signature.asc
Description: PGP signature

Re: [PATCH v06 19/36] uapi linux/omapfb.h: use __kernel_size_t instead of size_t

2017-08-08 Thread Dmitry V. Levin 
On Sun, Aug 06, 2017 at 06:44:10PM +0200, Mikko Rapeli wrote:
> Fixes userspace compilation error:
> 
> error: unknown type name ‘size_t’
> 
> Signed-off-by: Mikko Rapeli 
> Cc: linux-o...@vger.kernel.org
> Cc: Tomi Valkeinen 
> Cc: Aaro Koskinen 
> ---
>  include/uapi/linux/omapfb.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/omapfb.h b/include/uapi/linux/omapfb.h
> index 7c97bc00ac6d..b637a924618f 100644
> --- a/include/uapi/linux/omapfb.h
> +++ b/include/uapi/linux/omapfb.h
> @@ -181,7 +181,7 @@ struct omapfb_memory_read {
>   __u16 y;
>   __u16 w;
>   __u16 h;
> - size_t buffer_size;
> + __kernel_size_t buffer_size;
>   void __user *buffer;
>  };

You generally cannot replace size_t with __kernel_size_t in a header that
affects x32, but this case is really bad one: the kernel treats
struct omapfb_memory_read.buffer_size as __kernel_size_t, while
x32 userspace treats it as size_t.  As result, the offset of
struct omapfb_memory_read.buffer on x32 is different between the kernel
and userspace.

In other words, the whole thing seems to be totally broken on x32 already
and it's not important whether you use __kernel_size_t or
__kernel_uapi_size_t as a type of struct omapfb_memory_read.buffer_size.

This deserves a word in the commit message, though.


-- 
ldv


signature.asc
Description: PGP signature

Re: [PATCH v06 19/36] uapi linux/omapfb.h: use __kernel_size_t instead of size_t

2017-08-07 Thread Arnd Bergmann 
On Sun, Aug 6, 2017 at 6:44 PM, Mikko Rapeli  wrote:
> Fixes userspace compilation error:
>
> error: unknown type name ‘size_t’
>
> Signed-off-by: Mikko Rapeli 
> Cc: linux-o...@vger.kernel.org
> Cc: Tomi Valkeinen 
> Cc: Aaro Koskinen 

Acked-by: Arnd Bergmann

Re: [PATCH v06 19/36] uapi linux/omapfb.h: use __kernel_size_t instead of size_t

2017-08-07 Thread Arnd Bergmann 
On Sun, Aug 6, 2017 at 6:44 PM, Mikko Rapeli  wrote:
> Fixes userspace compilation error:
>
> error: unknown type name ‘size_t’
>
> Signed-off-by: Mikko Rapeli 
> Cc: linux-o...@vger.kernel.org
> Cc: Tomi Valkeinen 
> Cc: Aaro Koskinen 

Acked-by: Arnd Bergmann