Re: [PATCH v1] i2c:i2c-stm32f7: fix setup structure

2017-10-06 Thread Pierre Yves MORDRET 


On 10/05/2017 01:14 PM, Wolfram Sang wrote:
> On Thu, Sep 21, 2017 at 03:30:09PM +0200, Pierre-Yves MORDRET wrote:
>> I2C drive setup structure is not properly allocated.
>> Make it static instead of pointer to store driver data.
>>
>> Signed-off-by: Pierre-Yves MORDRET 
> 
> Ouch! How did it work before?

Well yes it did. When it has been discovered during internal code review I was
skeptical but it turned out to be true. I tested on STM32 F7/H7 without any
trouble : scary !

> 
> Applied to for-current, thanks! Please provide a Fixes: tag next time,
> did this for you now.
> 
Sorry I wasn't aware about that. I gonna remember for the next time.
Thanks !

Py

Re: [PATCH v1] i2c:i2c-stm32f7: fix setup structure

2017-10-06 Thread Pierre Yves MORDRET 


On 10/05/2017 01:14 PM, Wolfram Sang wrote:
> On Thu, Sep 21, 2017 at 03:30:09PM +0200, Pierre-Yves MORDRET wrote:
>> I2C drive setup structure is not properly allocated.
>> Make it static instead of pointer to store driver data.
>>
>> Signed-off-by: Pierre-Yves MORDRET 
> 
> Ouch! How did it work before?

Well yes it did. When it has been discovered during internal code review I was
skeptical but it turned out to be true. I tested on STM32 F7/H7 without any
trouble : scary !

> 
> Applied to for-current, thanks! Please provide a Fixes: tag next time,
> did this for you now.
> 
Sorry I wasn't aware about that. I gonna remember for the next time.
Thanks !

Py

Re: [PATCH v1] i2c:i2c-stm32f7: fix setup structure

2017-10-05 Thread Wolfram Sang 
On Thu, Sep 21, 2017 at 03:30:09PM +0200, Pierre-Yves MORDRET wrote:
> I2C drive setup structure is not properly allocated.
> Make it static instead of pointer to store driver data.
> 
> Signed-off-by: Pierre-Yves MORDRET 

Ouch! How did it work before?

Applied to for-current, thanks! Please provide a Fixes: tag next time,
did this for you now.



signature.asc
Description: PGP signature

Re: [PATCH v1] i2c:i2c-stm32f7: fix setup structure

2017-10-05 Thread Wolfram Sang 
On Thu, Sep 21, 2017 at 03:30:09PM +0200, Pierre-Yves MORDRET wrote:
> I2C drive setup structure is not properly allocated.
> Make it static instead of pointer to store driver data.
> 
> Signed-off-by: Pierre-Yves MORDRET 

Ouch! How did it work before?

Applied to for-current, thanks! Please provide a Fixes: tag next time,
did this for you now.



signature.asc
Description: PGP signature