Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-18 Thread Greg KH
On Mon, Jul 17, 2017 at 08:19:45PM +0530, Gaurav Pathak wrote: > staging: rts5208: Fix coding style issue caught by checkpatch.pl related to > function name in debug print and shorten few lines over 80 char No, only do one-type-of-thing per patch. It would make sense to maybe fix an 80 char line

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-18 Thread Greg KH
On Mon, Jul 17, 2017 at 08:19:45PM +0530, Gaurav Pathak wrote: > staging: rts5208: Fix coding style issue caught by checkpatch.pl related to > function name in debug print and shorten few lines over 80 char No, only do one-type-of-thing per patch. It would make sense to maybe fix an 80 char line

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-17 Thread Greg KH
On Fri, Jul 14, 2017 at 07:38:43PM +0530, Gaurav Pathak wrote: > staging: rts5208: Refactored code to avoid few defects. That's the subject line, why repeat it here? Please put a "real" description of the patch here. > > Signed-off-by: Gaurav Pathak > --- > Hi,

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-17 Thread Greg KH
On Fri, Jul 14, 2017 at 07:38:43PM +0530, Gaurav Pathak wrote: > staging: rts5208: Refactored code to avoid few defects. That's the subject line, why repeat it here? Please put a "real" description of the patch here. > > Signed-off-by: Gaurav Pathak > --- > Hi, Gaurav hope this text appaers

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Greg KH
On Thu, Jul 13, 2017 at 09:30:20PM +0530, Gaurav Pathak wrote: > Adding public mailing list address and Joe. > > Hi Gerg, > > I am trying my best to avoid such silly mistakes, but this is first > time I am sending patch to a maintainer. Please disregard my > mistakes. > > I will send it to the

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Greg KH
On Thu, Jul 13, 2017 at 09:30:20PM +0530, Gaurav Pathak wrote: > Adding public mailing list address and Joe. > > Hi Gerg, > > I am trying my best to avoid such silly mistakes, but this is first > time I am sending patch to a maintainer. Please disregard my > mistakes. > > I will send it to the

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Gaurav Pathak
Adding public mailing list address and Joe. Hi Gerg, I am trying my best to avoid such silly mistakes, but this is first time I am sending patch to a maintainer. Please disregard my mistakes. I will send it to the correct mailing list, but when I ran get_maintainer.pl on my patch your Name

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Gaurav Pathak
Adding public mailing list address and Joe. Hi Gerg, I am trying my best to avoid such silly mistakes, but this is first time I am sending patch to a maintainer. Please disregard my mistakes. I will send it to the correct mailing list, but when I ran get_maintainer.pl on my patch your Name

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Greg KH
On Thu, Jul 13, 2017 at 08:02:20PM +0530, Gaurav Pathak wrote: > staging: rts5208: Fixed compiler errors for dev_dbg() That's not what this patch does :( Please also use the correct mailing list, scripts/get_maintainer.pl is your friend... thanks, greg k-h

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Greg KH
On Thu, Jul 13, 2017 at 08:02:20PM +0530, Gaurav Pathak wrote: > staging: rts5208: Fixed compiler errors for dev_dbg() That's not what this patch does :( Please also use the correct mailing list, scripts/get_maintainer.pl is your friend... thanks, greg k-h