Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-18 Thread Greg KH 
On Mon, Jul 17, 2017 at 08:19:45PM +0530, Gaurav Pathak wrote:
> staging: rts5208: Fix coding style issue caught by checkpatch.pl related to
> function name in debug print and shorten few lines over 80 char

No, only do one-type-of-thing per patch.  It would make sense to maybe
fix an 80 char line issue for a line you are fixing up for the function
name, but not for any other random line.

Please break this up into individual patches.

thanks,

greg k-h

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-18 Thread Greg KH 
On Mon, Jul 17, 2017 at 08:19:45PM +0530, Gaurav Pathak wrote:
> staging: rts5208: Fix coding style issue caught by checkpatch.pl related to
> function name in debug print and shorten few lines over 80 char

No, only do one-type-of-thing per patch.  It would make sense to maybe
fix an 80 char line issue for a line you are fixing up for the function
name, but not for any other random line.

Please break this up into individual patches.

thanks,

greg k-h

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-17 Thread Greg KH 
On Fri, Jul 14, 2017 at 07:38:43PM +0530, Gaurav Pathak wrote:
> staging: rts5208: Refactored code to avoid few defects.

That's the subject line, why repeat it here?

Please put a "real" description of the patch here.

> 
> Signed-off-by: Gaurav Pathak 
> ---
> Hi, Gaurav hope this text appaers in the email, and i put it at the right 
> place in patch.

You did, but why are you writing to yourself?

thanks,

greg k-h

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-17 Thread Greg KH 
On Fri, Jul 14, 2017 at 07:38:43PM +0530, Gaurav Pathak wrote:
> staging: rts5208: Refactored code to avoid few defects.

That's the subject line, why repeat it here?

Please put a "real" description of the patch here.

> 
> Signed-off-by: Gaurav Pathak 
> ---
> Hi, Gaurav hope this text appaers in the email, and i put it at the right 
> place in patch.

You did, but why are you writing to yourself?

thanks,

greg k-h

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Greg KH 
On Thu, Jul 13, 2017 at 09:30:20PM +0530, Gaurav Pathak wrote:
> Adding public mailing list address and Joe.
> 
> Hi Gerg,
> 
> I am trying my best to avoid such silly mistakes, but this is first
> time I am sending patch to a maintainer.  Please disregard my
> mistakes.
> 
> I will send it to the correct mailing list, but when I ran
> get_maintainer.pl on my patch your Name and email was displayed on
> top.

That's fine, but there was also another mailing list on that it showed
as well, right?  Please use that for patches for staging drivers.

thanks,

greg k-h

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Greg KH 
On Thu, Jul 13, 2017 at 09:30:20PM +0530, Gaurav Pathak wrote:
> Adding public mailing list address and Joe.
> 
> Hi Gerg,
> 
> I am trying my best to avoid such silly mistakes, but this is first
> time I am sending patch to a maintainer.  Please disregard my
> mistakes.
> 
> I will send it to the correct mailing list, but when I ran
> get_maintainer.pl on my patch your Name and email was displayed on
> top.

That's fine, but there was also another mailing list on that it showed
as well, right?  Please use that for patches for staging drivers.

thanks,

greg k-h

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Gaurav Pathak 
Adding public mailing list address and Joe.

Hi Gerg,

I am trying my best to avoid such silly mistakes, but this is first time I am 
sending patch to a maintainer.
Please disregard my mistakes.

I will send it to the correct mailing list, but when I ran get_maintainer.pl on 
my patch your Name and email was displayed on top.


On Thursday 13 July 2017 09:08 PM, Greg KH wrote:
> On Thu, Jul 13, 2017 at 08:40:26PM +0530, Gaurav Pathak wrote:
>> Hi Gerg,
>>
>> I am trying my best to avoid such silly mistakes, but this is first time I 
>> am sending patch to a maintainer.
>> Please disregard my mistakes.
>>
>> I will send it to the correct mailing list, but when I ran get_maintainer.pl 
>> on my patch your Name and email was displayed on top.
> 
>
> For some reason you sent this only to me, which is a bit rude to
> everyone else on the mailing list.  I'll be glad to respond if you
> resend it to everyone.
>
> thanks,
>
> greg k-h
>
>
>
>
> Great question, care to ask this on the  mailing list and CC me?  That
> way I can answer it in public to enable everyone else to know the answer, and
> let the search engines pick it up.
>
> Also, please read the following two links on why it is not good to
> directly email people:
>   http://www.arm.linux.org.uk/news/?newsitem=11
>   http://www.eyrie.org/~eagle/faqs/questions.html
>
> thanks,
>
> greg k-h

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Gaurav Pathak 
Adding public mailing list address and Joe.

Hi Gerg,

I am trying my best to avoid such silly mistakes, but this is first time I am 
sending patch to a maintainer.
Please disregard my mistakes.

I will send it to the correct mailing list, but when I ran get_maintainer.pl on 
my patch your Name and email was displayed on top.


On Thursday 13 July 2017 09:08 PM, Greg KH wrote:
> On Thu, Jul 13, 2017 at 08:40:26PM +0530, Gaurav Pathak wrote:
>> Hi Gerg,
>>
>> I am trying my best to avoid such silly mistakes, but this is first time I 
>> am sending patch to a maintainer.
>> Please disregard my mistakes.
>>
>> I will send it to the correct mailing list, but when I ran get_maintainer.pl 
>> on my patch your Name and email was displayed on top.
> 
>
> For some reason you sent this only to me, which is a bit rude to
> everyone else on the mailing list.  I'll be glad to respond if you
> resend it to everyone.
>
> thanks,
>
> greg k-h
>
>
>
>
> Great question, care to ask this on the  mailing list and CC me?  That
> way I can answer it in public to enable everyone else to know the answer, and
> let the search engines pick it up.
>
> Also, please read the following two links on why it is not good to
> directly email people:
>   http://www.arm.linux.org.uk/news/?newsitem=11
>   http://www.eyrie.org/~eagle/faqs/questions.html
>
> thanks,
>
> greg k-h

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Greg KH 
On Thu, Jul 13, 2017 at 08:02:20PM +0530, Gaurav Pathak wrote:
> staging: rts5208: Fixed compiler errors for dev_dbg()

That's not what this patch does :(

Please also use the correct mailing list, scripts/get_maintainer.pl is
your friend...

thanks,

greg k-h

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Greg KH 
On Thu, Jul 13, 2017 at 08:02:20PM +0530, Gaurav Pathak wrote:
> staging: rts5208: Fixed compiler errors for dev_dbg()

That's not what this patch does :(

Please also use the correct mailing list, scripts/get_maintainer.pl is
your friend...

thanks,

greg k-h