Re: [PATCH v1 1/4] um: Fix ptrace GETREGS/SETREGS bugs

2015-12-21 Thread Mickaël Salaün
On 21/12/2015 11:13, Richard Weinberger wrote: > Am 21.12.2015 um 10:23 schrieb Mickaël Salaün: > Doesn't this break the support for changing syscall numbers using > PTRACE_SETREGS? The logic is unchanged except updating the UPT_SYSCALL_NR before syscall_trace_enter(). I

Re: [PATCH v1 1/4] um: Fix ptrace GETREGS/SETREGS bugs

2015-12-21 Thread Richard Weinberger
Am 21.12.2015 um 10:23 schrieb Mickaël Salaün: Doesn't this break the support for changing syscall numbers using PTRACE_SETREGS? >>> >>> The logic is unchanged except updating the UPT_SYSCALL_NR before >>> syscall_trace_enter(). I did my last tests with the x86_32 subarchitecture >>>

Re: [PATCH v1 1/4] um: Fix ptrace GETREGS/SETREGS bugs

2015-12-21 Thread Mickaël Salaün
On 21/12/2015 10:00, Richard Weinberger wrote: > [sending the mail again, Thunderbird crashed :-\] > > Am 21.12.2015 um 09:49 schrieb Mickaël Salaün: >> >> On 21/12/2015 01:20, Richard Weinberger wrote: >>> Am 21.12.2015 um 01:03 schrieb Mickaël Salaün: diff --git

Re: [PATCH v1 1/4] um: Fix ptrace GETREGS/SETREGS bugs

2015-12-21 Thread Mickaël Salaün
On 21/12/2015 01:20, Richard Weinberger wrote: > Am 21.12.2015 um 01:03 schrieb Mickaël Salaün: >> diff --git a/arch/um/kernel/skas/syscall.c b/arch/um/kernel/skas/syscall.c >> index 1683b8e..65f0d1a 100644 >> --- a/arch/um/kernel/skas/syscall.c >> +++ b/arch/um/kernel/skas/syscall.c >> @@ -7,6

Re: [PATCH v1 1/4] um: Fix ptrace GETREGS/SETREGS bugs

2015-12-21 Thread Richard Weinberger
[sending the mail again, Thunderbird crashed :-\] Am 21.12.2015 um 09:49 schrieb Mickaël Salaün: > > On 21/12/2015 01:20, Richard Weinberger wrote: >> Am 21.12.2015 um 01:03 schrieb Mickaël Salaün: >>> diff --git a/arch/um/kernel/skas/syscall.c b/arch/um/kernel/skas/syscall.c >>> index

Re: [PATCH v1 1/4] um: Fix ptrace GETREGS/SETREGS bugs

2015-12-21 Thread Richard Weinberger
Hi! Am 21.12.2015 um 09:49 schrieb Mickaël Salaün: > > On 21/12/2015 01:20, Richard Weinberger wrote: >> Am 21.12.2015 um 01:03 schrieb Mickaël Salaün: >>> diff --git a/arch/um/kernel/skas/syscall.c b/arch/um/kernel/skas/syscall.c >>> index 1683b8e..65f0d1a 100644 >>> ---

Re: [PATCH v1 1/4] um: Fix ptrace GETREGS/SETREGS bugs

2015-12-21 Thread Mickaël Salaün
On 21/12/2015 11:13, Richard Weinberger wrote: > Am 21.12.2015 um 10:23 schrieb Mickaël Salaün: > Doesn't this break the support for changing syscall numbers using > PTRACE_SETREGS? The logic is unchanged except updating the UPT_SYSCALL_NR before syscall_trace_enter(). I

Re: [PATCH v1 1/4] um: Fix ptrace GETREGS/SETREGS bugs

2015-12-21 Thread Mickaël Salaün
On 21/12/2015 01:20, Richard Weinberger wrote: > Am 21.12.2015 um 01:03 schrieb Mickaël Salaün: >> diff --git a/arch/um/kernel/skas/syscall.c b/arch/um/kernel/skas/syscall.c >> index 1683b8e..65f0d1a 100644 >> --- a/arch/um/kernel/skas/syscall.c >> +++ b/arch/um/kernel/skas/syscall.c >> @@ -7,6

Re: [PATCH v1 1/4] um: Fix ptrace GETREGS/SETREGS bugs

2015-12-21 Thread Richard Weinberger
Am 21.12.2015 um 10:23 schrieb Mickaël Salaün: Doesn't this break the support for changing syscall numbers using PTRACE_SETREGS? >>> >>> The logic is unchanged except updating the UPT_SYSCALL_NR before >>> syscall_trace_enter(). I did my last tests with the x86_32 subarchitecture >>>

Re: [PATCH v1 1/4] um: Fix ptrace GETREGS/SETREGS bugs

2015-12-21 Thread Richard Weinberger
[sending the mail again, Thunderbird crashed :-\] Am 21.12.2015 um 09:49 schrieb Mickaël Salaün: > > On 21/12/2015 01:20, Richard Weinberger wrote: >> Am 21.12.2015 um 01:03 schrieb Mickaël Salaün: >>> diff --git a/arch/um/kernel/skas/syscall.c b/arch/um/kernel/skas/syscall.c >>> index

Re: [PATCH v1 1/4] um: Fix ptrace GETREGS/SETREGS bugs

2015-12-21 Thread Mickaël Salaün
On 21/12/2015 10:00, Richard Weinberger wrote: > [sending the mail again, Thunderbird crashed :-\] > > Am 21.12.2015 um 09:49 schrieb Mickaël Salaün: >> >> On 21/12/2015 01:20, Richard Weinberger wrote: >>> Am 21.12.2015 um 01:03 schrieb Mickaël Salaün: diff --git

Re: [PATCH v1 1/4] um: Fix ptrace GETREGS/SETREGS bugs

2015-12-21 Thread Richard Weinberger
Hi! Am 21.12.2015 um 09:49 schrieb Mickaël Salaün: > > On 21/12/2015 01:20, Richard Weinberger wrote: >> Am 21.12.2015 um 01:03 schrieb Mickaël Salaün: >>> diff --git a/arch/um/kernel/skas/syscall.c b/arch/um/kernel/skas/syscall.c >>> index 1683b8e..65f0d1a 100644 >>> ---

Re: [PATCH v1 1/4] um: Fix ptrace GETREGS/SETREGS bugs

2015-12-20 Thread Richard Weinberger
Am 21.12.2015 um 01:03 schrieb Mickaël Salaün: > This fix two related bugs: > * PTRACE_GETREGS doesn't get the right orig_ax (syscall) value > * PTRACE_SETREGS can't set the orig_ax value (erased by initial value) > > Remove the now useless and error-prone get_syscall(). > > Signed-off-by:

Re: [PATCH v1 1/4] um: Fix ptrace GETREGS/SETREGS bugs

2015-12-20 Thread Richard Weinberger
Am 21.12.2015 um 01:03 schrieb Mickaël Salaün: > This fix two related bugs: > * PTRACE_GETREGS doesn't get the right orig_ax (syscall) value > * PTRACE_SETREGS can't set the orig_ax value (erased by initial value) > > Remove the now useless and error-prone get_syscall(). > > Signed-off-by: