Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-19 Thread Yi Sun
Hi, On 18-09-17 20:54:52, Yi Sun wrote: > On 18-09-14 12:42:33, Thomas Gleixner wrote: > > On Fri, 14 Sep 2018, Yi Sun wrote: > > > > > +static void hv_notify_long_spin_wait(void) > > > > > +{ > > > > > + u64 input = spin_wait_info | 0x; > > > > > > > > What? The result is

Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-19 Thread Yi Sun
Hi, On 18-09-17 20:54:52, Yi Sun wrote: > On 18-09-14 12:42:33, Thomas Gleixner wrote: > > On Fri, 14 Sep 2018, Yi Sun wrote: > > > > > +static void hv_notify_long_spin_wait(void) > > > > > +{ > > > > > + u64 input = spin_wait_info | 0x; > > > > > > > > What? The result is

Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-17 Thread Yi Sun
On 18-09-14 12:42:33, Thomas Gleixner wrote: > On Fri, 14 Sep 2018, Yi Sun wrote: > > > > +static void hv_notify_long_spin_wait(void) > > > > +{ > > > > + u64 input = spin_wait_info | 0x; > > > > > > What? The result is always 0x . > > > > > Oh, sorry

Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-17 Thread Yi Sun
On 18-09-14 12:42:33, Thomas Gleixner wrote: > On Fri, 14 Sep 2018, Yi Sun wrote: > > > > +static void hv_notify_long_spin_wait(void) > > > > +{ > > > > + u64 input = spin_wait_info | 0x; > > > > > > What? The result is always 0x . > > > > > Oh, sorry

Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-14 Thread Thomas Gleixner
On Fri, 14 Sep 2018, Yi Sun wrote: > > > +static void hv_notify_long_spin_wait(void) > > > +{ > > > + u64 input = spin_wait_info | 0x; > > > > What? The result is always 0x . > > > Oh, sorry for such error. > > > > + spin_wait_info++; > > > +

Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-14 Thread Thomas Gleixner
On Fri, 14 Sep 2018, Yi Sun wrote: > > > +static void hv_notify_long_spin_wait(void) > > > +{ > > > + u64 input = spin_wait_info | 0x; > > > > What? The result is always 0x . > > > Oh, sorry for such error. > > > > + spin_wait_info++; > > > +

Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-14 Thread Yi Sun
On 18-09-13 13:24:07, Thomas Gleixner wrote: > On Thu, 13 Sep 2018, Yi Sun wrote: > > +++ b/arch/x86/hyperv/hv_spinlock.c > > @@ -0,0 +1,99 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +/* > > + * Hyper-V specific spinlock code. > > + * > > + * Copyright (C) 2018, Intel, Inc. > > + * > >

Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-14 Thread Yi Sun
On 18-09-13 13:24:07, Thomas Gleixner wrote: > On Thu, 13 Sep 2018, Yi Sun wrote: > > +++ b/arch/x86/hyperv/hv_spinlock.c > > @@ -0,0 +1,99 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +/* > > + * Hyper-V specific spinlock code. > > + * > > + * Copyright (C) 2018, Intel, Inc. > > + * > >

Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-14 Thread Yi Sun
On 18-09-13 13:06:13, Thomas Gleixner wrote: > On Thu, 13 Sep 2018, Yi Sun wrote: > > +#include > > > > /* representing HT siblings of each logical CPU */ > > DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_sibling_map); > > @@ -1335,6 +1336,7 @@ void __init native_smp_prepare_boot_cpu(void) >

Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-14 Thread Yi Sun
On 18-09-13 13:06:13, Thomas Gleixner wrote: > On Thu, 13 Sep 2018, Yi Sun wrote: > > +#include > > > > /* representing HT siblings of each logical CPU */ > > DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_sibling_map); > > @@ -1335,6 +1336,7 @@ void __init native_smp_prepare_boot_cpu(void) >

Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-13 Thread kbuild test robot
Hi Yi, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/x86/core] [also build test ERROR on v4.19-rc3 next-20180913] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-13 Thread kbuild test robot
Hi Yi, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/x86/core] [also build test ERROR on v4.19-rc3 next-20180913] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-13 Thread kbuild test robot
Hi Yi, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/x86/core] [also build test ERROR on v4.19-rc3 next-20180913] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-13 Thread kbuild test robot
Hi Yi, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/x86/core] [also build test ERROR on v4.19-rc3 next-20180913] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-13 Thread Thomas Gleixner
On Thu, 13 Sep 2018, Yi Sun wrote: > +++ b/arch/x86/hyperv/hv_spinlock.c > @@ -0,0 +1,99 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +/* > + * Hyper-V specific spinlock code. > + * > + * Copyright (C) 2018, Intel, Inc. > + * > + * Author : Yi Sun > + * > + * This program is free software; you

Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-13 Thread Thomas Gleixner
On Thu, 13 Sep 2018, Yi Sun wrote: > +++ b/arch/x86/hyperv/hv_spinlock.c > @@ -0,0 +1,99 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +/* > + * Hyper-V specific spinlock code. > + * > + * Copyright (C) 2018, Intel, Inc. > + * > + * Author : Yi Sun > + * > + * This program is free software; you

Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-13 Thread Thomas Gleixner
On Thu, 13 Sep 2018, Yi Sun wrote: > +#include > > /* representing HT siblings of each logical CPU */ > DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_sibling_map); > @@ -1335,6 +1336,7 @@ void __init native_smp_prepare_boot_cpu(void) > /* already set me in cpu_online_mask in

Re: [PATCH v1 2/3] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-13 Thread Thomas Gleixner
On Thu, 13 Sep 2018, Yi Sun wrote: > +#include > > /* representing HT siblings of each logical CPU */ > DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_sibling_map); > @@ -1335,6 +1336,7 @@ void __init native_smp_prepare_boot_cpu(void) > /* already set me in cpu_online_mask in