Re: [PATCH v10 3/7] PCI/ERR: add mutex to synchronize recovery

2018-02-22 Thread poza 

On 2018-02-23 00:06, Christoph Hellwig wrote:

On Thu, Feb 22, 2018 at 09:32:08PM +0530, Oza Pawandeep wrote:

This patch protects pci_do_recovery with mutex.


Do we really want a global mutex for this and not one per root complex
at very least?


This protects pcie_do_recovery, which is called by port service drivers.
mainly aer and dpc as of now. so the association is not root complex 
agents

instead service drivers who attempts to do link recovery.

so I think we are good here.

Re: [PATCH v10 3/7] PCI/ERR: add mutex to synchronize recovery

2018-02-22 Thread Christoph Hellwig 
On Thu, Feb 22, 2018 at 09:32:08PM +0530, Oza Pawandeep wrote:
> This patch protects pci_do_recovery with mutex.

Do we really want a global mutex for this and not one per root complex
at very least?