Re: [PATCH v10 6/8] media: i2c: Add TDA1997x HDMI receiver driver

2018-02-14 Thread Hans Verkuil
On 14/02/18 16:46, Tim Harvey wrote: > On Wed, Feb 14, 2018 at 6:08 AM, Hans Verkuil wrote: >> Hi Tim, >> >> On 12/02/18 23:27, Tim Harvey wrote: >>> On Fri, Feb 9, 2018 at 12:08 AM, Hans Verkuil wrote: Hi Tim, We're almost there. Two more comments: On 02/09/2018 07:32 AM

Re: [PATCH v10 6/8] media: i2c: Add TDA1997x HDMI receiver driver

2018-02-14 Thread Tim Harvey
On Wed, Feb 14, 2018 at 6:08 AM, Hans Verkuil wrote: > Hi Tim, > > On 12/02/18 23:27, Tim Harvey wrote: >> On Fri, Feb 9, 2018 at 12:08 AM, Hans Verkuil wrote: >>> Hi Tim, >>> >>> We're almost there. Two more comments: >>> >>> On 02/09/2018 07:32 AM, Tim Harvey wrote: +static int +tda19

Re: [PATCH v10 6/8] media: i2c: Add TDA1997x HDMI receiver driver

2018-02-14 Thread Hans Verkuil
Hi Tim, On 12/02/18 23:27, Tim Harvey wrote: > On Fri, Feb 9, 2018 at 12:08 AM, Hans Verkuil wrote: >> Hi Tim, >> >> We're almost there. Two more comments: >> >> On 02/09/2018 07:32 AM, Tim Harvey wrote: >>> +static int >>> +tda1997x_detect_std(struct tda1997x_state *state, >>> +

Re: [PATCH v10 6/8] media: i2c: Add TDA1997x HDMI receiver driver

2018-02-12 Thread Tim Harvey
On Fri, Feb 9, 2018 at 12:08 AM, Hans Verkuil wrote: > Hi Tim, > > We're almost there. Two more comments: > > On 02/09/2018 07:32 AM, Tim Harvey wrote: >> +static int >> +tda1997x_detect_std(struct tda1997x_state *state, >> + struct v4l2_dv_timings *timings) >> +{ >> + struct v

Re: [PATCH v10 6/8] media: i2c: Add TDA1997x HDMI receiver driver

2018-02-09 Thread Hans Verkuil
Hi Tim, We're almost there. Two more comments: On 02/09/2018 07:32 AM, Tim Harvey wrote: > +static int > +tda1997x_detect_std(struct tda1997x_state *state, > + struct v4l2_dv_timings *timings) > +{ > + struct v4l2_subdev *sd = &state->sd; > + u32 vper; > + u16 hper; >