Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-06 Thread Gleb Natapov
On Wed, Mar 06, 2013 at 04:48:17AM -0500, Paolo Bonzini wrote: > > > On Wed, Mar 06, 2013 at 10:07:31AM +0100, Paolo Bonzini wrote: > > > Il 06/03/2013 09:56, Hu Tao ha scritto: > > > >> > > > > >> > Something like this should work (in SeaBIOS's > > > >> > src/acpi-dsdt-isa.dsl): > > > >> > > >

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-06 Thread Paolo Bonzini
> On Wed, Mar 06, 2013 at 10:07:31AM +0100, Paolo Bonzini wrote: > > Il 06/03/2013 09:56, Hu Tao ha scritto: > > >> > > > >> > Something like this should work (in SeaBIOS's > > >> > src/acpi-dsdt-isa.dsl): > > >> > > > >> > Device(PEVT) { > > >> > Name(_HID, EisaId("QEMU0001")) > >

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-06 Thread Gleb Natapov
On Wed, Mar 06, 2013 at 10:07:31AM +0100, Paolo Bonzini wrote: > Il 06/03/2013 09:56, Hu Tao ha scritto: > >> > > >> > Something like this should work (in SeaBIOS's src/acpi-dsdt-isa.dsl): > >> > > >> > Device(PEVT) { > >> > Name(_HID, EisaId("QEMU0001")) > >> >

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-06 Thread Gleb Natapov
On Wed, Mar 06, 2013 at 04:46:58PM +0800, Hu Tao wrote: > On Sun, Mar 03, 2013 at 11:17:38AM +0200, Gleb Natapov wrote: > > On Thu, Feb 28, 2013 at 08:13:10PM +0800, Hu Tao wrote: > > > This series implements a new interface, kvm pv event, to notify host when > > > some events happen in guest.

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-06 Thread Paolo Bonzini
Il 06/03/2013 09:56, Hu Tao ha scritto: >> > >> > Something like this should work (in SeaBIOS's src/acpi-dsdt-isa.dsl): >> > >> > Device(PEVT) { >> > Name(_HID, EisaId("QEMU0001")) >> > OperationRegion(PEOR, SystemIO, 0x505, 0x01) >> > Field(PEOR, ByteAcc, NoLock,

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-06 Thread Hu Tao
Hi, On Mon, Mar 04, 2013 at 11:05:37AM +0100, Paolo Bonzini wrote: > Il 03/03/2013 10:17, Gleb Natapov ha scritto: > > On Thu, Feb 28, 2013 at 08:13:10PM +0800, Hu Tao wrote: > >> This series implements a new interface, kvm pv event, to notify host when > >> some events happen in guest. Right now

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-06 Thread Hu Tao
On Sun, Mar 03, 2013 at 11:17:38AM +0200, Gleb Natapov wrote: > On Thu, Feb 28, 2013 at 08:13:10PM +0800, Hu Tao wrote: > > This series implements a new interface, kvm pv event, to notify host when > > some events happen in guest. Right now there is one supported event: guest > > panic. > > >

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-06 Thread Hu Tao
On Sun, Mar 03, 2013 at 11:17:38AM +0200, Gleb Natapov wrote: On Thu, Feb 28, 2013 at 08:13:10PM +0800, Hu Tao wrote: This series implements a new interface, kvm pv event, to notify host when some events happen in guest. Right now there is one supported event: guest panic. What other

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-06 Thread Hu Tao
Hi, On Mon, Mar 04, 2013 at 11:05:37AM +0100, Paolo Bonzini wrote: Il 03/03/2013 10:17, Gleb Natapov ha scritto: On Thu, Feb 28, 2013 at 08:13:10PM +0800, Hu Tao wrote: This series implements a new interface, kvm pv event, to notify host when some events happen in guest. Right now there is

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-06 Thread Paolo Bonzini
Il 06/03/2013 09:56, Hu Tao ha scritto: Something like this should work (in SeaBIOS's src/acpi-dsdt-isa.dsl): Device(PEVT) { Name(_HID, EisaId(QEMU0001)) OperationRegion(PEOR, SystemIO, 0x505, 0x01) Field(PEOR, ByteAcc, NoLock, Preserve) {

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-06 Thread Gleb Natapov
On Wed, Mar 06, 2013 at 04:46:58PM +0800, Hu Tao wrote: On Sun, Mar 03, 2013 at 11:17:38AM +0200, Gleb Natapov wrote: On Thu, Feb 28, 2013 at 08:13:10PM +0800, Hu Tao wrote: This series implements a new interface, kvm pv event, to notify host when some events happen in guest. Right now

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-06 Thread Gleb Natapov
On Wed, Mar 06, 2013 at 10:07:31AM +0100, Paolo Bonzini wrote: Il 06/03/2013 09:56, Hu Tao ha scritto: Something like this should work (in SeaBIOS's src/acpi-dsdt-isa.dsl): Device(PEVT) { Name(_HID, EisaId(QEMU0001)) OperationRegion(PEOR, SystemIO, 0x505,

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-06 Thread Paolo Bonzini
On Wed, Mar 06, 2013 at 10:07:31AM +0100, Paolo Bonzini wrote: Il 06/03/2013 09:56, Hu Tao ha scritto: Something like this should work (in SeaBIOS's src/acpi-dsdt-isa.dsl): Device(PEVT) { Name(_HID, EisaId(QEMU0001)) OperationRegion(PEOR,

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-06 Thread Gleb Natapov
On Wed, Mar 06, 2013 at 04:48:17AM -0500, Paolo Bonzini wrote: On Wed, Mar 06, 2013 at 10:07:31AM +0100, Paolo Bonzini wrote: Il 06/03/2013 09:56, Hu Tao ha scritto: Something like this should work (in SeaBIOS's src/acpi-dsdt-isa.dsl): Device(PEVT) {

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Paolo Bonzini
Il 04/03/2013 12:52, Gleb Natapov ha scritto: > > Same here, you can remove the panic event port and add debugcon at > > 0x505. That's the problematic case. But if the user goes to that > > length, I think we can honestly say we don't care. > > IMO there is a big difference between well know

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Gleb Natapov
On Mon, Mar 04, 2013 at 12:35:08PM +0100, Paolo Bonzini wrote: > Il 04/03/2013 12:20, Gleb Natapov ha scritto: > > On Mon, Mar 04, 2013 at 12:10:58PM +0100, Paolo Bonzini wrote: > >>> It is additional device that > >>> may or may not be present depending on a command line. So what if > >>> someone

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Paolo Bonzini
Il 04/03/2013 12:20, Gleb Natapov ha scritto: > On Mon, Mar 04, 2013 at 12:10:58PM +0100, Paolo Bonzini wrote: >>> It is additional device that >>> may or may not be present depending on a command line. So what if >>> someone configures debugcon or debugexit to use this port? >> >> I haven't

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Gleb Natapov
On Mon, Mar 04, 2013 at 12:10:58PM +0100, Paolo Bonzini wrote: > Il 04/03/2013 11:59, Gleb Natapov ha scritto: > > > I want to make the ioport configurable in the device, but the PIIX and > > > ICH9 (which are what the DSDT is written for) will always use port 0x505. > > > > But the device is not

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Gleb Natapov
On Mon, Mar 04, 2013 at 11:05:37AM +0100, Paolo Bonzini wrote: > > Guest uses acpi_get_devices() to discover a platform device by > > its name (QEMU0001). Then you put the driver for the platform device > > into drivers/platform/x86/ and QEMU/kvm/Xen all will be able to use it. > > Just to

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Paolo Bonzini
Il 04/03/2013 11:59, Gleb Natapov ha scritto: > > I want to make the ioport configurable in the device, but the PIIX and > > ICH9 (which are what the DSDT is written for) will always use port 0x505. > > But the device is not part of PIIX or ICH9. So is kvmclock, or kvmvapic. I think it makes

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Gleb Natapov
On Mon, Mar 04, 2013 at 11:49:07AM +0100, Paolo Bonzini wrote: > Il 04/03/2013 11:43, Gleb Natapov ha scritto: > > > Anyhow, this does not apply to the next submission of this series. I > > > think we can agree to the compromise of using ACPI but still read the > > > port in _STA. > > > > If you

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Paolo Bonzini
Il 04/03/2013 11:43, Gleb Natapov ha scritto: > > Anyhow, this does not apply to the next submission of this series. I > > think we can agree to the compromise of using ACPI but still read the > > port in _STA. > > If you want to make ioport configurable I do not see how can we avoid > patching.

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Gleb Natapov
On Mon, Mar 04, 2013 at 11:28:05AM +0100, Paolo Bonzini wrote: > Il 04/03/2013 11:21, Gleb Natapov ha scritto: > >> > Just to clarify it for Hu Tao, the read from a random ioport is how the > >> > ACPI code will detect presence of the device. > >> > > > Actually no (at least in the long run, for

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Paolo Bonzini
Il 03/03/2013 10:17, Gleb Natapov ha scritto: > On Thu, Feb 28, 2013 at 08:13:10PM +0800, Hu Tao wrote: >> This series implements a new interface, kvm pv event, to notify host when >> some events happen in guest. Right now there is one supported event: guest >> panic. >> > What other event do you

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Paolo Bonzini
Il 03/03/2013 10:17, Gleb Natapov ha scritto: On Thu, Feb 28, 2013 at 08:13:10PM +0800, Hu Tao wrote: This series implements a new interface, kvm pv event, to notify host when some events happen in guest. Right now there is one supported event: guest panic. What other event do you have in

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Gleb Natapov
On Mon, Mar 04, 2013 at 11:28:05AM +0100, Paolo Bonzini wrote: Il 04/03/2013 11:21, Gleb Natapov ha scritto: Just to clarify it for Hu Tao, the read from a random ioport is how the ACPI code will detect presence of the device. Actually no (at least in the long run, for the first

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Paolo Bonzini
Il 04/03/2013 11:43, Gleb Natapov ha scritto: Anyhow, this does not apply to the next submission of this series. I think we can agree to the compromise of using ACPI but still read the port in _STA. If you want to make ioport configurable I do not see how can we avoid patching. I want

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Gleb Natapov
On Mon, Mar 04, 2013 at 11:49:07AM +0100, Paolo Bonzini wrote: Il 04/03/2013 11:43, Gleb Natapov ha scritto: Anyhow, this does not apply to the next submission of this series. I think we can agree to the compromise of using ACPI but still read the port in _STA. If you want to make

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Paolo Bonzini
Il 04/03/2013 11:59, Gleb Natapov ha scritto: I want to make the ioport configurable in the device, but the PIIX and ICH9 (which are what the DSDT is written for) will always use port 0x505. But the device is not part of PIIX or ICH9. So is kvmclock, or kvmvapic. I think it makes sense to

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Gleb Natapov
On Mon, Mar 04, 2013 at 11:05:37AM +0100, Paolo Bonzini wrote: Guest uses acpi_get_devices() to discover a platform device by its name (QEMU0001). Then you put the driver for the platform device into drivers/platform/x86/ and QEMU/kvm/Xen all will be able to use it. Just to clarify it

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Gleb Natapov
On Mon, Mar 04, 2013 at 12:10:58PM +0100, Paolo Bonzini wrote: Il 04/03/2013 11:59, Gleb Natapov ha scritto: I want to make the ioport configurable in the device, but the PIIX and ICH9 (which are what the DSDT is written for) will always use port 0x505. But the device is not part of

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Paolo Bonzini
Il 04/03/2013 12:20, Gleb Natapov ha scritto: On Mon, Mar 04, 2013 at 12:10:58PM +0100, Paolo Bonzini wrote: It is additional device that may or may not be present depending on a command line. So what if someone configures debugcon or debugexit to use this port? I haven't checked if

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Gleb Natapov
On Mon, Mar 04, 2013 at 12:35:08PM +0100, Paolo Bonzini wrote: Il 04/03/2013 12:20, Gleb Natapov ha scritto: On Mon, Mar 04, 2013 at 12:10:58PM +0100, Paolo Bonzini wrote: It is additional device that may or may not be present depending on a command line. So what if someone configures

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-04 Thread Paolo Bonzini
Il 04/03/2013 12:52, Gleb Natapov ha scritto: Same here, you can remove the panic event port and add debugcon at 0x505. That's the problematic case. But if the user goes to that length, I think we can honestly say we don't care. IMO there is a big difference between well know serial ISA

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-03 Thread Gleb Natapov
On Thu, Feb 28, 2013 at 08:13:10PM +0800, Hu Tao wrote: > This series implements a new interface, kvm pv event, to notify host when > some events happen in guest. Right now there is one supported event: guest > panic. > What other event do you have in mind? Is interface generic enough to

Re: [PATCH v13 0/8] pv event interface between host and guest

2013-03-03 Thread Gleb Natapov
On Thu, Feb 28, 2013 at 08:13:10PM +0800, Hu Tao wrote: This series implements a new interface, kvm pv event, to notify host when some events happen in guest. Right now there is one supported event: guest panic. What other event do you have in mind? Is interface generic enough to accommodate