Re: [PATCH v14 00/11] livepatch: Atomic replace feature

2018-12-06 Thread Joe Lawrence
On 12/06/2018 07:37 AM, Petr Mladek wrote: > On Thu 2018-12-06 11:15:55, Petr Mladek wrote: >> On Thu 2018-12-06 10:32:00, Miroslav Benes wrote: >>> > I don't have many code comments as the changes appear to safely and > correctly do what the say. (We are at v14 after all :) I mainly

Re: [PATCH v14 00/11] livepatch: Atomic replace feature

2018-12-06 Thread Joe Lawrence
On 12/06/2018 07:37 AM, Petr Mladek wrote: > On Thu 2018-12-06 11:15:55, Petr Mladek wrote: >> On Thu 2018-12-06 10:32:00, Miroslav Benes wrote: >>> > I don't have many code comments as the changes appear to safely and > correctly do what the say. (We are at v14 after all :) I mainly

Re: [PATCH v14 00/11] livepatch: Atomic replace feature

2018-12-06 Thread Petr Mladek
On Thu 2018-12-06 11:15:55, Petr Mladek wrote: > On Thu 2018-12-06 10:32:00, Miroslav Benes wrote: > > > > > > I don't have many code comments as the changes appear to safely and > > > > correctly do what the say. (We are at v14 after all :) I mainly > > > > compared the text and comments to

Re: [PATCH v14 00/11] livepatch: Atomic replace feature

2018-12-06 Thread Petr Mladek
On Thu 2018-12-06 11:15:55, Petr Mladek wrote: > On Thu 2018-12-06 10:32:00, Miroslav Benes wrote: > > > > > > I don't have many code comments as the changes appear to safely and > > > > correctly do what the say. (We are at v14 after all :) I mainly > > > > compared the text and comments to

Re: [PATCH v14 00/11] livepatch: Atomic replace feature

2018-12-06 Thread Petr Mladek
On Thu 2018-12-06 10:32:00, Miroslav Benes wrote: > > > > I don't have many code comments as the changes appear to safely and > > > correctly do what the say. (We are at v14 after all :) I mainly > > > compared the text and comments to the implementation and noted typos > > > (marked by

Re: [PATCH v14 00/11] livepatch: Atomic replace feature

2018-12-06 Thread Petr Mladek
On Thu 2018-12-06 10:32:00, Miroslav Benes wrote: > > > > I don't have many code comments as the changes appear to safely and > > > correctly do what the say. (We are at v14 after all :) I mainly > > > compared the text and comments to the implementation and noted typos > > > (marked by

Re: [PATCH v14 00/11] livepatch: Atomic replace feature

2018-12-06 Thread Miroslav Benes
> > I don't have many code comments as the changes appear to safely and > > correctly do what the say. (We are at v14 after all :) I mainly > > compared the text and comments to the implementation and noted typos > > (marked by substitution s/old/new) and awkward wordings (marked by > >

Re: [PATCH v14 00/11] livepatch: Atomic replace feature

2018-12-06 Thread Miroslav Benes
> > I don't have many code comments as the changes appear to safely and > > correctly do what the say. (We are at v14 after all :) I mainly > > compared the text and comments to the implementation and noted typos > > (marked by substitution s/old/new) and awkward wordings (marked by > >

Re: [PATCH v14 00/11] livepatch: Atomic replace feature

2018-12-05 Thread Petr Mladek
On Wed 2018-12-05 15:49:14, Joe Lawrence wrote: > On 11/29/2018 04:44 AM, Petr Mladek wrote: > > The atomic replace allows to create cumulative patches. They > > are useful when you maintain many livepatches and want to remove > > one that is lower on the stack. In addition it is very useful when

Re: [PATCH v14 00/11] livepatch: Atomic replace feature

2018-12-05 Thread Petr Mladek
On Wed 2018-12-05 15:49:14, Joe Lawrence wrote: > On 11/29/2018 04:44 AM, Petr Mladek wrote: > > The atomic replace allows to create cumulative patches. They > > are useful when you maintain many livepatches and want to remove > > one that is lower on the stack. In addition it is very useful when

Re: [PATCH v14 00/11] livepatch: Atomic replace feature

2018-12-05 Thread Joe Lawrence
On 11/29/2018 04:44 AM, Petr Mladek wrote: > Hi, > > I have an updated present for your mailboxes. > > The atomic replace allows to create cumulative patches. They > are useful when you maintain many livepatches and want to remove > one that is lower on the stack. In addition it is very useful

Re: [PATCH v14 00/11] livepatch: Atomic replace feature

2018-12-05 Thread Joe Lawrence
On 11/29/2018 04:44 AM, Petr Mladek wrote: > Hi, > > I have an updated present for your mailboxes. > > The atomic replace allows to create cumulative patches. They > are useful when you maintain many livepatches and want to remove > one that is lower on the stack. In addition it is very useful