Re: [PATCH v2] add -Wpointer-arith sparse flag to toggle sizeof(void) warnings

2018-04-09 Thread Joey Pabalinas
On Mon, Apr 09, 2018 at 12:51:01PM -1000, Joey Pabalinas wrote: > Ah, so should I include that change in the patch itself when I make a V3? Sending a v3 now incorporating the suggestions. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v2] add -Wpointer-arith sparse flag to toggle sizeof(void) warnings

2018-04-09 Thread Joey Pabalinas
On Sun, Apr 08, 2018 at 09:48:24AM +0200, Luc Van Oostenryck wrote: > With the warning disabled by default (for the moment), I had to adapt > the testsuite with: Ah, so should I include that change in the patch itself when I make a V3? > > +Warn about anything that depends on the \fBsizeof\fR a f

Re: [PATCH v2] add -Wpointer-arith sparse flag to toggle sizeof(void) warnings

2018-04-08 Thread Luc Van Oostenryck
On Sat, Apr 07, 2018 at 11:58:05AM -1000, Joey Pabalinas wrote: > Recent changes to the min()/max() macros in include/linux/kernel.h > have added a lot of noise when compiling the kernel with Sparse checking > enabled. This mostly is due to the *huge* increase in the number of > sizeof(void) warnin

Re: [PATCH v2] add -Wpointer-arith sparse flag to toggle sizeof(void) warnings

2018-04-07 Thread Linus Torvalds
Ack, looks sane. Linus